diff mbox series

[RFC,01/20] file: remove pointless comment

Message ID 20240830-vfs-file-f_version-v1-1-6d3e4816aa7b@kernel.org (mailing list archive)
State New
Headers show
Series file: remove f_version | expand

Commit Message

Christian Brauner Aug. 30, 2024, 1:04 p.m. UTC 
There's really no need to mention f_version.

Signed-off-by: Christian Brauner <brauner@kernel.org>
---
 fs/file_table.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Jan Kara Sept. 3, 2024, 10:28 a.m. UTC | #1 
On Fri 30-08-24 15:04:42, Christian Brauner wrote:
> There's really no need to mention f_version.
> 
> Signed-off-by: Christian Brauner <brauner@kernel.org>

Looks good. Feel free to add:

Reviewed-by: Jan Kara <jack@suse.cz>

								Honza

> ---
>  fs/file_table.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/fs/file_table.c b/fs/file_table.c
> index 3ef558f27a1c..bf1cbe47c93d 100644
> --- a/fs/file_table.c
> +++ b/fs/file_table.c
> @@ -159,7 +159,6 @@ static int init_file(struct file *f, int flags, const struct cred *cred)
>  	mutex_init(&f->f_pos_lock);
>  	f->f_flags = flags;
>  	f->f_mode = OPEN_FMODE(flags);
> -	/* f->f_version: 0 */
>  
>  	/*
>  	 * We're SLAB_TYPESAFE_BY_RCU so initialize f_count last. While
> 
> -- 
> 2.45.2
>
diff mbox series

Patch

diff --git a/fs/file_table.c b/fs/file_table.c
index 3ef558f27a1c..bf1cbe47c93d 100644
--- a/fs/file_table.c
+++ b/fs/file_table.c
@@ -159,7 +159,6 @@  static int init_file(struct file *f, int flags, const struct cred *cred)
 	mutex_init(&f->f_pos_lock);
 	f->f_flags = flags;
 	f->f_mode = OPEN_FMODE(flags);
-	/* f->f_version: 0 */
 
 	/*
 	 * We're SLAB_TYPESAFE_BY_RCU so initialize f_count last. While