| Message ID | 20241010-shstk_converge-v1-2-631beca676e7@rivosinc.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Converge common flows for cpu assisted shadow stack | expand |
On Thu, Oct 10, 2024 at 05:32:04PM -0700, Deepak Gupta wrote: > VM_SHADOW_STACK (alias to VM_HIGH_ARCH_5) is used to encode shadow stack > VMA on three architectures (x86 shadow stack, arm GCS and RISC-V shadow > stack). In case architecture doesn't implement shadow stack, it's VM_NONE > Introducing a helper `is_shadow_stack_vma` to determine shadow stack vma > or not. > > Signed-off-by: Deepak Gupta <debug@rivosinc.com> > --- > mm/gup.c | 2 +- > mm/vma.h | 10 +++++++--- > 2 files changed, 8 insertions(+), 4 deletions(-) As I noted in reply to the version of this patch in the RISC-V series there's another test for VM_SHADOW_STACK in mm/mmap.c.
On Fri, Oct 11, 2024 at 11:38:51AM +0100, Mark Brown wrote: >On Thu, Oct 10, 2024 at 05:32:04PM -0700, Deepak Gupta wrote: >> VM_SHADOW_STACK (alias to VM_HIGH_ARCH_5) is used to encode shadow stack >> VMA on three architectures (x86 shadow stack, arm GCS and RISC-V shadow >> stack). In case architecture doesn't implement shadow stack, it's VM_NONE >> Introducing a helper `is_shadow_stack_vma` to determine shadow stack vma >> or not. >> >> Signed-off-by: Deepak Gupta <debug@rivosinc.com> >> --- >> mm/gup.c | 2 +- >> mm/vma.h | 10 +++++++--- >> 2 files changed, 8 insertions(+), 4 deletions(-) > >As I noted in reply to the version of this patch in the RISC-V series >there's another test for VM_SHADOW_STACK in mm/mmap.c. Yeah will make sure to consolidate comments from both patch series in next version. Thanks.
diff --git a/mm/gup.c b/mm/gup.c index a82890b46a36..8e6e14179f6c 100644 --- a/mm/gup.c +++ b/mm/gup.c @@ -1282,7 +1282,7 @@ static int check_vma_flags(struct vm_area_struct *vma, unsigned long gup_flags) !writable_file_mapping_allowed(vma, gup_flags)) return -EFAULT; - if (!(vm_flags & VM_WRITE) || (vm_flags & VM_SHADOW_STACK)) { + if (!(vm_flags & VM_WRITE) || is_shadow_stack_vma(vm_flags)) { if (!(gup_flags & FOLL_FORCE)) return -EFAULT; /* hugetlb does not support FOLL_FORCE|FOLL_WRITE. */ diff --git a/mm/vma.h b/mm/vma.h index 819f994cf727..0f238dc37231 100644 --- a/mm/vma.h +++ b/mm/vma.h @@ -357,7 +357,7 @@ static inline struct vm_area_struct *vma_prev_limit(struct vma_iterator *vmi, } /* - * These three helpers classifies VMAs for virtual memory accounting. + * These four helpers classifies VMAs for virtual memory accounting. */ /* @@ -368,6 +368,11 @@ static inline bool is_exec_mapping(vm_flags_t flags) return (flags & (VM_EXEC | VM_WRITE | VM_STACK)) == VM_EXEC; } +static inline bool is_shadow_stack_vma(vm_flags_t vm_flags) +{ + return !!(vm_flags & VM_SHADOW_STACK); +} + /* * Stack area (including shadow stacks) * @@ -376,7 +381,7 @@ static inline bool is_exec_mapping(vm_flags_t flags) */ static inline bool is_stack_mapping(vm_flags_t flags) { - return ((flags & VM_STACK) == VM_STACK) || (flags & VM_SHADOW_STACK); + return ((flags & VM_STACK) == VM_STACK) || is_shadow_stack_vma(flags); } /* @@ -387,7 +392,6 @@ static inline bool is_data_mapping(vm_flags_t flags) return (flags & (VM_WRITE | VM_SHARED | VM_STACK)) == VM_WRITE; } - static inline void vma_iter_config(struct vma_iterator *vmi, unsigned long index, unsigned long last) {
VM_SHADOW_STACK (alias to VM_HIGH_ARCH_5) is used to encode shadow stack VMA on three architectures (x86 shadow stack, arm GCS and RISC-V shadow stack). In case architecture doesn't implement shadow stack, it's VM_NONE Introducing a helper `is_shadow_stack_vma` to determine shadow stack vma or not. Signed-off-by: Deepak Gupta <debug@rivosinc.com> --- mm/gup.c | 2 +- mm/vma.h | 10 +++++++--- 2 files changed, 8 insertions(+), 4 deletions(-)