From patchwork Mon Feb 24 21:20:41 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Al Viro X-Patchwork-Id: 13988962 Received: from zeniv.linux.org.uk (zeniv.linux.org.uk [62.89.141.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1560C1DB375 for ; Mon, 24 Feb 2025 21:20:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=62.89.141.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740432057; cv=none; b=uKhJIUbTnsek/n0wz4c+qgveXL15FwBTowXpxIpv6QQF5lQmGuNwmZNUp7KmkEy9oZs+FaFE0J5nPaPCLbd8xP3K9dqmM/pLW4JDnvMxYmWVyAKrfHC6c6DEjCNHC7LqXNlFg9DTfxFWU8E4943i5M3ekLeW+iB4iRzUAnofiSs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740432057; c=relaxed/simple; bh=d2659bhkIH35UsNdxRwr3J80C+cALvngos3Wn/bMAbQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=AnimxkVOmx5h/14B5LuZf7F/FAye/J3zgQPFvlKsxTvTnJ0MjU4rp7k9sqkA3/wvLuFYvedlxs9a+rbVqLPwesh+Zv/Y1359mqwHKrrHmrZy/WLN2yC0MwIfZYnlwsYP69WFS7H7W3/BW5sulnMh9D/+Z/m9sRgDiHls/1+K0/Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=zeniv.linux.org.uk; spf=none smtp.mailfrom=ftp.linux.org.uk; dkim=pass (2048-bit key) header.d=linux.org.uk header.i=@linux.org.uk header.b=R9nlPdnQ; arc=none smtp.client-ip=62.89.141.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=zeniv.linux.org.uk Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=ftp.linux.org.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linux.org.uk header.i=@linux.org.uk header.b="R9nlPdnQ" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=linux.org.uk; s=zeniv-20220401; h=Sender:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description; bh=ao6KHlhr+JzSMKp4DwoMsM8thCxjo1AWRSQjn4BSAhY=; b=R9nlPdnQWsXWIBLFQF9dd6kTdE F3DVVEdDXaoj7KVO+i+NqtiYvU0gc5SR2nHNsvCTFchTycNi4Q9DIkR8s1gLsAv5PdT9r3tN5ucvI D7didh2eClFLX1ARdgL14KPViGut75CNaEu46yttRnrS4RqUjJOfySY5UTTEsfqMGdxcuLqb2qpiV 4Nkk3w8kMDL5erj/CDA+XJmXETS7mVeGamPcb0prEDAUS4P4sYXOnF1K88inQptOGMtt9q7tmZkLX c8IFWR8iwVQMe+XIvzLl4QloSGqkBHDF9cy8dSnF8nR9CC052DiLz6L80OPa2qKtGDKywl+1R09DI 34SNjo0w==; Received: from viro by zeniv.linux.org.uk with local (Exim 4.98 #2 (Red Hat Linux)) id 1tmfsi-00000007Mxx-2jDq; Mon, 24 Feb 2025 21:20:52 +0000 From: Al Viro To: linux-fsdevel@vger.kernel.org Cc: Linus Torvalds , Christian Brauner , Neil Brown , Miklos Szeredi , Jan Kara Subject: [PATCH 11/21] nsfs, pidfs: drop the pointless ->d_delete() Date: Mon, 24 Feb 2025 21:20:41 +0000 Message-ID: <20250224212051.1756517-11-viro@zeniv.linux.org.uk> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250224212051.1756517-1-viro@zeniv.linux.org.uk> References: <20250224141444.GX1977892@ZenIV> <20250224212051.1756517-1-viro@zeniv.linux.org.uk> Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Sender: Al Viro No dentries are ever hashed on those, so ->d_delete() wouldn't be even looked at. If it's unhashed, we are not retaining it in dcache once the refcount hits zero, no matter what. Signed-off-by: Al Viro --- fs/nsfs.c | 1 - fs/pidfs.c | 1 - 2 files changed, 2 deletions(-) diff --git a/fs/nsfs.c b/fs/nsfs.c index 663f8656158d..f7fddf8ecf73 100644 --- a/fs/nsfs.c +++ b/fs/nsfs.c @@ -37,7 +37,6 @@ static char *ns_dname(struct dentry *dentry, char *buffer, int buflen) } const struct dentry_operations ns_dentry_operations = { - .d_delete = always_delete_dentry, .d_dname = ns_dname, .d_prune = stashed_dentry_prune, }; diff --git a/fs/pidfs.c b/fs/pidfs.c index 63f9699ebac3..c0478b3c55d9 100644 --- a/fs/pidfs.c +++ b/fs/pidfs.c @@ -521,7 +521,6 @@ static char *pidfs_dname(struct dentry *dentry, char *buffer, int buflen) } const struct dentry_operations pidfs_dentry_operations = { - .d_delete = always_delete_dentry, .d_dname = pidfs_dname, .d_prune = stashed_dentry_prune, };