diff mbox series

[-next] ext4: correct the error handle in ext4_fallocate()

Message ID 20250319023557.2785018-1-yi.zhang@huaweicloud.com (mailing list archive)
State New
Headers show
Series [-next] ext4: correct the error handle in ext4_fallocate() | expand

Commit Message

Zhang Yi March 19, 2025, 2:35 a.m. UTC 
From: Zhang Yi <yi.zhang@huawei.com>

The error out label of file_modified() should be out_inode_lock in
ext4_fallocate().

Fixes: 2890e5e0f49e ("ext4: move out common parts into ext4_fallocate()")
Reported-by: Baokun Li <libaokun1@huawei.com>
Signed-off-by: Zhang Yi <yi.zhang@huawei.com>
---
 fs/ext4/extents.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Baokun Li March 19, 2025, 7:30 a.m. UTC | #1 
On 2025/3/19 10:35, Zhang Yi wrote:
> From: Zhang Yi <yi.zhang@huawei.com>
>
> The error out label of file_modified() should be out_inode_lock in
> ext4_fallocate().
>
> Fixes: 2890e5e0f49e ("ext4: move out common parts into ext4_fallocate()")
> Reported-by: Baokun Li <libaokun1@huawei.com>
> Signed-off-by: Zhang Yi <yi.zhang@huawei.com>
> ---
Looks good. Feel free to add:

Reviewed-by: Baokun Li <libaokun1@huawei.com>
>   fs/ext4/extents.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
> index 1b028be19193..dcc49df190ed 100644
> --- a/fs/ext4/extents.c
> +++ b/fs/ext4/extents.c
> @@ -4744,7 +4744,7 @@ long ext4_fallocate(struct file *file, int mode, loff_t offset, loff_t len)
>   
>   	ret = file_modified(file);
>   	if (ret)
> -		return ret;
> +		goto out_inode_lock;
>   
>   	if ((mode & FALLOC_FL_MODE_MASK) == FALLOC_FL_ALLOCATE_RANGE) {
>   		ret = ext4_do_fallocate(file, offset, len, mode);
Theodore Ts'o March 22, 2025, 3:36 a.m. UTC | #2 
On Wed, 19 Mar 2025 10:35:57 +0800, Zhang Yi wrote:
> The error out label of file_modified() should be out_inode_lock in
> ext4_fallocate().
> 
> 

Applied, thanks!

[1/1] ext4: correct the error handle in ext4_fallocate()
      commit: 129245cfbd6d79c6d603f357f428010ccc0f0ee7

Best regards,
diff mbox series

Patch

diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index 1b028be19193..dcc49df190ed 100644
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -4744,7 +4744,7 @@  long ext4_fallocate(struct file *file, int mode, loff_t offset, loff_t len)
 
 	ret = file_modified(file);
 	if (ret)
-		return ret;
+		goto out_inode_lock;
 
 	if ((mode & FALLOC_FL_MODE_MASK) == FALLOC_FL_ALLOCATE_RANGE) {
 		ret = ext4_do_fallocate(file, offset, len, mode);