From patchwork Thu Aug 4 19:27:37 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jens Axboe X-Patchwork-Id: 9264147 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 0B9FA6048B for ; Thu, 4 Aug 2016 19:27:45 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id EDBD828335 for ; Thu, 4 Aug 2016 19:27:44 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E1A7E2841F; Thu, 4 Aug 2016 19:27:44 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8AC2A28335 for ; Thu, 4 Aug 2016 19:27:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934090AbcHDT1m (ORCPT ); Thu, 4 Aug 2016 15:27:42 -0400 Received: from mail-it0-f45.google.com ([209.85.214.45]:36384 "EHLO mail-it0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965064AbcHDT1l (ORCPT ); Thu, 4 Aug 2016 15:27:41 -0400 Received: by mail-it0-f45.google.com with SMTP id x130so4194575ite.1 for ; Thu, 04 Aug 2016 12:27:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=MEjb/oCQh8XbMHjqwDWeUs5aUb93MFLGUlaDPZ0BXzY=; b=o0l9xTiZwkXpPReW7R2g7G2ngJd/4ZHyGckXIowdmWYGjEhcbs/eChSEqCI9l8D/XZ H1dqoTvoN+kCZyjsAkASQbFm+byFI4woKPCE4GUODuw+gLo9HTxXDXesE+C69or1W65c xBBmM+2ShQAHWtByYw/yKs3verThgykPXz2Gxd/Rf5TpxEbMChVEW8uGirMf73BT8BOK 8OZ8/UyUTjf90bT1SyboPLuxQBHNjF3lhdbSXSdgFG2UAgT5KK+razb9J8fHD+EFBf5R LDEfd4eeRbaUAVBR3mlsSF1CbbDYU+qjBseHzBXC/a6h+XYjxk6BwxWPeB2Tv3LP0Dqv 0rFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=MEjb/oCQh8XbMHjqwDWeUs5aUb93MFLGUlaDPZ0BXzY=; b=HDUY3qHEAPjfGIPc0gpXBCKaV+f9OCGFp8ViZCKsNOzeYw6kGRGXEKp0Ip7H7jiJ4D 3j6zamlcoBgUsTCLWceplYPu+KDzwsDgOgXi7gTYvg0ZYRjQ4xC8cwajIJZs8dfVqSqv RDed5H4y5qVslXloxLwXl5S4mux1CNzZR2/FJcq8xK0ynj2M6QLy75+s2zeLrxxz4rPT mZy5uM7a12k60deA6UPeneQc84ysunUJBXwzQGEA4q/mXVMydzmg8Vd+5NmjXHB+/H6d zLcLYi+1zGkRy9gqmYIRbdl/Zboea0LgBdrnSgSrH7uqeyfUrRdgt2Lw94XZ6xctxCIp FzUw== X-Gm-Message-State: AEkoousGiJwJcI2vwDAMqI6D+tUIUph1tMrQUeK48Wi+7+TeWldtjQq5CqFwuTEKNVkPsA== X-Received: by 10.36.204.68 with SMTP id x65mr79711811itf.54.1470338859653; Thu, 04 Aug 2016 12:27:39 -0700 (PDT) Received: from [192.168.1.132] ([216.160.245.98]) by smtp.gmail.com with ESMTPSA id h67sm6392730ioe.40.2016.08.04.12.27.38 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 04 Aug 2016 12:27:38 -0700 (PDT) Subject: Re: [PATCH 1/1] mm/block: convert rw_page users to bio op use To: kbuild test robot , Mike Christie References: <201608050158.hllBWy4G%fengguang.wu@intel.com> Cc: kbuild-all@01.org, ross.zwisler@linux.intel.com, linux-ext4@vger.kernel.org, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, david@fromorbit.com, minchan@kernel.org, ngupta@vflare.org, vishal.l.verma@intel.com From: Jens Axboe Message-ID: <38523086-1436-fdbf-bd89-9f31ad134bed@kernel.dk> Date: Thu, 4 Aug 2016 13:27:37 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <201608050158.hllBWy4G%fengguang.wu@intel.com> Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On 08/04/2016 11:50 AM, kbuild test robot wrote: > Hi Mike, > > [auto build test ERROR on linus/master] > [also build test ERROR on next-20160804] > [cannot apply to v4.7] > [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] > > url: https://github.com/0day-ci/linux/commits/Mike-Christie/mm-block-convert-rw_page-users-to-bio-op-use/20160805-012041 > config: i386-tinyconfig (attached as .config) > compiler: gcc-6 (Debian 6.1.1-9) 6.1.1 20160705 > reproduce: > # save the attached .config to linux build tree > make ARCH=i386 > > All errors (new ones prefixed by >>): > > mm/filemap.c: In function 'page_endio': >>> mm/filemap.c:892:7: error: implicit declaration of function 'op_is_write' [-Werror=implicit-function-declaration] > if (!op_is_write(op)) { > ^~~~~~~~~~~ Mike, how about moving op_is_write() outside of CONFIG_BLOCK protection in fs.h, and making the REQ_OP_* enum generally available as well? That should fix it. */ diff --git a/include/linux/blk_types.h b/include/linux/blk_types.h index f254eb264924..14b28ff2caf8 100644 --- a/include/linux/blk_types.h +++ b/include/linux/blk_types.h @@ -18,6 +18,17 @@ struct cgroup_subsys_state; typedef void (bio_end_io_t) (struct bio *); typedef void (bio_destructor_t) (struct bio *); +enum req_op { + REQ_OP_READ, + REQ_OP_WRITE, + REQ_OP_DISCARD, /* request to discard sectors */ + REQ_OP_SECURE_ERASE, /* request to securely erase sectors */ + REQ_OP_WRITE_SAME, /* write same block many times */ + REQ_OP_FLUSH, /* request for cache flush */ +}; + +#define REQ_OP_BITS 3 + #ifdef CONFIG_BLOCK /* * main unit of I/O for the block layer and lower layers (ie drivers and @@ -228,17 +239,6 @@ enum rq_flag_bits { #define REQ_HASHED (1ULL << __REQ_HASHED) #define REQ_MQ_INFLIGHT (1ULL << __REQ_MQ_INFLIGHT) -enum req_op { - REQ_OP_READ, - REQ_OP_WRITE, - REQ_OP_DISCARD, /* request to discard sectors */ - REQ_OP_SECURE_ERASE, /* request to securely erase sectors */ - REQ_OP_WRITE_SAME, /* write same block many times */ - REQ_OP_FLUSH, /* request for cache flush */ -}; - -#define REQ_OP_BITS 3 - typedef unsigned int blk_qc_t; #define BLK_QC_T_NONE -1U #define BLK_QC_T_SHIFT 16 diff --git a/include/linux/fs.h b/include/linux/fs.h index f2a69f20926f..13cc1bfce9aa 100644 --- a/include/linux/fs.h +++ b/include/linux/fs.h @@ -2465,12 +2465,13 @@ extern void init_special_inode(struct inode *, umode_t, dev_t); extern void make_bad_inode(struct inode *); extern bool is_bad_inode(struct inode *); -#ifdef CONFIG_BLOCK static inline bool op_is_write(unsigned int op) { return op == REQ_OP_READ ? false : true; } +#ifdef CONFIG_BLOCK + /* * return data direction, READ or WRITE