From patchwork Wed Feb 11 10:58:56 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Boaz Harrosh X-Patchwork-Id: 5812081 Return-Path: X-Original-To: patchwork-linux-fsdevel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 2A3AD9F30C for ; Wed, 11 Feb 2015 10:59:03 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 4542820149 for ; Wed, 11 Feb 2015 10:59:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2AAE42011D for ; Wed, 11 Feb 2015 10:59:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752012AbbBKK67 (ORCPT ); Wed, 11 Feb 2015 05:58:59 -0500 Received: from mail-wi0-f175.google.com ([209.85.212.175]:51682 "EHLO mail-wi0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751584AbbBKK67 (ORCPT ); Wed, 11 Feb 2015 05:58:59 -0500 Received: by mail-wi0-f175.google.com with SMTP id r20so16074458wiv.2 for ; Wed, 11 Feb 2015 02:58:58 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :subject:content-type:content-transfer-encoding; bh=xvCtEeOKHtjXVXVAFSr7UtptqH5lNMeE4pB4PLoWS5c=; b=judrXOVFBLBuN5SQ/XcILSuA4O3HmnGnVHYzVoRz0pDgoo8igBUNUzD0pep3KqXz2w z9mZ9ekIM2F3LGp1J+vfW2KMdqA9cN93WACGsAEogRmpXxyTZ74S4gM6tiJTiWGlMJky rAqk9yc+4P79t74xGO7FYvBRLXKCP9OqDXIYzYgXs667yXN/Wde5HpTp+StSbW5bSrJT qwTJOT8/wceifcrEmQTT2IiI+0FrOPRO8zCHfeYCEv99kgPyU8OixdlJy+1Hl24fKopx a8Yvr1HRsWukUyXZoFDr9/wl6OYRX9rGLQVG2EbVcn+dqduwDDp37LXCKwlkrgNpSlqC ETyg== X-Gm-Message-State: ALoCoQniTwpikUBZFghI5QndYDm0nmjrF0KsnLgbI6KtcaGB6cifPR2tolZ4cNttJIoa3TlAVdJk X-Received: by 10.180.21.162 with SMTP id w2mr54583704wie.42.1423652338064; Wed, 11 Feb 2015 02:58:58 -0800 (PST) Received: from [10.0.0.5] ([207.232.55.62]) by mx.google.com with ESMTPSA id ha1sm22733595wib.24.2015.02.11.02.58.57 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 11 Feb 2015 02:58:57 -0800 (PST) Message-ID: <54DB35F0.1010203@plexistor.com> Date: Wed, 11 Feb 2015 12:58:56 +0200 From: Boaz Harrosh User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Dave Chinner , xfs@oss.sgi.com, linux-fsdevel Subject: shared/032 is broken on Fedora Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This is not the proper patch just to show a working version for Fedora. But I think it now breaks the other ARCHs. What happens is that the output of ${MKFS_PROG}.* is: /usr/sbin/mkfs.bfs /usr/sbin/mkfs.btrfs /usr/sbin/mkfs.cramfs /usr/sbin/mkfs.ext2 /usr/sbin/mkfs.ext3 /usr/sbin/mkfs.ext4 ... So in Fedora sbin has moved to /usr/... and therefor the sed below fails. My sed foo is not good enough. How to support both places for sbin? Also why the "_supported_fs xfs btrfs"? So if all those other mkfs.* that are destructive to foreign filesystem, should the test not fail instead of skipped? Maybe if the maintainers of all these filesystems day in and day out running xfstests and see shared/032 failing, they might decide to fix their evil ways. Instead of skipping the test and the said maintainer just ignores it? Thanks Boaz --- -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/tests/shared/032 b/tests/shared/032 index a410003..726e6b4 100755 --- a/tests/shared/032 +++ b/tests/shared/032 @@ -37,8 +37,8 @@ rm -f $seqres.full . ./common/filter # real QA test starts here -_supported_fs xfs btrfs +# _supported_fs xfs btrfs _supported_os Linux _require_scratch_nocheck _require_no_large_scratch_dev @@ -49,8 +49,7 @@ if [ "$FSTYP" == "btrfs" ]; then _notrun "Installed mkfs.btrfs does not support -f option" fi -echo "Silence is golden." -for fs in `echo ${MKFS_PROG}.* | sed -e 's/.sbin.mkfs.//g'` +for fs in `echo ${MKFS_PROG}.* | sed -e 's/.usr\/sbin.mkfs.//g'` do preop="" # for special input needs preargs="" # for any special pre-device options