diff mbox

mmotm 2015-04-01-14-54 uploaded

Message ID 551D0101.6000301@arm.com (mailing list archive)
State New, archived
Headers show

Commit Message

Vladimir Murzin April 2, 2015, 8:42 a.m. UTC 
On 01/04/15 22:55, akpm@linux-foundation.org wrote:
> * mm-move-memtest-under-mm.patch
> * mm-move-memtest-under-mm-fix.patch

It was noticed by Paul Bolle (and his clever bot) that patch above
simply disables MEMTEST altogether [1]. Could you fold fix for that, please?

--

[1] https://lkml.org/lkml/2015/3/20/119

Thanks
Vladimir

> * memtest-use-phys_addr_t-for-physical-addresses.patch
> * arm64-add-support-for-memtest.patch
> * arm-add-support-for-memtest.patch
> * kconfig-memtest-update-number-of-test-patterns-up-to-17.patch
> * documentation-update-arch-list-in-the-memtest-entry.patch

--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Paul Bolle April 2, 2015, 6:52 p.m. UTC | #1 
On Thu, 2015-04-02 at 09:42 +0100, Vladimir Murzin wrote:
> It was noticed by Paul Bolle (and his clever bot) that patch above
> simply disables MEMTEST altogether [1]. 

This needs correcting.

The clever bot is a project of Andreas Ruprecht, Stefan Hengelein, and
Valentin Rothberg. I've only been cheering their efforts.

I noticed this issue because I wrote a 800 line perl monster that checks
this stuff. It's only slightly more advanced than
scripts/checkkconfigsymbols.py (which Stefan and Valentin wrote). And
I'm sure that python script would have spotted this issue too.

Thanks,


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
index ea369dd..cd6d74b 100644
--- a/lib/Kconfig.debug
+++ b/lib/Kconfig.debug
@@ -1810,7 +1810,7 @@  config TEST_UDELAY

 config MEMTEST
 	bool "Memtest"
-	depends on MEMBLOCK
+	depends on HAVE_MEMBLOCK
 	---help---
 	  This option adds a kernel parameter 'memtest', which allows memtest
 	  to be set.