| Message ID | 627c14b7987a3ab91d9bff31b99d86167d56f476.1729879630.git.ritesh.list@gmail.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | xfs: Do not fallback to buffered-io for DIO atomic write | expand |
On Fri, Oct 25, 2024 at 11:48:05PM +0530, Ritesh Harjani (IBM) wrote: > iomap can return -ENOTBLK if pagecache invalidation fails. > Let's make sure if -ENOTBLK is ever returned for atomic > writes than we fail the write request (-EIO) instead of > fallback to buffered-io. > > Suggested-by: Darrick J. Wong <djwong@kernel.org> > Signed-off-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com> Looks good to me, Reviewed-by: Darrick J. Wong <djwong@kernel.org> --D > --- > > This should be on top of John's atomic write series [1]. > [1]: https://lore.kernel.org/linux-xfs/20241019125113.369994-1-john.g.garry@oracle.com/ > > fs/xfs/xfs_file.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/fs/xfs/xfs_file.c b/fs/xfs/xfs_file.c > index ca47cae5a40a..b819a9273511 100644 > --- a/fs/xfs/xfs_file.c > +++ b/fs/xfs/xfs_file.c > @@ -876,6 +876,14 @@ xfs_file_write_iter( > ret = xfs_file_dio_write(iocb, from); > if (ret != -ENOTBLK) > return ret; > + /* > + * iomap can return -ENOTBLK if pagecache invalidation fails. > + * Let's make sure if -ENOTBLK is ever returned for atomic > + * writes than we fail the write request instead of fallback > + * to buffered-io. > + */ > + if (iocb->ki_flags & IOCB_ATOMIC) > + return -EIO; > } > > return xfs_file_buffered_write(iocb, from); > -- > 2.39.5 > >
We need not pick this patch up. As after the careful review of the code, it seems XFS can never fallback to buffered-io for DIO atomic writes. Hence we don't need this patch. More details in [1]. [1]: https://lore.kernel.org/linux-xfs/cover.1729825985.git.ritesh.list@gmail.com/T/#m9dbecc11bed713ed0d7a486432c56b105b555f04 (Sorry for the noise). "Ritesh Harjani (IBM)" <ritesh.list@gmail.com> writes: > iomap can return -ENOTBLK if pagecache invalidation fails. > Let's make sure if -ENOTBLK is ever returned for atomic > writes than we fail the write request (-EIO) instead of > fallback to buffered-io. > > Suggested-by: Darrick J. Wong <djwong@kernel.org> > Signed-off-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com> > --- > > This should be on top of John's atomic write series [1]. > [1]: https://lore.kernel.org/linux-xfs/20241019125113.369994-1-john.g.garry@oracle.com/ > > fs/xfs/xfs_file.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/fs/xfs/xfs_file.c b/fs/xfs/xfs_file.c > index ca47cae5a40a..b819a9273511 100644 > --- a/fs/xfs/xfs_file.c > +++ b/fs/xfs/xfs_file.c > @@ -876,6 +876,14 @@ xfs_file_write_iter( > ret = xfs_file_dio_write(iocb, from); > if (ret != -ENOTBLK) > return ret; > + /* > + * iomap can return -ENOTBLK if pagecache invalidation fails. > + * Let's make sure if -ENOTBLK is ever returned for atomic > + * writes than we fail the write request instead of fallback > + * to buffered-io. > + */ > + if (iocb->ki_flags & IOCB_ATOMIC) > + return -EIO; > } > > return xfs_file_buffered_write(iocb, from); > -- > 2.39.5
diff --git a/fs/xfs/xfs_file.c b/fs/xfs/xfs_file.c index ca47cae5a40a..b819a9273511 100644 --- a/fs/xfs/xfs_file.c +++ b/fs/xfs/xfs_file.c @@ -876,6 +876,14 @@ xfs_file_write_iter( ret = xfs_file_dio_write(iocb, from); if (ret != -ENOTBLK) return ret; + /* + * iomap can return -ENOTBLK if pagecache invalidation fails. + * Let's make sure if -ENOTBLK is ever returned for atomic + * writes than we fail the write request instead of fallback + * to buffered-io. + */ + if (iocb->ki_flags & IOCB_ATOMIC) + return -EIO; } return xfs_file_buffered_write(iocb, from);
iomap can return -ENOTBLK if pagecache invalidation fails. Let's make sure if -ENOTBLK is ever returned for atomic writes than we fail the write request (-EIO) instead of fallback to buffered-io. Suggested-by: Darrick J. Wong <djwong@kernel.org> Signed-off-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com> --- This should be on top of John's atomic write series [1]. [1]: https://lore.kernel.org/linux-xfs/20241019125113.369994-1-john.g.garry@oracle.com/ fs/xfs/xfs_file.c | 8 ++++++++ 1 file changed, 8 insertions(+) -- 2.39.5