| Message ID | 722f4cf6-9b51-f7c9-e645-ca1f79dc7a67@infradead.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2] fs/posix_acl.c: fix kernel-doc warnings, formatting, and typo | expand |
On Mon 03-09-18 15:40:34, Randy Dunlap wrote: > From: Randy Dunlap <rdunlap@infradead.org> > > Fix kernel-doc warnings in fs/posic_acl.c. > Also fix one typo (setgit -> setgid). > > ../fs/posix_acl.c:646: warning: Function parameter or member 'inode' not described in 'posix_acl_update_mode' > ../fs/posix_acl.c:646: warning: Function parameter or member 'mode_p' not described in 'posix_acl_update_mode' > ../fs/posix_acl.c:646: warning: Function parameter or member 'acl' not described in 'posix_acl_update_mode' > > Fixes: 073931017b49d ("posix_acl: Clear SGID bit when setting file permissions") > > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Cc: Jan Kara <jack@suse.cz> > Cc: Andreas Gruenbacher <agruenba@redhat.com> > Cc: Alexander Viro <viro@zeniv.linux.org.uk> > Cc: linux-fsdevel@vger.kernel.org > Acked-by: Andreas Gruenbacher <agruenba@redhat.com> Looks good to me. You can add: Reviewed-by: Jan Kara <jack@suse.cz> Honza > --- > v2: change *acl to *@acl > > fs/posix_acl.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > --- lnx-419-rc2.orig/fs/posix_acl.c > +++ lnx-419-rc2/fs/posix_acl.c > @@ -630,12 +630,15 @@ EXPORT_SYMBOL_GPL(posix_acl_create); > > /** > * posix_acl_update_mode - update mode in set_acl > + * @inode: target inode > + * @mode_p: mode (pointer) for update > + * @acl: acl pointer > * > * Update the file mode when setting an ACL: compute the new file permission > * bits based on the ACL. In addition, if the ACL is equivalent to the new > - * file mode, set *acl to NULL to indicate that no ACL should be set. > + * file mode, set *@acl to NULL to indicate that no ACL should be set. > * > - * As with chmod, clear the setgit bit if the caller is not in the owning group > + * As with chmod, clear the setgid bit if the caller is not in the owning group > * or capable of CAP_FSETID (see inode_change_ok). > * > * Called from set_acl inode operations. > >
--- lnx-419-rc2.orig/fs/posix_acl.c +++ lnx-419-rc2/fs/posix_acl.c @@ -630,12 +630,15 @@ EXPORT_SYMBOL_GPL(posix_acl_create); /** * posix_acl_update_mode - update mode in set_acl + * @inode: target inode + * @mode_p: mode (pointer) for update + * @acl: acl pointer * * Update the file mode when setting an ACL: compute the new file permission * bits based on the ACL. In addition, if the ACL is equivalent to the new - * file mode, set *acl to NULL to indicate that no ACL should be set. + * file mode, set *@acl to NULL to indicate that no ACL should be set. * - * As with chmod, clear the setgit bit if the caller is not in the owning group + * As with chmod, clear the setgid bit if the caller is not in the owning group * or capable of CAP_FSETID (see inode_change_ok). * * Called from set_acl inode operations.