| Message ID | 867904ba-85fe-4766-91cb-3c8ce0703c1e@stanley.mountain (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | netfs: silence an uninitialized variable warning | expand |
On Mon, 18 Nov 2024 09:08:19 +0300, Dan Carpenter wrote: > Smatch complains that "ret" is uninitialized on the success path if we > don't enter the nested loop at the end of the function. In real life we > will enter that loop so "ret" will be zero. > > Generally, I don't endorse silencing static checker warnings but in this > case, I think it make sense. > > [...] Applied to the vfs-6.14.netfs branch of the vfs/vfs.git tree. Patches in the vfs-6.14.netfs branch should appear in linux-next soon. Please report any outstanding bugs that were missed during review in a new review to the original patch series allowing us to drop it. It's encouraged to provide Acked-bys and Reviewed-bys even though the patch has now been applied. If possible patch trailers will be updated. Note that commit hashes shown below are subject to change due to rebase, trailer updates or similar. If in doubt, please check the listed branch. tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git branch: vfs-6.14.netfs [1/1] netfs: silence an uninitialized variable warning https://git.kernel.org/vfs/vfs/c/574cb560cc1c
diff --git a/fs/netfs/write_issue.c b/fs/netfs/write_issue.c index cd2b349243b3..8f02d8effe78 100644 --- a/fs/netfs/write_issue.c +++ b/fs/netfs/write_issue.c @@ -862,7 +862,7 @@ int netfs_writeback_single(struct address_space *mapping, struct netfs_inode *ictx = netfs_inode(mapping->host); struct folio_queue *fq; size_t size = iov_iter_count(iter); - int ret; + int ret = 0; if (WARN_ON_ONCE(!iov_iter_is_folioq(iter))) return -EIO;
Smatch complains that "ret" is uninitialized on the success path if we don't enter the nested loop at the end of the function. In real life we will enter that loop so "ret" will be zero. Generally, I don't endorse silencing static checker warnings but in this case, I think it make sense. Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> --- fs/netfs/write_issue.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)