From patchwork Thu Nov 23 23:53:36 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: NeilBrown X-Patchwork-Id: 10073387 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 57E626020C for ; Thu, 23 Nov 2017 23:53:55 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4AB9728A9E for ; Thu, 23 Nov 2017 23:53:55 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3F26D2A0C2; Thu, 23 Nov 2017 23:53:55 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id AFE7F28A9E for ; Thu, 23 Nov 2017 23:53:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753379AbdKWXxt (ORCPT ); Thu, 23 Nov 2017 18:53:49 -0500 Received: from mx2.suse.de ([195.135.220.15]:40709 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753353AbdKWXxs (ORCPT ); Thu, 23 Nov 2017 18:53:48 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 6AFDEAAF1; Thu, 23 Nov 2017 23:53:46 +0000 (UTC) From: NeilBrown To: "Michael Kerrisk \(man-pages\)" Date: Fri, 24 Nov 2017 10:53:36 +1100 Cc: mtk.manpages@gmail.com, linux-man@vger.kernel.org, "linux-nfs\@vger.kernel.org" , "linux-fsdevel\@vger.kernel.org" , Lennart Poettering Subject: [manpages PATCH] open_by_handle_at.2: clarify MAX_HANDLE_SZ In-Reply-To: <52c5800b-150a-7ec9-133b-6c32e97249f4@gmail.com> References: <87wp2j1ggu.fsf@notabene.neil.brown.name> <52c5800b-150a-7ec9-133b-6c32e97249f4@gmail.com> Message-ID: <873754zh4v.fsf@notabene.neil.brown.name> MIME-Version: 1.0 Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP As hinted in the kernel source, MAX_HANDLE_SZ is a hint rather than a promise: /* limit the handle size to NFSv4 handle size now */ #define MAX_HANDLE_SZ 128 Note the "now" (probably should be "for now"). So change the description to make this clear. Reported-by: Lennart Poettering Signed-off-by: NeilBrown --- man2/open_by_handle_at.2 | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/man2/open_by_handle_at.2 b/man2/open_by_handle_at.2 index 79987308bf3e..f3473d24fa50 100644 --- a/man2/open_by_handle_at.2 +++ b/man2/open_by_handle_at.2 @@ -91,7 +91,8 @@ field should be initialized to contain the allocated size for .BR MAX_HANDLE_SZ , defined in .IR , -specifies the maximum possible size for a file handle.) +specifies the maximum expected size for a file handle. It is not a +guaranteed upper limit as future filesystems may require more space.) Upon successful return, the .IR handle_bytes field is updated to contain the number of bytes actually written to