From patchwork Sat Jun 6 19:30:52 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Eric W. Biederman" X-Patchwork-Id: 6560071 Return-Path: X-Original-To: patchwork-linux-fsdevel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 3F8F7C0020 for ; Sat, 6 Jun 2015 19:36:04 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 4E12D2066A for ; Sat, 6 Jun 2015 19:36:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1B3CB20668 for ; Sat, 6 Jun 2015 19:36:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752941AbbFFTgA (ORCPT ); Sat, 6 Jun 2015 15:36:00 -0400 Received: from out01.mta.xmission.com ([166.70.13.231]:56723 "EHLO out01.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752858AbbFFTf7 (ORCPT ); Sat, 6 Jun 2015 15:35:59 -0400 Received: from in01.mta.xmission.com ([166.70.13.51]) by out01.mta.xmission.com with esmtps (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1Z1Jst-0000Pc-8d; Sat, 06 Jun 2015 13:35:59 -0600 Received: from 67-3-205-90.omah.qwest.net ([67.3.205.90] helo=x220.int.ebiederm.org.xmission.com) by in01.mta.xmission.com with esmtpsa (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1Z1Jss-0005e1-Gb; Sat, 06 Jun 2015 13:35:59 -0600 From: ebiederm@xmission.com (Eric W. Biederman) To: Al Viro Cc: Omar Sandoval , linux-fsdevel@vger.kernel.org, Ivan Delalande References: <20150515185820.GQ20468@ycc.fr> <20150520100557.GB32189@mew> <87bnhedhw5.fsf_-_@x220.int.ebiederm.org> <20150520232325.GA7232@ZenIV.linux.org.uk> <20150603205128.GN22078@ycc.fr> <87pp58wsbn.fsf@x220.int.ebiederm.org> Date: Sat, 06 Jun 2015 14:30:52 -0500 In-Reply-To: <87pp58wsbn.fsf@x220.int.ebiederm.org> (Eric W. Biederman's message of "Sat, 06 Jun 2015 14:27:24 -0500") Message-ID: <87h9qkws5v.fsf_-_@x220.int.ebiederm.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 X-XM-AID: U2FsdGVkX19LBOkWOGKpnPkfca48ujf+3mD/YYPrTfM= X-SA-Exim-Connect-IP: 67.3.205.90 X-SA-Exim-Mail-From: ebiederm@xmission.com X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-DCC: XMission; sa04 1397; Body=1 Fuz1=1 Fuz2=1 X-Spam-Combo: ;Al Viro X-Spam-Relay-Country: X-Spam-Timing: total 361 ms - load_scoreonly_sql: 0.05 (0.0%), signal_user_changed: 5 (1.4%), b_tie_ro: 3.6 (1.0%), parse: 1.17 (0.3%), extract_message_metadata: 20 (5.6%), get_uri_detail_list: 1.80 (0.5%), tests_pri_-1000: 9 (2.6%), tests_pri_-950: 1.16 (0.3%), tests_pri_-900: 0.92 (0.3%), tests_pri_-400: 20 (5.6%), check_bayes: 19 (5.3%), b_tokenize: 5 (1.5%), b_tok_get_all: 6 (1.7%), b_comp_prob: 2.1 (0.6%), b_tok_touch_all: 2.9 (0.8%), b_finish: 0.87 (0.2%), tests_pri_0: 293 (81.2%), tests_pri_500: 6 (1.7%), rewrite_mail: 0.00 (0.0%) Subject: [PATCH] vfs: Remove incorrect debugging WARN in prepend_path X-SA-Exim-Version: 4.2.1 (built Wed, 24 Sep 2014 11:00:52 -0600) X-SA-Exim-Scanned: Yes (on in01.mta.xmission.com) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The warning message in prepend_path is unclear and outdated. It was added as a warning that the mechanism for generating names of pseudo files had been removed from prepend_path and d_dname should be used instead. Unfortunately the warning reads like a general warning, making it unclear what to do with it. Remove the warning. The transition it was added to warn about is long over, and I added code several years ago which in rare cases causes the warning to fire on legitimate code, and the warning is now firing and scaring people for no good reason. Cc: stable@vger.kernel.org Reported-by: Ivan Delalande Reported-by: Omar Sandoval Fixes: f48cfddc6729e ("vfs: In d_path don't call d_dname on a mount point") Signed-off-by: "Eric W. Biederman" --- Al would you like to pick this one up or should I? fs/dcache.c | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/fs/dcache.c b/fs/dcache.c index 656ce522a218..615dfc2aa752 100644 --- a/fs/dcache.c +++ b/fs/dcache.c @@ -2927,17 +2927,6 @@ restart: vfsmnt = &mnt->mnt; continue; } - /* - * Filesystems needing to implement special "root names" - * should do so with ->d_dname() - */ - if (IS_ROOT(dentry) && - (dentry->d_name.len != 1 || - dentry->d_name.name[0] != '/')) { - WARN(1, "Root dentry has weird name <%.*s>\n", - (int) dentry->d_name.len, - dentry->d_name.name); - } if (!error) error = is_mounted(vfsmnt) ? 1 : 2; break;