From patchwork Fri May 20 20:51:30 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mike Marshall X-Patchwork-Id: 9130053 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id CC7006048B for ; Fri, 20 May 2016 20:51:33 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BF0F127D00 for ; Fri, 20 May 2016 20:51:33 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B233D27E3D; Fri, 20 May 2016 20:51:33 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1FA4C27D00 for ; Fri, 20 May 2016 20:51:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751191AbcETUvb (ORCPT ); Fri, 20 May 2016 16:51:31 -0400 Received: from mail-oi0-f41.google.com ([209.85.218.41]:36635 "EHLO mail-oi0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751172AbcETUvb (ORCPT ); Fri, 20 May 2016 16:51:31 -0400 Received: by mail-oi0-f41.google.com with SMTP id x201so197826709oif.3 for ; Fri, 20 May 2016 13:51:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=omnibond-com.20150623.gappssmtp.com; s=20150623; h=mime-version:date:message-id:subject:from:to; bh=AqiaQVgPx2WR3Zn+d6o9ZMjdsZseEu51d7zEDqguL80=; b=lYRr2ZS7tU/CA+6SorQM5U9R/Gdl+1PO4qc+LYw+BWJ79+8C7YzfxJCp5FHgvmwaSz SIUjZl5y3CbzRQGOPMcRzh2E1DBkzAOHr1/rc+sxeHdVKnB7Dyx608T9WB+BEHN4VnIy GfKHK5da+PH8lBk8XujLxGp45qv4BR6mCF2EH83QM+jrnJD3xWG7V0dSYAXuCZ0qZ7mf jWoZA9K8QFKNfkfvBGIxm5VL8ie+mC12xmSTUOk6SKw4gQ7UckeZnv1XQolZ4j5ZCz6Z GE68FdeA+7Ztn7XnqvUOaU0pPnHgr2wgj3NUFamXfttGmLI+CjWB/ztvZICBjglzDCnS M4vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:date:message-id:subject:from:to; bh=AqiaQVgPx2WR3Zn+d6o9ZMjdsZseEu51d7zEDqguL80=; b=XgaUdpLk70Ts2zFMMSosUd7Ym6aYc8Tq8FaIjNIcu9ypMfC2uLL5zXEfJHNB73yr7w gNbTUR9Hq8qjRnmIZlNDV6kWG1WrDMAdUCwqmj0V09dCxCobgM400TeMY59XwlbKUUJh elI5tI9PQaRrnbfvbUl3T4gHDVT6tEL0H/+pc+uDQ0FulOAsskrUl6NTTxzwBH6xJxAC KVQy9aGkZef9LItz5DxKsYTmB1Lk8MGTQ0wxHR1hiF+zXmjEyQbjHRJEPXA8J6sj0tn+ rQqdPladUfsglCi7eNkqUGhcp1G50YhJV7TMs/b7A8AIvBbyEIk29oHb1yvBFaKWzLM4 BmAw== X-Gm-Message-State: AOPr4FVaZ8d+90Qf876L+71MTnxH3EMUfzWm///zrA3xtZTJeYNwPoLyTHJ2TjiXoCNFepv/1cWHr567Xqcmdw== MIME-Version: 1.0 X-Received: by 10.202.76.17 with SMTP id z17mr2876503oia.18.1463777490280; Fri, 20 May 2016 13:51:30 -0700 (PDT) Received: by 10.202.195.67 with HTTP; Fri, 20 May 2016 13:51:30 -0700 (PDT) Date: Fri, 20 May 2016 16:51:30 -0400 Message-ID: Subject: pwrite04 ltp bug? From: Mike Marshall To: linux-fsdevel , Mike Marshall Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi everyone... While fixing a couple of LTP regressions in the out-of-tree Orangefs kernel module, I think I found a problem with the pwrite04 test, here's what I think was meant: # git diff testcases/kernel/syscalls/pwrite/pwrite04.c Should I even be talking about this here, or should I go find the github maintainers of LTP and ask them about it? -Mike --- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/testcases/kernel/syscalls/pwrite/pwrite04.c b/testcases/kernel/syscalls/pwrite/pwrite04.c index b297682..4ca7dc1 100644 --- a/testcases/kernel/syscalls/pwrite/pwrite04.c +++ b/testcases/kernel/syscalls/pwrite/pwrite04.c @@ -196,9 +196,9 @@ int main(int ac, char *av[]) } if (statbuf.st_size != K5) { - tst_resm(TFAIL, "file size is %ld != K4", + tst_resm(TFAIL, "file size is %ld != K5", statbuf.st_size); - + cleanup(); } tst_resm(TPASS, "O_APPEND test passed.");