From patchwork Tue Feb 21 07:34:35 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Yuezhang.Mo@sony.com" X-Patchwork-Id: 13147439 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 677A5C61DA3 for ; Tue, 21 Feb 2023 07:34:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229545AbjBUHex (ORCPT ); Tue, 21 Feb 2023 02:34:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34638 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232650AbjBUHev (ORCPT ); Tue, 21 Feb 2023 02:34:51 -0500 Received: from mx08-001d1705.pphosted.com (mx08-001d1705.pphosted.com [185.183.30.70]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D09FF233E1 for ; Mon, 20 Feb 2023 23:34:50 -0800 (PST) Received: from pps.filterd (m0209320.ppops.net [127.0.0.1]) by mx08-001d1705.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 31L4uH2v019482; Tue, 21 Feb 2023 07:34:40 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sony.com; h=from : to : cc : subject : date : message-id : content-type : content-transfer-encoding : mime-version; s=S1; bh=5P/jDAqF3xaPT7piuideXCRyzLQddmdgCWbXY5mpjsg=; b=LGi6scSpI+I1QbtChDU9hbZ1MzIRwJLeNgeqvXjD4PyRYVxOujXa6mddGp28z5B9E8Rk vhTcDzHDNPgpt51NkprF/cUIYCheLMDeqaTP1XmU9q71TAcUAtSSA2Van/0uFQXpNy/F ShgSXWDRpYbviFIPNP+abzeBIgoESZVj46cWE9J/Q4k4JwWJAf69kalwT0a+stVQc7E1 leSiqztAIGyNNDSpJAlvk9Z4QDleKJAAuJAE20n7tB96zatNfw5HG94m10zvXfFeNPIp SfUzWJ5E7uxq4UPIslywkcmkzHi2PbQzSLCAMmFxzxH1y09ANDcGs3pEqFZQ2OI5+SE8 5w== Received: from apc01-tyz-obe.outbound.protection.outlook.com (mail-tyzapc01lp2048.outbound.protection.outlook.com [104.47.110.48]) by mx08-001d1705.pphosted.com (PPS) with ESMTPS id 3ntmjn2vem-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 21 Feb 2023 07:34:40 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kSIGYdYMYbArPUNhCaUkU8bBaYxBlfaVRc7+xds5rNGqh4tzb2OVBBqloFaknRqSJOFEulZTAgQc5Fyqr+9b1IEnu7K6K6sf1vMze+cSVFHsZZJJNxBXBzSfUf36sTmwYoXycU25RK25B6Q8ng49GSpWitFNOrS9mzzgysvMBqACfLGuL+hbqKt9GL9OpJOW9bDdLiiM1Ivpm2kXnF9ScRA2ducvY9DMQM8W4ARE2coy0cypW2w8JOnoPfxk/wS7zd1bUFFDrpgrkbVSUgdCMkbFKT/AJ60SYGnirMajHypJS5wd9fTNS31Lot2n57MhgL3kQN67mLX0sux6JK95WQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5P/jDAqF3xaPT7piuideXCRyzLQddmdgCWbXY5mpjsg=; b=WQrVCID0al65xPKosYllvy5fBJz31FbJRWyhCgZxFKH+jDciQ7pAWBha2hvN6TfF3wWo5TCtw+TePt/8BAiQQ3Sy5pRAvqlvCarS6wm6gny18P29DZKk9eQuPCivPeMkar6DWAyKAQYEAnactpvEfkDEA9OlXU7IooV36DfTiwe/DH7dysOllSonr02k2FCVr+yixvZdB8sgCQj2NT8uUDKqX6lYtm7wwnl9+amLGRvkKJ3c95pJFmwdIOaVIj4E/gj8yhN7ZdLzNSre2AbIfZppoLCdLltv8CM+Bc5GVqXJzS8RSEXdDePYYaOgJiN7fSZKis7B5nzctFZtr+gCZQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=sony.com; dmarc=pass action=none header.from=sony.com; dkim=pass header.d=sony.com; arc=none Received: from PUZPR04MB6316.apcprd04.prod.outlook.com (2603:1096:301:fc::7) by PSAPR04MB4165.apcprd04.prod.outlook.com (2603:1096:301:34::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.21; Tue, 21 Feb 2023 07:34:35 +0000 Received: from PUZPR04MB6316.apcprd04.prod.outlook.com ([fe80::779:3520:dde5:4941]) by PUZPR04MB6316.apcprd04.prod.outlook.com ([fe80::779:3520:dde5:4941%7]) with mapi id 15.20.6111.020; Tue, 21 Feb 2023 07:34:35 +0000 From: "Yuezhang.Mo@sony.com" To: "linkinjeon@kernel.org" , "sj1557.seo@samsung.com" CC: "linux-fsdevel@vger.kernel.org" , "Andy.Wu@sony.com" , "Wataru.Aoyama@sony.com" Subject: [PATCH 1/3] exfat: remove unneeded code from exfat_alloc_cluster() Thread-Topic: [PATCH 1/3] exfat: remove unneeded code from exfat_alloc_cluster() Thread-Index: AdlFxb0R0myNhmzvSuqdhLs/CmEyKw== Date: Tue, 21 Feb 2023 07:34:35 +0000 Message-ID: Accept-Language: zh-CN, en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PUZPR04MB6316:EE_|PSAPR04MB4165:EE_ x-ms-office365-filtering-correlation-id: 0023a39a-d1e4-426b-5bcf-08db13de14a8 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: EZhrU+sKQC0R49I6SrzvMugICUcCfiApBZhDQzfBtb/7SahQcwhbpPTPKf/IxaGwGpIdywpGoYiNQlUR3CA6AA58wv1/JI4NC++otGj/e5E+q3Dd43DBH5vfYa06kodIKdVmOfw+RXu+Ne8wy2vA/n2y8tmUv+9S1LoZJo9get80cN3bSAZ4ZfwMEdXu7fSswy/a69hcmRD0lUFMMeCVPDSD0AtYH/w85JFu6LfkxP6j6dtURsJCnvIZLZYzmptkZngV1RxiEGvtAtwHzGkg7sWSDKWsSpu/RtSC7jLgQ4SetdgIlMK4rB4fMbeS3mR9Tfd07fZtUuw8kXoQ/PvzGh3WQTNnd96INM1ewEkmKmgKskzo8YX3U9GKCeHrqmDPz9HB0QxeT7nOwBoYfPa41UlM2DmoIayh2oAcnDLwDT2s6I0pbouNV2bjPjIBJU6yY6jfUnWEgdFdeJKMvnCZXebxhnlqouhpe6VLjY2ptbMtnFYmNl8qUaRdmOMbD7+Kl0q7LU4yGfbLfDZRlrGc5NMaTgs6v57MOL51WzNu3HEze6xNm5KV0pHrCTQsevFiJUr+LgbVzaNdp3qkmH4gVz575jErCt9UMKRnDjEi/8BZaqAIJaZQmCIfAyUqr1Ontz9P0IQlkHG8Khj667vYYEYm3xoKa0PfMNX3E19IyAlw6M7XtK+EGm3XWDhrtWZu x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PUZPR04MB6316.apcprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(136003)(376002)(366004)(39860400002)(396003)(346002)(451199018)(82960400001)(122000001)(38100700002)(4744005)(83380400001)(86362001)(316002)(54906003)(8936002)(5660300002)(64756008)(66476007)(8676002)(4326008)(110136005)(55016003)(41300700001)(478600001)(38070700005)(107886003)(33656002)(7696005)(76116006)(66946007)(2906002)(71200400001)(66556008)(66446008)(52536014)(9686003)(186003)(6506007)(26005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?q?yqZvtlEVB6oykvu8D3wdYtEGWiZq?= =?utf-8?q?YtfDEjsFM7hORh0Ow3PIdrKBh3YLmWH9S4cQ4PS+Ma7NuSYBvE4tqWMzFUbQ98x2K?= =?utf-8?q?lpTNElkUQwoi2BTxpwtUupDlfiIcaOMpkqFXPlidb1MVXvFbj7MQU6z5VJylP8QHE?= =?utf-8?q?fCboUMDDp3OfTnzT0dIgbsUaELSRN+53q+4M4ppuO/AjvJHALOtcYFiUaNYlTuEjm?= =?utf-8?q?0KEz7gxM8uJqAtnefJclX26f6JnuMtEgZFSweFnEmn3pPS/6E3dJAewZw1Hwy7W8T?= =?utf-8?q?KVcYB/VMdLBJ37nGTOntYl9gBROgimH6xWqBhupF7VZ0XenrsIyDKpsnnsjT7Suuv?= =?utf-8?q?/xoqDbhTMC5swQd5ZS8jK1+CQAVLY2KYxI6rVCSRd7NqNQytFipAScLuZMMif/0tt?= =?utf-8?q?liO19rZLORNafTKFCPecfYpnMmHvj3u5Cr+g8FxFleq+wZ5ntmtG0+bo+twtIFaC5?= =?utf-8?q?Sby6+hYT/IHrxByRx8XUSBeDmBCEh/c83Ohe3wfSImx/urexozlBhkq2iAY9PjyY6?= =?utf-8?q?Ez/E1rsccGKh+B74HkHboFBam4rNfeJZ6uBpxdzmVMzxdScT8Zd3B/O7IGHOFMhcT?= =?utf-8?q?4xAXHtQTIaMAU1UsUP1Ulwh5SwaDyhZC1A9bXTg/WofnB6pcnk5AbPfF6BKf2ObU0?= =?utf-8?q?BlarNvRmVDdfqvj2Gz6jbvmK3QfvXJKqPvuAu/O+XRiYGNJyxJ78DzJIfOclh3uZD?= =?utf-8?q?CJoGsgfKtgt6IPGblZS5Wp7lFcLoBlpxsH/88SDdbKrUk6bkwQIO09AuXo5l/59bQ?= =?utf-8?q?lT72q+TF16+HhflRQY3aifTeoFs7GXYGwUVm79vg1BRBK32/JwedK5nmimenCwSja?= =?utf-8?q?V3Oq0VStn9kUShRqk708lLnxymU9aUIK8BSoCJDwIHgLXjiDupVg/+AMCXf7CVyT2?= =?utf-8?q?HYmQH+Tw/YzhpkCh+xSOqejGkRaY2enDTyhJ5BgXGsLupGimObEYEiFqcK0YPcmKe?= =?utf-8?q?c7RzgqPGehJGXwpoF115lwY83OxJOEFdyB66UBYXj69/opd2w5YMzCDt4PufX9q1B?= =?utf-8?q?NEiE+JwkLS1NpH8Bc7QqGWO4JVcN1d78yPWClD5bw1cDD0kVSesvI6znLBNMb6/56?= =?utf-8?q?rADA0RGxw2UDzGZGXGR1z3eQGweHWQ9ZYSOq32PAjFg3/lYC4YJTEF/l2amVHgZ/1?= =?utf-8?q?0iOK8LGWVFrZV2+Q5Vx0VfqK+/Ox9nswasOkVudQh6PmNg3RaP/H8imZ543vfh7jS?= =?utf-8?q?JrONFTNEmz1kGliY1G0DVYfqSAakQmeLAcCu9T8mcWDGJ/a3flhN7F3e617Mj6c7s?= =?utf-8?q?/xQ8IkmJvGKb7V9IHOAwCSSJfdGChERm9lJBXGmyy0Ia7yKHbiyoldmTjbe7RK63A?= =?utf-8?q?1rl7z07waENjA+iDOBtbMw+61URlAwFCVPVdXrp+P6ag/mmUMAR7/FzqgpnIe9GVJ?= =?utf-8?q?+aIEAfsxJCr+HHpHGpKtKIqxJiQNqi1UTiHkkznkhjPIR6DKNrBemlPRmhAlsrRoV?= =?utf-8?q?bBsHamdr5z73Q8n70AaIKNO5eJ2SNJ1MBbx2tRh6GZQX8NwYOya3O/JHLOVNx92w+?= =?utf-8?q?1ybsmqymZit2?= MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: K54O1Ry84Yz3y1OdoHI7Uaw3j8dD/TlZTg9RmChmmhRgZYmssPNxxaMcFdWIJgFlIZ9eaYhGtgHiHwBIrlidWYiLYwnJB14zxAwAWYQ3sROaM6LSVeN17QtDpn67NGathnZxyJ0UwQf7uJEa9tJqLOypyyBbe3Kp4ALAErr1bxshb64o7pwUy9iThHJ8Y1sGQSITKAoB4W/nUmg5epD1ALXPa2XCqm4oJ3HbsA9QcvKG70JDYVyr5l1JJ6wPzOVXKO6t4p2IQNyZRg887+ghEZTNv1C5nRFHqQVoND9AQeZzaqh5pU5vVpUG4nZO0yIWP1fSNmGw9Ei4u4YbdG7fqPG95y72FgxmWbK2N48+aezpdNckCr161kQp8AGI6sh1pX3DTm66XG1ZyMnFSMwRcmkSxD2U06GcSY8ryrdIAeMB3tLNmTbZ1v5pNnFTW8Pohn7q7GhZ4US6mv+YXtBaCsW/v3tJAeWor2zuwJ2ANuHXsk5BzJa7MiUpkF4l5a67wNh9b4pZ5WJQMe/bvO8Ps3dTx3RMf3/nyZXAI8l1Vxt6SgzZORLkRPoi7soEHmCxSAcZfDmlxGVzjBYTJEcdkJHyS9fYa74HkwJBOgdToEtE9XzxPaNTU+b32i/Fr52/zDHgY8hilHN97Ve9REuDK6GvUGZ+1L+j7UUXhrLARwbbq4et6lI8ao9cUBqILRqXYmbI/r2jU2spyDicx0U6g8+Xn6NuwP59BbB9x8kmDFthlzM4nCXxrtW4t3q27xgI9qJRGRhdpVkVxsQArNWOEMfj+SOYoBNSPkUwOOhTmh9AY5EpzuSTsiv2If8pkmzQIlobIjMqsiFTo/FZo6bdfQ== X-OriginatorOrg: sony.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PUZPR04MB6316.apcprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0023a39a-d1e4-426b-5bcf-08db13de14a8 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Feb 2023 07:34:35.2990 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 66c65d8a-9158-4521-a2d8-664963db48e4 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 1R2FEY/D94yYROxk4vsyfNXSgLH0jGS5THhuoJpYoUuXbNLY4u6OVw9WkFkYHl3Ufo32gN4Ru3H7d74gbnhvvA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PSAPR04MB4165 X-Proofpoint-GUID: xguHjfrFbEDHgT5h3eD0LAofx2tonPva X-Proofpoint-ORIG-GUID: xguHjfrFbEDHgT5h3eD0LAofx2tonPva X-Sony-Outbound-GUID: xguHjfrFbEDHgT5h3eD0LAofx2tonPva X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.170.22 definitions=2023-02-21_04,2023-02-20_02,2023-02-09_01 Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org In the removed code, num_clusters is 0, nothing is done in exfat_chain_cont_cluster(), so it is unneeded, remove it. Signed-off-by: Yuezhang Mo Reviewed-by: Andy Wu --- fs/exfat/fatent.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/fs/exfat/fatent.c b/fs/exfat/fatent.c index 41ae4cce1f42..65a8c9fb072c 100644 --- a/fs/exfat/fatent.c +++ b/fs/exfat/fatent.c @@ -347,14 +347,7 @@ int exfat_alloc_cluster(struct inode *inode, unsigned int num_alloc, exfat_err(sb, "hint_cluster is invalid (%u)", hint_clu); hint_clu = EXFAT_FIRST_CLUSTER; - if (p_chain->flags == ALLOC_NO_FAT_CHAIN) { - if (exfat_chain_cont_cluster(sb, p_chain->dir, - num_clusters)) { - ret = -EIO; - goto unlock; - } - p_chain->flags = ALLOC_FAT_CHAIN; - } + p_chain->flags = ALLOC_FAT_CHAIN; } p_chain->dir = EXFAT_EOF_CLUSTER;