From patchwork Mon Mar 11 04:25:22 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Yuezhang.Mo@sony.com" X-Patchwork-Id: 13588286 Received: from mx07-001d1705.pphosted.com (mx07-001d1705.pphosted.com [185.132.183.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4BF5817BA1 for ; Mon, 11 Mar 2024 04:25:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=185.132.183.11 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710131142; cv=fail; b=AaY4luvCUlVzqLJfAdcwMizPtahvjSGXZBzN0llV6IKdgyHxLmDSVUsSLqfu04QLFIQVybeGVXzMR2QQsbdWYHbCbDb9qV6KaIvCfULZOSBAOqZ9vcSkZTqyVV2DRHae0Jgov8Vk4cq/fLAZ62PftqVh3EwYU97tLvbj4LdTTh0= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710131142; c=relaxed/simple; bh=wjmzE3N8ZLCReZ+zcGvb7uzyCcTV2KO5e7dqaEhiDp0=; h=From:To:CC:Subject:Date:Message-ID:MIME-Version:Content-Type; b=eWh8g9ZzRGoIIk33n41Nw6np1wp9OsJuXhjJbLw6AYX40BWPr1YzHP0DwCsrPNvMsPBNDn3Bxu6UUfroQHh42pv9PT4jrGyP5V8Kh/DJ5TdKwF1bohlReJ6ARTl4NEPH4js2kerjWw/5HSypOG0SY398krebVYHyxlTjdKCtJDw= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sony.com; spf=pass smtp.mailfrom=sony.com; dkim=pass (2048-bit key) header.d=sony.com header.i=@sony.com header.b=J4BqeUmf; arc=fail smtp.client-ip=185.132.183.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sony.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sony.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sony.com header.i=@sony.com header.b="J4BqeUmf" Received: from pps.filterd (m0209324.ppops.net [127.0.0.1]) by mx08-001d1705.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 42AMVSlA006255; Mon, 11 Mar 2024 04:25:31 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sony.com; h=from : to : cc : subject : date : message-id : mime-version : content-type : content-transfer-encoding; s=S1; bh=wjmzE3N8ZLCReZ+zcGvb7uzyCcTV2KO5e7dqaEhiDp0=; b=J4BqeUmf07wPdnhbYw7/WBXmSzT5N2y5vIK1PnX84fr6WlZ2p+Y2KeECTpskHWrkHh7d nnGBEDKp5IIHQFVMMM7TgGfoIQ79cz8llKb/lJRlhMmAdkxIa+Nj919SsZEV1BwIAjTH lLLQ/UQAlsqJgaaM+5oljXT2evrbKT/SR7tuPC5EOKhCl0PPHe0ur5Fb2mKqBDxWS3oQ 3J3drLZLzvGmw7Ir/ZM0JdfKR3Llx/5H3nmL7x5fRCqVQnr0JYwLcRuVhpObeFDazoYd aoC7HIPROHgTdXOic4dHxfazJBu+yHebbHX+Iw6SN8NFolxrf5i1vKLtVw2RJ7ZlvfAt nQ== Received: from apc01-tyz-obe.outbound.protection.outlook.com (mail-tyzapc01lp2040.outbound.protection.outlook.com [104.47.110.40]) by mx08-001d1705.pphosted.com (PPS) with ESMTPS id 3wrcx79nbr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 11 Mar 2024 04:25:30 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=m5M72KdCETWGrdW2eDARsZ0XAahD1LphJyXQobpfPU7aib5JJBYe54M+ug4lkvof4mKScxrxGIHf4alu8bD7TIZH0kRdP/0RGA3hcRv6QCKAVYaui2dlph8p8flLHjvUg6A20UXLooB4z1j37dgrUDOqgegwf0lvab/9p4gpq0hP2Dab8lN1fMO1tjeVDvDtgfsB3jXtiEZ12QEki7HhjuFLUF+cmTWeH7/eaSQjfsIcgLsnw82sK/4M3Qu1aPZC06feSO+3nsfQEQrlSPoJLFdLqyJ7H1KT2Ni7YxubpDaU7WyeQGK8vgA6UGcmid2xtdIgRr14KnltQDkLHKvU0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wjmzE3N8ZLCReZ+zcGvb7uzyCcTV2KO5e7dqaEhiDp0=; b=m/tJuHntGofTsGXUwDAqsv/E4Bl+6hJRKxAeC8CFJ32IxfRKDYg7hsb0VdqGSHL/a/s/jI2KX2HEyIZTnjNmWKSxpn2hGdueA948mTQ7smYaFgyxhqGpnZfhxk0wnORb6LcN0VUyfTMyIqmVr8b/bUPXY+PBwWUyTLK0G85m9+01PPaTGz7mtKE4Udp7MNvVXVqcbIEg076NHsh6G18E8510lEQwC6bhqmFneolzjmduBkR9/PPHf1bcCCIe31TAJQ2cBchoxc8Hcewn8E0zioLfLAdg9+gr/LcQAT69AGigSE5wdLuMLBSZ8ZZdC4VqP6lkIStepBbGoeBya2K6rw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=sony.com; dmarc=pass action=none header.from=sony.com; dkim=pass header.d=sony.com; arc=none Received: from TY0PR04MB6328.apcprd04.prod.outlook.com (2603:1096:400:279::9) by TYZPR04MB8020.apcprd04.prod.outlook.com (2603:1096:405:b0::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.33; Mon, 11 Mar 2024 04:25:23 +0000 Received: from TY0PR04MB6328.apcprd04.prod.outlook.com ([fe80::c5b0:d335:658e:20bd]) by TY0PR04MB6328.apcprd04.prod.outlook.com ([fe80::c5b0:d335:658e:20bd%7]) with mapi id 15.20.7362.031; Mon, 11 Mar 2024 04:25:23 +0000 From: "Yuezhang.Mo@sony.com" To: "linkinjeon@kernel.org" , "sj1557.seo@samsung.com" CC: "linux-fsdevel@vger.kernel.org" , "Andy.Wu@sony.com" , "Wataru.Aoyama@sony.com" Subject: [PATCH v3 08/10] exfat: remove unused functions Thread-Topic: [PATCH v3 08/10] exfat: remove unused functions Thread-Index: AdioqVU2cw34s+96S16hkmg3u1B6mHKwcanw Date: Mon, 11 Mar 2024 04:25:22 +0000 Message-ID: Accept-Language: zh-CN, en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: TY0PR04MB6328:EE_|TYZPR04MB8020:EE_ x-ms-office365-filtering-correlation-id: f0a367fb-c2c8-4f7a-210f-08dc418344c5 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: v3DIurtWohdRlpOfHzrVDFMlqwOUq9Naut8Hs4LfuI8IA3cqaVMnWI9SHkqHk7jQcXymJ7NsMOC2BwTKh6L+MlRy/PV+7OycyBnPAQazlRKb+5XSjoGnMRHbty7pMNfVKpFZ2puA1jOOfgkec5RtZxe0PBWWxXPr8zQGZVwzjE0JMfYz4o8ycQoj7BsOh2v5q55XftjVf9xA0yGG7snZnxrDS+FitIhxcgeqQyvqMnvksElgPTEM2irDAYdFrkdo7J11P5FCmpqLjhZSYOaA210xD/uVGVmBObkIdk+izFDZ/1zgzLMC2vguL0lOK286b6rOVupeg1lLDUAISdaBrM+f+01AzxcbBdPWxY5gxTvvwZ6795dWX5G+ZBksSsQPygdQEWRfYxqbAKFpVLdwEGf5P3gvCmfiknOm+8w/eS6ah3qSHGagENXTOcdMW4YrAsoifTB+FzwqYG0ywckboyy5qNpYV8aL89vT/qlqRN+Uk7bwgfhCvT8PbzeFSqmesbr0TLs/1OKcLNwdu3u/DPBjSFi5nDJdCPMxvWF4uEezO2QaJ3A2SG/RuCSSXtiF4JVkumhd3ZaUwPgvNrgKqF45wLCFM4kFjkC6NqMC9Dgv8cr3s0+mHbiQv6MwxhdFebKDFfxVoMUT/Bl6PPB1/i6KlI7Ps3xIWtiwNEBXxhICacoFmJSFcEEMSKJj4s6aSr5eir1JDC0+I0dfwwqWHLo/+19W/O6G0CcvuAep3NY= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:zh-cn;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TY0PR04MB6328.apcprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376005)(1800799015)(38070700009);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?q?tHnloxq4UPsHFoHq57g59VbAo1QJ?= =?utf-8?q?3eGhKY0g10nEGN2UEzF1PC54RLamCW/J5IAbds4vL7AXQ0jh0/Zf7O0f9aPjfa7nx?= =?utf-8?q?P4Gz7ewe1CQkaKRqKnBKl5BzbsKh3s/zoCK+PbsgnGjjse6/pXyTor5+/Uhq+SyIq?= =?utf-8?q?29x5DOAYs7cqp26fMlueXh3GjO59cIs1+UNMXmEwiZ6NNrpyhvkhwiQ6E+5mZFoUz?= =?utf-8?q?EaRb4tQrfwuqIGmpmCrXVp83u0hN4kvNzDoorzqRGVmUKILy87E50EHTXKlAfi5PX?= =?utf-8?q?OxX6enHLgWeZd8MCb0H5oRTjNxnMplgL1Sd00wdI1EkgBaa2XOsez2VhJh04spBXG?= =?utf-8?q?pEFeyCqaZPbhON/gx3Sz1QRycLc1Ty0MYG8UFeV1XP0Fxm7imXI5BUSJzy/78gvxv?= =?utf-8?q?Z+iJCp7vK1LAsvyuGCnwJb4uc55SbHZYn4bJNhRrzG8hyq2QxiahuZxmgAtMBhIRz?= =?utf-8?q?Rig9pa9InYbX3Nk/7MiG3FvFgc4gCNr2c100sj9w0GmIR5WX8iAdLqQYOo4E/uB8r?= =?utf-8?q?77YpiTzACTQ1sZ9VXFvv+hlH1Ryvm+0JMNykq6o0Scnmxgzn/N5mAA/V/YS4pdP3j?= =?utf-8?q?h6WwPwTQWsxAVvvSXEHOoLWANXx6i9nTgHa/f8ktnF485AuMnDXctezzfpHeW+Bo5?= =?utf-8?q?YVFyHX/2xmtdL5v7ge2znkCpadVx2Q1SZ+lETzGja/usOPhvR1MpRE0bt7ImZQLtk?= =?utf-8?q?E286Ikk9He/yqT+BlJePhyHYlbZrWONJSY7VhBrwljifZxlTJHunJkj7Hu44Jp8Ba?= =?utf-8?q?TVOo6ZkdaEzNXLPQ+Se6sGPcC3Yemr7InZKSHaSikfkRmGPgIMPaMOwKqhw3AhqmX?= =?utf-8?q?X/4A56rHVo6zPIN2ZlUle8rTYNUXjKA2oJ1cnTfXTpSHwfOUiKiRPjsgTFroPyE/u?= =?utf-8?q?8swsye7ce7e0wHDwTVdomAXO8voQV2Rxhrfqt8N3XhmAsI+ebHHE6tiS0ZB2jMUZj?= =?utf-8?q?VZuCOtDjLVMt504sD9w9LANt4ZkZ+7FegrL4sddEielg4uCRWAZw9YvVlq1T9WjNw?= =?utf-8?q?WWIK4qBjJb3A5/w5FD4YwPrTAFMydiFUmc3Jw4W4rEK8jq53Iwl06ax2oKM4z3Il/?= =?utf-8?q?SvdnLzDW8Y0n/pMDJDVGsXJUa2wwKfyK1o55Rn9jQPKUlL0B03LAjmv30UG5U1b/I?= =?utf-8?q?hbO6XcreqZ+92wdJKBYnvLpWy86yw0VcphN2IE8sSOHQYnyTjnL+ZnIyPXwpTl3gk?= =?utf-8?q?sfJD7HpW7UQ+XYat1CTDB715U1XqHZB9EhfVzMiYc6NuRPNCdVt71KaUoFB0SfI80?= =?utf-8?q?3NUvysVMpVHWvkDxPP7utLL02mltZST8ZMYXhoxlMxBsfAyLVWDnRbZ2/PSjFTV/y?= =?utf-8?q?KLL70w0O9b+CthRLSCxJvSQdUYUFFKbV/i6e20p0TEqYW1V4kecCCSp5Z+5PG9Ys+?= =?utf-8?q?/7x+5CPwaTzBHcX48Ni/1w32XaL54+Wohn3lfFS2chnvq1PuHtkkdo8qjTwlGKBBE?= =?utf-8?q?qCVPCEcoGovwW8r9J0fplyGEWKW3kQ1WnrjiXvl2x0EiB06oKr0QH1Ao3I+fZxml9?= =?utf-8?q?qjGAXn/Fh+kO?= Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: YN7QFVsDanMnm+8GrtRZ6g9ItMtLcla+NQXlRfEzgJ4ZcS7GD7uMXpwF4F0GOYHJB51SFRyq+p8cSlr2cmyBRyIviNvZ5Ue2o6ueDpWw1SdSz9NK5nZL7BBrx8uvAgyW5x+GAcT3Lups6HsR/blN/m2IksmBKxxpSFBGd2EyMkpRH47Mk4yku74/hKBEhm9+l9KFLYimU5ALYU1n/7RTMprC0cM5bpQggfzkRBxegHqTjrJjIOXC1R+n1zXLqaO+4p1jUZ2+59kYv7GxljekVuOoDJ9BLnMR8pxcdQhtbtLFuQGbRm1wRLfJBb8H7NGDt3PXDjKD/Za9tLJo2eXt5UTK2J9FGn7eWoUM31hss2qNEeDh+Gw57Lgg3kUhdZ5tbAtW/SIAsb1Si821FPvl4+6fYCH1Dt1ZjewF9mLWUuCG1w63loXm4TOMHtT0XBtOIrjQdhem1IQ9cKGE39Z4jNqjCxicvidbiu2BvnqA4rz2Shcgvmr9XW5oYAm0q2FSsIOjQRZNT2U/Sj+8u9JkbCtSgzT8MO/RU5aYl+9y/LWK6Dk34V2DmwxcRBVNb8r8dJGT2/+YErrRDklN18JATp8LYANIi/40noRt+ADzX8q9Xu4LndxWRXBLS4lr3vZF X-OriginatorOrg: sony.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TY0PR04MB6328.apcprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f0a367fb-c2c8-4f7a-210f-08dc418344c5 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Mar 2024 04:25:22.9845 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 66c65d8a-9158-4521-a2d8-664963db48e4 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: qIzz7Qer4ZcimMnlsYfmRrVQRsNMr/RSKToecVLWb/QVzv9SnQUPpKstaGwcpjLvtjSXiVcfo1DOTSiJTDuOOg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR04MB8020 X-Proofpoint-GUID: L5NOUtah5FfwEZ_65ClgOwh8N2NyXBur X-Proofpoint-ORIG-GUID: L5NOUtah5FfwEZ_65ClgOwh8N2NyXBur X-Sony-Outbound-GUID: L5NOUtah5FfwEZ_65ClgOwh8N2NyXBur X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-03-11_01,2024-03-06_01,2023-05-22_02 exfat_count_ext_entries() is no longer called, remove it. exfat_update_dir_chksum() is no longer called, remove it and rename exfat_update_dir_chksum_with_entry_set() to it. Signed-off-by: Yuezhang Mo Reviewed-by: Andy Wu Reviewed-by: Aoyama Wataru --- fs/exfat/dir.c | 60 ++------------------------------------------- fs/exfat/exfat_fs.h | 6 +---- fs/exfat/inode.c | 2 +- 3 files changed, 4 insertions(+), 64 deletions(-) diff --git a/fs/exfat/dir.c b/fs/exfat/dir.c index d43dc5f0d375..49fe6b71e957 100644 --- a/fs/exfat/dir.c +++ b/fs/exfat/dir.c @@ -478,41 +478,6 @@ void exfat_init_dir_entry(struct exfat_entry_set_cache *es, exfat_init_stream_entry(ep, start_clu, size); } -int exfat_update_dir_chksum(struct inode *inode, struct exfat_chain *p_dir, - int entry) -{ - struct super_block *sb = inode->i_sb; - int ret = 0; - int i, num_entries; - u16 chksum; - struct exfat_dentry *ep, *fep; - struct buffer_head *fbh, *bh; - - fep = exfat_get_dentry(sb, p_dir, entry, &fbh); - if (!fep) - return -EIO; - - num_entries = fep->dentry.file.num_ext + 1; - chksum = exfat_calc_chksum16(fep, DENTRY_SIZE, 0, CS_DIR_ENTRY); - - for (i = 1; i < num_entries; i++) { - ep = exfat_get_dentry(sb, p_dir, entry + i, &bh); - if (!ep) { - ret = -EIO; - goto release_fbh; - } - chksum = exfat_calc_chksum16(ep, DENTRY_SIZE, chksum, - CS_DEFAULT); - brelse(bh); - } - - fep->dentry.file.checksum = cpu_to_le16(chksum); - exfat_update_bh(fbh, IS_DIRSYNC(inode)); -release_fbh: - brelse(fbh); - return ret; -} - static void exfat_free_benign_secondary_clusters(struct inode *inode, struct exfat_dentry *ep) { @@ -552,7 +517,7 @@ void exfat_init_ext_entry(struct exfat_entry_set_cache *es, int num_entries, uniname += EXFAT_FILE_NAME_LEN; } - exfat_update_dir_chksum_with_entry_set(es); + exfat_update_dir_chksum(es); } void exfat_remove_entries(struct inode *inode, struct exfat_entry_set_cache *es, @@ -574,7 +539,7 @@ void exfat_remove_entries(struct inode *inode, struct exfat_entry_set_cache *es, es->modified = true; } -void exfat_update_dir_chksum_with_entry_set(struct exfat_entry_set_cache *es) +void exfat_update_dir_chksum(struct exfat_entry_set_cache *es) { int chksum_type = CS_DIR_ENTRY, i; unsigned short chksum = 0; @@ -1239,27 +1204,6 @@ int exfat_find_dir_entry(struct super_block *sb, struct exfat_inode_info *ei, return dentry - num_ext; } -int exfat_count_ext_entries(struct super_block *sb, struct exfat_chain *p_dir, - int entry, struct exfat_dentry *ep) -{ - int i, count = 0; - unsigned int type; - struct exfat_dentry *ext_ep; - struct buffer_head *bh; - - for (i = 0, entry++; i < ep->dentry.file.num_ext; i++, entry++) { - ext_ep = exfat_get_dentry(sb, p_dir, entry, &bh); - if (!ext_ep) - return -EIO; - - type = exfat_get_entry_type(ext_ep); - brelse(bh); - if (type & TYPE_CRITICAL_SEC || type & TYPE_BENIGN_SEC) - count++; - } - return count; -} - int exfat_count_dir_entries(struct super_block *sb, struct exfat_chain *p_dir) { int i, count = 0; diff --git a/fs/exfat/exfat_fs.h b/fs/exfat/exfat_fs.h index b43430aac69b..0dec910177e1 100644 --- a/fs/exfat/exfat_fs.h +++ b/fs/exfat/exfat_fs.h @@ -430,8 +430,6 @@ int exfat_ent_get(struct super_block *sb, unsigned int loc, unsigned int *content); int exfat_ent_set(struct super_block *sb, unsigned int loc, unsigned int content); -int exfat_count_ext_entries(struct super_block *sb, struct exfat_chain *p_dir, - int entry, struct exfat_dentry *p_entry); int exfat_chain_cont_cluster(struct super_block *sb, unsigned int chain, unsigned int len); int exfat_zeroed_cluster(struct inode *dir, unsigned int clu); @@ -486,9 +484,7 @@ void exfat_init_ext_entry(struct exfat_entry_set_cache *es, int num_entries, struct exfat_uni_name *p_uniname); void exfat_remove_entries(struct inode *inode, struct exfat_entry_set_cache *es, int order); -int exfat_update_dir_chksum(struct inode *inode, struct exfat_chain *p_dir, - int entry); -void exfat_update_dir_chksum_with_entry_set(struct exfat_entry_set_cache *es); +void exfat_update_dir_chksum(struct exfat_entry_set_cache *es); int exfat_calc_num_entries(struct exfat_uni_name *p_uniname); int exfat_find_dir_entry(struct super_block *sb, struct exfat_inode_info *ei, struct exfat_chain *p_dir, struct exfat_uni_name *p_uniname, diff --git a/fs/exfat/inode.c b/fs/exfat/inode.c index 0687f952956c..dd894e558c91 100644 --- a/fs/exfat/inode.c +++ b/fs/exfat/inode.c @@ -94,7 +94,7 @@ int __exfat_write_inode(struct inode *inode, int sync) ep2->dentry.stream.start_clu = EXFAT_FREE_CLUSTER; } - exfat_update_dir_chksum_with_entry_set(&es); + exfat_update_dir_chksum(&es); return exfat_put_dentry_set(&es, sync); }