From patchwork Tue Dec 8 15:22:56 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Geliang Tang X-Patchwork-Id: 7798801 Return-Path: X-Original-To: patchwork-linux-fsdevel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 700A39F387 for ; Tue, 8 Dec 2015 15:25:27 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id AA49D204D2 for ; Tue, 8 Dec 2015 15:25:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DA5C32047C for ; Tue, 8 Dec 2015 15:25:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933096AbbLHPZF (ORCPT ); Tue, 8 Dec 2015 10:25:05 -0500 Received: from m50-135.163.com ([123.125.50.135]:54225 "EHLO m50-135.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932665AbbLHPZC (ORCPT ); Tue, 8 Dec 2015 10:25:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id; bh=EPoMX+UQwddLzo4aj3 OMsrT5M//tzeaM5QJ3wLGY91Y=; b=RC9J9eKcHkrA+mUjPF9sBzOesMItLmoXMr MugscaDk7Q3GNr1qkpSfkW0k2m5vxsb2c49UFUy5bjI1qz/G55+aGNbfrbT8J+le 5XMyFWTUNfTGk2rxTPDazdKklCsV37xWERZahklWzkPgejxtYpY1trxNtUGvYy3W WLT/Btryo= Received: from localhost (unknown [116.77.139.106]) by smtp5 (Coremail) with SMTP id D9GowACnTqvS9WZWFTUMAA--.5651S3; Tue, 08 Dec 2015 23:22:59 +0800 (CST) From: Geliang Tang To: Andrew Morton , Rasmus Villemoes , Vyacheslav Dubeyko Cc: Geliang Tang , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] hfs: use list_for_each_entry in hfs_cat_delete Date: Tue, 8 Dec 2015 23:22:56 +0800 Message-Id: X-Mailer: git-send-email 2.5.0 X-CM-TRANSID: D9GowACnTqvS9WZWFTUMAA--.5651S3 X-Coremail-Antispam: 1Uf129KBjvdXoW7GF48KFWxZw47JFWftr13Jwb_yoWDZrg_ur WIkF97Gr45tF4Skry5KwnagF98Xw4UJFn5Crs2yF93JF9xGwn5Zayqv393ZrZ5Ww4ft3Wr W34DJryrGF10gjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IUjco2UUUUUU== X-Originating-IP: [116.77.139.106] X-CM-SenderInfo: 5jhoxtpqjwt0rj6rljoofrz/1tbiGRTKmVXlPw-lWwAAsg Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, FREEMAIL_FROM,RCVD_IN_DNSWL_HI,T_DKIM_INVALID,T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Use list_for_each_entry() instead of list_for_each() to simplify the code. Signed-off-by: Geliang Tang Reviewed-by: Vyacheslav Dubeyko --- fs/hfs/catalog.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/fs/hfs/catalog.c b/fs/hfs/catalog.c index db458ee..1eb5d41 100644 --- a/fs/hfs/catalog.c +++ b/fs/hfs/catalog.c @@ -214,7 +214,7 @@ int hfs_cat_delete(u32 cnid, struct inode *dir, struct qstr *str) { struct super_block *sb; struct hfs_find_data fd; - struct list_head *pos; + struct hfs_readdir_data *rd; int res, type; hfs_dbg(CAT_MOD, "delete_cat: %s,%u\n", str ? str->name : NULL, cnid); @@ -240,9 +240,7 @@ int hfs_cat_delete(u32 cnid, struct inode *dir, struct qstr *str) } } - list_for_each(pos, &HFS_I(dir)->open_dir_list) { - struct hfs_readdir_data *rd = - list_entry(pos, struct hfs_readdir_data, list); + list_for_each_entry(rd, &HFS_I(dir)->open_dir_list, list) { if (fd.tree->keycmp(fd.search_key, (void *)&rd->key) < 0) rd->file->f_pos--; }