From patchwork Mon May 21 00:43:25 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Kent X-Patchwork-Id: 10413761 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 32D5C600CC for ; Mon, 21 May 2018 00:43:51 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2635E2874B for ; Mon, 21 May 2018 00:43:51 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 168AC28709; Mon, 21 May 2018 00:43:51 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 939A328709 for ; Mon, 21 May 2018 00:43:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751434AbeEUAnf (ORCPT ); Sun, 20 May 2018 20:43:35 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:56019 "EHLO out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751021AbeEUAnd (ORCPT ); Sun, 20 May 2018 20:43:33 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 5E6D22238B; Sun, 20 May 2018 20:43:32 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Sun, 20 May 2018 20:43:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=themaw.net; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm3; bh=Lr/RTrCMzUY+kXV4EHPW+/b6SPzew PHwsrMOjceWYew=; b=B8y3vC5/97JLfvcXqzdftH6FtnpSaaiRPc1pzCJYE5XBt OCMLS+ahqSGwUloUHRAIikNaVWnLdpOaAHqnzUYptHVU9ih7+a3KsHAvJBhh5jt5 cn3rBpwbCI92RSBxslZR0mcsJKe98QgzLP8C5mn74KuBVD3FBtTU4cX+Kyjzrl6H IyvAP/1Lr44J64q9PCZfx2kQCSDL5ovvmlNR0NV2F+WmcgubrpgyVVzEEGAbLi/N 6lnjIuzULVwCegLarMAjZFlmqTnq2U1H3BaP0WrFVPRRHTt2/y41nMr8OPvErkxw ZBQtI5pmTtX31XHAhgstc0ibGp9xAqjQNK35CDM7g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=Lr/RTr CMzUY+kXV4EHPW+/b6SPzewPHwsrMOjceWYew=; b=QPJaREB8w4XFSRIL8MbOuX m0jbQDfkid7FhB1vrkglNFth3apGNYP+/xtafr30Um7Foh61JD6o9wQFizXZlszR e+0bnXb8LbYsxEBYcCSJUo0nwzetB39Ua8gY7wbTIZXnix6CRRVrrJ6CoFTydyMZ oCPohzPrE3Esyv+QxPKqOQ3r79KETiHUnGc9e41bLdCERoPnFX/Uo2CtQetkX0/7 ZV5ptG461Ra9cWVC+jXPdBPmmxk9hGcj0WOLVjU3cN4es5bnbs5krRRuonJkRXvV vzjLbkeiJqcDWSTzM5CRB9IgsF7c0iAU+YvH31AqjZ2rTHQy+px1MgzYwyK1gH9Q == X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Sender: Received: from [192.168.1.28] (unknown [118.209.63.229]) by mail.messagingengine.com (Postfix) with ESMTPA id 5823D10262; Sun, 20 May 2018 20:43:28 -0400 (EDT) Subject: Re: mmotm 2018-05-17-16-26 uploaded (autofs) To: Randy Dunlap , akpm@linux-foundation.org, broonie@kernel.org, mhocko@suse.cz, sfr@canb.auug.org.au, linux-next@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, mm-commits@vger.kernel.org, Al Viro References: <20180517232639.sD6Cz%akpm@linux-foundation.org> <19926e1e-6dba-3b9f-fd97-d9eb88bfb7dd@infradead.org> <49acf718-da2e-73dc-a3bf-c41d7546576e@themaw.net> <9e3dfece-46a0-8ab2-2c7e-3edf956703a8@infradead.org> <6441e45b-6216-a20a-5b1d-6f5663d701dd@themaw.net> <80c2dcf5-b9a9-3d75-7f6f-d0e9c1a11fb9@themaw.net> <22ae3b7e-bfbd-6537-9656-9fd429255d69@infradead.org> From: Ian Kent Message-ID: Date: Mon, 21 May 2018 08:43:25 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <22ae3b7e-bfbd-6537-9656-9fd429255d69@infradead.org> Content-Language: en-US Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On 19/05/18 00:22, Randy Dunlap wrote: > On 05/17/2018 11:09 PM, Ian Kent wrote: >> On 18/05/18 12:38, Ian Kent wrote: >>> On 18/05/18 12:23, Randy Dunlap wrote: >>>> On 05/17/2018 08:50 PM, Ian Kent wrote: >>>>> On 18/05/18 08:21, Randy Dunlap wrote: >>>>>> On 05/17/2018 04:26 PM, akpm@linux-foundation.org wrote: >>>>>>> The mm-of-the-moment snapshot 2018-05-17-16-26 has been uploaded to >>>>>>> >>>>>>> http://www.ozlabs.org/~akpm/mmotm/ >>>>>>> >>>>>>> mmotm-readme.txt says >>>>>>> >>>>>>> README for mm-of-the-moment: >>>>>>> >>>>>>> http://www.ozlabs.org/~akpm/mmotm/ >>>>>>> >>>>>>> This is a snapshot of my -mm patch queue. Uploaded at random hopefully >>>>>>> more than once a week. >>>>>>> >>>>>>> You will need quilt to apply these patches to the latest Linus release (4.x >>>>>>> or 4.x-rcY). The series file is in broken-out.tar.gz and is duplicated in >>>>>>> http://ozlabs.org/~akpm/mmotm/series >>>>>>> >>>>>>> The file broken-out.tar.gz contains two datestamp files: .DATE and >>>>>>> .DATE-yyyy-mm-dd-hh-mm-ss. Both contain the string yyyy-mm-dd-hh-mm-ss, >>>>>>> followed by the base kernel version against which this patch series is to >>>>>>> be applied. >>>>>>> >>>>>>> This tree is partially included in linux-next. To see which patches are >>>>>>> included in linux-next, consult the `series' file. Only the patches >>>>>>> within the #NEXT_PATCHES_START/#NEXT_PATCHES_END markers are included in >>>>>>> linux-next. >>>>>>> >>>>>>> A git tree which contains the memory management portion of this tree is >>>>>>> maintained at git://git.kernel.org/pub/scm/linux/kernel/git/mhocko/mm.git >>>>>>> by Michal Hocko. It contains the patches which are between the >>>>>>> "#NEXT_PATCHES_START mm" and "#NEXT_PATCHES_END" markers, from the series >>>>>>> file, http://www.ozlabs.org/~akpm/mmotm/series. >>>>>>> >>>>>>> >>>>>>> A full copy of the full kernel tree with the linux-next and mmotm patches >>>>>>> already applied is available through git within an hour of the mmotm >>>>>>> release. Individual mmotm releases are tagged. The master branch always >>>>>>> points to the latest release, so it's constantly rebasing. >>>>>> >>>>>> >>>>>> on x86_64: with (randconfig): >>>>>> CONFIG_AUTOFS_FS=y >>>>>> CONFIG_AUTOFS4_FS=y >>>>> >>>>> Oh right, I need to make these exclusive. >>>>> >>>>> I seem to remember trying to do that along the way, can't remember why >>>>> I didn't do it in the end. >>>>> >>>>> Any suggestions about potential problems when doing it? >>>> >>>> I think that just using "depends on" for each of them will cause kconfig to >>>> complain about circular dependencies, so probably using "choice" will be >>>> needed. Or (since this is just temporary?) just say "don't do that." >>>> >>> >>> No doubt that was what happened, unfortunately I forgot to return to it. >>> >>> Right, a conditional with a message should work .... thanks. >> >> It looks like adding: >> depends on AUTOFS_FS = n && AUTOFS_FS != m > > Hi. Is there a typo on the line above? Don't think so. This was straight out of: which appears to do what's needed about as well as can be done and deals with the AUTOFS4_FS=y && AUTOFS_FS=y case. Ian diff --git a/fs/autofs4/Kconfig b/fs/autofs4/Kconfig index 53bc592a250d..2f9bafabac1b 100644 --- a/fs/autofs4/Kconfig +++ b/fs/autofs4/Kconfig @@ -1,6 +1,7 @@ config AUTOFS4_FS tristate "Kernel automounter version 4 support (also supports v3 and v5)" default n + depends on AUTOFS_FS = n && AUTOFS_FS != m help The automounter is a tool to automatically mount remote file systems on demand. This implementation is partially kernel-based to reduce @@ -30,3 +31,10 @@ config AUTOFS4_FS - any "alias autofs autofs4" will need to be removed. Please configure AUTOFS_FS instead of AUTOFS4_FS from now on. + + NOTE: Since the modules autofs and autofs4 use the same file system + type name of "autofs" only one can be built. The "depends" + above will result in AUTOFS4_FS not appearing in .config for + any setting of AUTOFS_FS other than n and AUTOFS4_FS will + appear under the AUTOFS_FS entry otherwise which is intended + to draw attention to the module rename change.