diff mbox series

libfs: fix warning in stashed_dentry_prune

Message ID tencent_938637BC4BA674C576F366443D5336109609@qq.com (mailing list archive)
State New, archived
Headers show
Series libfs: fix warning in stashed_dentry_prune | expand

Commit Message

Edward Adam Davis March 13, 2024, 1:07 p.m. UTC 
Initialize d_fsdata in advance to avoid warnings when recycling dentry due to
inode allocation failures.

Fixes: 2558e3b23112 ("libfs: add stashed_dentry_prune()")
Reported-and-tested-by: syzbot+9b5ec5ccf7234cc6cb86@syzkaller.appspotmail.com
Signed-off-by: Edward Adam Davis <eadavis@qq.com>
---
 fs/libfs.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

Comments

Christian Brauner March 14, 2024, 11:02 a.m. UTC | #1 
Thanks for the patch. However, this is already fixed upstream already.
diff mbox series

Patch

diff --git a/fs/libfs.c b/fs/libfs.c
index 0d14ae808fcf..67dc503272eb 100644
--- a/fs/libfs.c
+++ b/fs/libfs.c
@@ -2013,6 +2013,8 @@  static struct dentry *prepare_anon_dentry(struct dentry **stashed,
 	if (!dentry)
 		return ERR_PTR(-ENOMEM);
 
+	/* Store address of location where dentry's supposed to be stashed. */
+	dentry->d_fsdata = stashed;
 	inode = new_inode_pseudo(sb);
 	if (!inode) {
 		dput(dentry);
@@ -2029,9 +2031,6 @@  static struct dentry *prepare_anon_dentry(struct dentry **stashed,
 	WARN_ON_ONCE(!S_ISREG(inode->i_mode));
 	WARN_ON_ONCE(!IS_IMMUTABLE(inode));
 
-	/* Store address of location where dentry's supposed to be stashed. */
-	dentry->d_fsdata = stashed;
-
 	/* @data is now owned by the fs */
 	d_instantiate(dentry, inode);
 	return dentry;