From patchwork Mon Sep 11 10:53:42 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mukesh Ojha X-Patchwork-Id: 13379986 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 760A4CA0EC1 for ; Mon, 11 Sep 2023 21:37:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348606AbjIKV26 (ORCPT ); Mon, 11 Sep 2023 17:28:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36378 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236616AbjIKLFq (ORCPT ); Mon, 11 Sep 2023 07:05:46 -0400 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CA366CC3; Mon, 11 Sep 2023 04:05:40 -0700 (PDT) Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 38BAofAP019141; Mon, 11 Sep 2023 11:05:14 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=from : to : cc : subject : date : message-id : mime-version : content-type; s=qcppdkim1; bh=+nHqyply2F5sM8B/NLGsfKGYQg6T/bZXC9WpAdnEGGg=; b=QZS7snsm2ZVmLfJf4cuPzZoQP7STKeIEoIAIId0aZ4RpXAu/ynokBqRApgS11p2NnnVA zN0XWK6srgnjwk4Xl87crYqDWtZqofUzMPoUr6h+3IcBA7sVV9LKoOHjPrBGs5Lm1nd1 YINDzr6Ynte7SXOBqJKf/htT0FRE7O4gg+z4d1bvxNQCxl75YZd+GTruNLrtfPFbIz2B waKw3txlQ1dvqcA0m0cmNetEQZGlh4nb06R+gmxKDb7P9Fh576A3Z/YMm9ZrnEYt3l5/ ZvJ6DN4r+i+Q7SetlCBY6HymQpW7QB1UawLOGWxo59G+qh2iyflXZuvKUnEmkjJGXdUX 4Q== Received: from nasanppmta01.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3t1u3yrstw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 11 Sep 2023 11:05:13 +0000 Received: from nasanex01c.na.qualcomm.com (nasanex01c.na.qualcomm.com [10.45.79.139]) by NASANPPMTA01.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 38BB5CgZ017571 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 11 Sep 2023 11:05:12 GMT Received: from hu-mojha-hyd.qualcomm.com (10.80.80.8) by nasanex01c.na.qualcomm.com (10.45.79.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.36; Mon, 11 Sep 2023 03:54:10 -0700 From: Mukesh Ojha To: , , , , , , , , , , , , , , , , , , , , , CC: , , , , , , , , , , Subject: [REBASE PATCH v5 00/17] Add Qualcomm Minidump kernel driver related support Date: Mon, 11 Sep 2023 16:23:42 +0530 Message-ID: <1694429639-21484-1-git-send-email-quic_mojha@quicinc.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nasanex01c.na.qualcomm.com (10.45.79.139) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: P1BufpCD1S6_C-k7B9q7yNm6NBduepPb X-Proofpoint-ORIG-GUID: P1BufpCD1S6_C-k7B9q7yNm6NBduepPb X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.957,Hydra:6.0.601,FMLib:17.11.176.26 definitions=2023-09-11_06,2023-09-05_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 adultscore=0 clxscore=1015 phishscore=0 impostorscore=0 suspectscore=0 bulkscore=0 priorityscore=1501 mlxscore=0 mlxlogscore=999 malwarescore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2308100000 definitions=main-2309110100 Precedence: bulk List-ID: X-Mailing-List: linux-hardening@vger.kernel.org Hi All, I apologise that the last v5 was on sent on older tag and it was reported that it does not apply to linux-next tag cleanly, thanks to Kathiravan and Bagas.S for giving me early notice. I would like continue the conversation happened at v4 https://lore.kernel.org/lkml/632c5b97-4a91-c3e8-1e6c-33d6c4f6454f@quicinc.com/ https://lore.kernel.org/lkml/695133e6-105f-de2a-5559-555cea0a0462@quicinc.com/ We have put abstract on LPC on this topic as well as initiated a mail thread with other SoC vendors but did not get much traction on it. https://lore.kernel.org/lkml/0199db00-1b1d-0c63-58ff-03efae02cb21@quicinc.com/ We explored most of possiblity present in kernel to address this issue[1] but solution like kdump/fadump does not seems safe/secure/performant from our perspective. Hence, with this series we tried to make the minidump kernel driver, simple and tied with pstore frontends, so that it collects the present available frontends data like dmesg, ftrace, pmsg, ftrace., Also, we will be working towards enhancing generic pstore to capture more debug data which will be helpful for first hand of debugging that can benefit both other pstore users as well as us as minidump users. One of the proposal made here, https://lore.kernel.org/lkml/1683561060-2197-1-git-send-email-quic_mojha@quicinc.com/ Looking forward for your comments. Thanks, Mukesh [1] Minidump is a best effort mechanism to collect useful and predefined data for first level of debugging on end user devices running on Qualcomm SoCs. It is built on the premise that System on Chip (SoC) or subsystem part of SoC crashes, due to a range of hardware and software bugs. Hence, the ability to collect accurate data is only a best-effort. The data collected could be invalid or corrupted, data collection itself could fail, and so on. Qualcomm devices in engineering mode provides a mechanism for generating full system ramdumps for post mortem debugging. But in some cases it's however not feasible to capture the entire content of RAM. The minidump mechanism provides the means for selecting which snippets should be included in the ramdump. The core of SMEM based minidump feature is part of Qualcomm's boot firmware code. It initializes shared memory (SMEM), which is a part of DDR and allocates a small section of SMEM to minidump table i.e also called global table of content (G-ToC). Each subsystem (APSS, ADSP, ...) has their own table of segments to be included in the minidump and all get their reference from G-ToC. Each segment/region has some details like name, physical address and it's size etc. and it could be anywhere scattered in the DDR. Existing upstream Qualcomm remoteproc driver[1] already supports SMEM based minidump feature for remoteproc instances like ADSP, MODEM, ... where predefined selective segments of subsystem region can be dumped as part of coredump collection which generates smaller size artifacts compared to complete coredump of subsystem on crash. [1] https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/tree/drivers/remoteproc/qcom_common.c#n142 In addition to managing and querying the APSS minidump description, the Linux driver maintains a ELF header in a segment. This segment gets updated with section/program header whenever a new entry gets registered. Change in rebase v5: - Rebased it on latest tag available on linux-next - Added missed Poovendhan sign-off on 15/17 and tested-by tag from Kathiravan. Thanks to him for testing and reminding me of missing sign-off. Changes in v5: https://lore.kernel.org/lkml/1694290578-17733-1-git-send-email-quic_mojha@quicinc.com/ - On suggestion from Pavan.k, to have single function call for minidump collection from remoteproc driver, separated the logic to have separate minidump file called qcom_rproc_minidump.c and also renamed the function from qcom_minidump() to qcom_rproc_minidump(); however, dropped his suggestion about rework on lazy deletion during region unregister in this series, will pursue it in next series. - To simplify the minidump driver, removed the complication for frontend and different backend from Greg suggestion, will pursue this once main driver gets mainlined. - Move the dynamic ramoops region allocation from Device tree approach to command line approch with the introduction command line parsing and memblock reservation during early boot up; Not added documentation about it yet, will add if it gets positive response. - Exporting linux banner from kernel to make minidump build also as module, however, minidump is a debug module and should be kernel built to get most debug information from kernel. - Tried to address comments given on dload patch series. Changes in v4: https://lore.kernel.org/lkml/1687955688-20809-1-git-send-email-quic_mojha@quicinc.com/ - Redesigned the driver and divided the driver into front end and backend (smem) so that any new backend can be attached easily to avoid code duplication. - Patch reordering as per the driver and subsystem to easier review of the code. - Removed minidump specific code from remoteproc to minidump smem based driver. - Enabled the all the driver as modules. - Address comments made on documentation and yaml and Device tree file [Krzysztof/Konrad] - Address comments made qcom_pstore_minidump driver and given its Device tree same set of properties as ramoops. [Luca/Kees] - Added patch for MAINTAINER file. - Include defconfig change as one patch as per [Krzysztof] suggestion. - Tried to remove the redundant file scope variables from the module as per [Krzysztof] suggestion. - Addressed comments made on dload mode patch v6 version https://lore.kernel.org/lkml/1680076012-10785-1-git-send-email-quic_mojha@quicinc.com/ Changes in v3: https://lore.kernel.org/lkml/1683133352-10046-1-git-send-email-quic_mojha@quicinc.com/ - Addressed most of the comments by Srini on v2 and refactored the minidump driver. - Added platform device support - Unregister region support. - Added update region for clients. - Added pending region support. - Modified the documentation guide accordingly. - Added qcom_pstore_ramdump client driver which happen to add ramoops platform device and also registers ramoops region with minidump. - Added download mode patch series with this minidump series. https://lore.kernel.org/lkml/1680076012-10785-1-git-send-email-quic_mojha@quicinc.com/ Changes in v2: https://lore.kernel.org/lkml/1679491817-2498-1-git-send-email-quic_mojha@quicinc.com/ - Addressed review comment made by [quic_tsoni/bmasney] to add documentation. - Addressed comments made by [srinivas.kandagatla] - Dropped pstore 6/6 from the last series, till i get conclusion to get pstore region in minidump. - Fixed issue reported by kernel test robot. Changes in v1: https://lore.kernel.org/lkml/1676978713-7394-1-git-send-email-quic_mojha@quicinc.com/ Testing of the patches has been done on sm8450 target after enabling config like CONFIG_PSTORE_RAM and CONFIG_PSTORE_CONSOLE and once the device boots up. echo mini > /sys/module/qcom_scm/parameters/download_mode Try crashing it via devmem2 0xf11c000(this is known to create xpu violation and and put the device in download mode) on command prompt. Default storage type is set to via USB, so minidump would be downloaded with the help of x86_64 machine (running PCAT tool) attached to Qualcomm device which has backed minidump boot firmware support. This will make the device go to download mode and collect the minidump on to the attached x86 machine running the Qualcomm PCAT tool(This comes as part Qualcomm package manager kit). After that we will see a bunch of predefined registered region as binary blobs files starts with md_* downloaded on the x86 machine on given location in PCAT tool from the target device, more about this can be found in qualcomm minidump guide patch. Mukesh Ojha (17): docs: qcom: Add qualcomm minidump guide soc: qcom: Add qcom_rproc_minidump module remoteproc: qcom_q6v5_pas: Use qcom_rproc_minidump() remoteproc: qcom: Remove minidump related data from qcom_common.c init: export linux_banner data variable soc: qcom: Add Qualcomm APSS minidump kernel driver soc: qcom: minidump: Add pending region registration arm64: mm: Add dynamic ramoops region support through command line pstore/ram: Use dynamic ramoops reserve resource pstore: Add pstore_region_defined() helper and export it qcom_minidump: Register ramoops region with minidump MAINTAINERS: Add entry for minidump related files firmware: qcom_scm: provide a read-modify-write function pinctrl: qcom: Use qcom_scm_io_update_field() firmware: scm: Modify only the download bits in TCSR register firmware: qcom_scm: Refactor code to support multiple download mode firmware: qcom_scm: Add multiple download mode support Documentation/admin-guide/index.rst | 1 + Documentation/admin-guide/qcom_minidump.rst | 272 +++++++++++ MAINTAINERS | 10 + arch/arm64/mm/init.c | 94 ++++ drivers/firmware/Kconfig | 11 - drivers/firmware/qcom_scm.c | 94 +++- drivers/pinctrl/qcom/pinctrl-msm.c | 10 +- drivers/remoteproc/Kconfig | 1 + drivers/remoteproc/qcom_common.c | 160 ------ drivers/remoteproc/qcom_q6v5_pas.c | 3 +- drivers/soc/qcom/Kconfig | 24 + drivers/soc/qcom/Makefile | 3 + drivers/soc/qcom/qcom_minidump.c | 727 ++++++++++++++++++++++++++++ drivers/soc/qcom/qcom_minidump_internal.h | 74 +++ drivers/soc/qcom/qcom_ramoops_minidump.c | 88 ++++ drivers/soc/qcom/qcom_ramoops_minidump.h | 10 + drivers/soc/qcom/qcom_rproc_minidump.c | 111 +++++ drivers/soc/qcom/smem.c | 18 + fs/pstore/platform.c | 15 + fs/pstore/ram.c | 52 +- include/linux/firmware/qcom/qcom_scm.h | 2 + include/linux/init.h | 3 + include/linux/pstore.h | 6 + include/linux/pstore_ram.h | 2 + include/linux/soc/qcom/smem.h | 2 + include/soc/qcom/qcom_minidump.h | 56 +++ init/version-timestamp.c | 3 + 27 files changed, 1663 insertions(+), 189 deletions(-) create mode 100644 Documentation/admin-guide/qcom_minidump.rst create mode 100644 drivers/soc/qcom/qcom_minidump.c create mode 100644 drivers/soc/qcom/qcom_minidump_internal.h create mode 100644 drivers/soc/qcom/qcom_ramoops_minidump.c create mode 100644 drivers/soc/qcom/qcom_ramoops_minidump.h create mode 100644 drivers/soc/qcom/qcom_rproc_minidump.c create mode 100644 include/soc/qcom/qcom_minidump.h