| Message ID | 20240208084512.3803250-1-lee@kernel.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | scsi: Replace {v}snprintf() variants with safer alternatives | expand |
On 2/8/24 00:44, Lee Jones wrote:
> Cc: Andre Hedrick <andre@suse.com>
Please take a look at https://lwn.net/Articles/508222/.
Thanks,
Bart.
On Thu, 08 Feb 2024, Bart Van Assche wrote: > On 2/8/24 00:44, Lee Jones wrote: > > Cc: Andre Hedrick <andre@suse.com> > > Please take a look at https://lwn.net/Articles/508222/. get_maintainer.pl pulled it from here: https://github.com/torvalds/linux/blob/master/drivers/scsi/3w-xxxx.c#L11 I like to involve the people who take the time to list themselves as authors. I guess these are likely to go out of date at one point or another, especially in such a long standing subsystem such as SCSI. Not as big of an issue in NFC!
On Thu, Feb 08, 2024 at 05:49:12PM +0000, Lee Jones wrote: > On Thu, 08 Feb 2024, Bart Van Assche wrote: > > > On 2/8/24 00:44, Lee Jones wrote: > > > Cc: Andre Hedrick <andre@suse.com> > > > > Please take a look at https://lwn.net/Articles/508222/. > > get_maintainer.pl pulled it from here: > > https://github.com/torvalds/linux/blob/master/drivers/scsi/3w-xxxx.c#L11 Oh. Hm. It seems "git check-mailmap" (and get_maintainers.pl) don't support a way to remove an email address -- only redirect it. It seems we may want to support "don't use this email address" for more than just the currently observed rationale. I don't have any good suggestions for what the format should look like? Perhaps: "" <address-to-remove@example.com> ?
On Fri, 2024-02-09 at 22:56 -0800, Kees Cook wrote: > On Thu, Feb 08, 2024 at 05:49:12PM +0000, Lee Jones wrote: > > On Thu, 08 Feb 2024, Bart Van Assche wrote: > > > > > On 2/8/24 00:44, Lee Jones wrote: > > > > Cc: Andre Hedrick <andre@suse.com> > > > > > > Please take a look at https://lwn.net/Articles/508222/. > > > > get_maintainer.pl pulled it from here: > > > > https://github.com/torvalds/linux/blob/master/drivers/scsi/3w-xxxx.c#L11 > > Oh. Hm. It seems "git check-mailmap" (and get_maintainers.pl) don't > support a way to remove an email address -- only redirect it. > > It seems we may want to support "don't use this email address" for more > than just the currently observed rationale. I don't have any good > suggestions for what the format should look like? Perhaps: > > "" <address-to-remove@example.com> /dev/null ?
Note: We're also taking the time to obay our new .editorconfig overlord! For a far better description of the problem than I could author, see Jon's write-up on LWN [1] and/or Alex's on the Kernel Self Protection Project [1]. [0] https://lwn.net/Articles/69419/ [1] https://github.com/KSPP/linux/issues/105 Lee Jones (10): scsi: 3w-xxxx: Trivial: Remove trailing whitespace scsi: 53c700: Trivial: Remove trailing whitespace scsi: NCR5380: Replace snprintf() with the safer scnprintf() variant scsi: aacraid: linit: Remove snprintf() from sysfs call-backs and replace with sysfs_emit() scsi: aacraid: linit: Replace snprintf() with the safer scnprintf() variant scsi: aha1542: Replace snprintf() with the safer scnprintf() variant scsi: aic7xxx: aicasm: Trivial: Remove trailing whitespace scsi: aic7xxx: aicasm: Replace snprintf() with the safer scnprintf() variant scsi: aic94xx: Remove snprintf() from sysfs call-backs and replace with sysfs_emit() scsi: arcmsr: Remove snprintf() from sysfs call-backs and replace with sysfs_emit() drivers/scsi/3w-xxxx.c | 2 +- drivers/scsi/53c700.c | 102 +++++++++++++-------------- drivers/scsi/NCR5380.c | 16 ++--- drivers/scsi/aacraid/linit.c | 40 +++++------ drivers/scsi/aha1542.c | 2 +- drivers/scsi/aic7xxx/aicasm/aicasm.c | 16 ++--- drivers/scsi/aic94xx/aic94xx_init.c | 11 ++- drivers/scsi/arcmsr/arcmsr_attr.c | 40 +++-------- 8 files changed, 101 insertions(+), 128 deletions(-) Cc: Adam Radford <aradford@gmail.com> Cc: Adaptec OEM Raid Solutions <aacraid@microsemi.com> Cc: Andre Hedrick <andre@suse.com> Cc: de Melo <acme@conectiva.com.br> Cc: drew@colorado.edu Cc: Finn Thain <fthain@linux-m68k.org> Cc: Hannes Reinecke <hare@suse.com> Cc: "James E.J. Bottomley" <jejb@linux.ibm.com> Cc: Joel Jacobson <linux@3ware.com> Cc: John Garry <john.g.garry@oracle.com> Cc: Lee Jones <lee@kernel.org> Cc: linux-scsi@vger.kernel.org Cc: Luben Tuikov <luben_tuikov@adaptec.com> Cc: "Martin K. Petersen" <martin.petersen@oracle.com> Cc: Michael Schmitz <schmitzmic@gmail.com> Cc: "PMC-Sierra, Inc" <aacraid@pmc-sierra.com> Cc: Richard Hirst <rhirst@linuxcare.com> Cc: support@areca.com.tw Cc: Tnx to <Thomas_Roesch@m2.maus.de>