| Message ID | 20240503-gve-comma-v1-0-b50f965694ef@kernel.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | gve: Minor cleanups | expand |
On Fri, May 03, 2024 at 09:31:25PM +0100, Simon Horman wrote: > Hi, > > This short patchset provides two minor cleanups for the gve driver. > > These were found by tooling as mentioned in each patch, > and otherwise by inspection. > > No change in run time behaviour is intended. > Each patch is compile tested only. > Both patches look fine to me. Reviewed-by: Larysa Zaremba <larysa.zaremba@intel.com> > --- > Simon Horman (2): > gve: Avoid unnecessary use of comma operator > gve: Use ethtool_sprintf/puts() to fill stats strings > > drivers/net/ethernet/google/gve/gve_adminq.c | 4 +-- > drivers/net/ethernet/google/gve/gve_ethtool.c | 42 +++++++++++---------------- > 2 files changed, 19 insertions(+), 27 deletions(-) > > base-commit: 5829614a7b3b2cc9820efb2d29a205c00d748fcf > >
On Fri, May 3, 2024 at 1:31 PM Simon Horman <horms@kernel.org> wrote: > > Hi, > > This short patchset provides two minor cleanups for the gve driver. > > These were found by tooling as mentioned in each patch, > and otherwise by inspection. > > No change in run time behaviour is intended. > Each patch is compile tested only. > > --- > Simon Horman (2): > gve: Avoid unnecessary use of comma operator > gve: Use ethtool_sprintf/puts() to fill stats strings Reviewed-by: Shailend Chand <shailend@google.com> Thanks! > > drivers/net/ethernet/google/gve/gve_adminq.c | 4 +-- > drivers/net/ethernet/google/gve/gve_ethtool.c | 42 +++++++++++---------------- > 2 files changed, 19 insertions(+), 27 deletions(-) > > base-commit: 5829614a7b3b2cc9820efb2d29a205c00d748fcf >
On Fri, 03 May 2024 21:31:25 +0100 Simon Horman wrote: > This short patchset provides two minor cleanups for the gve driver. > > These were found by tooling as mentioned in each patch, > and otherwise by inspection. > > No change in run time behaviour is intended. > Each patch is compile tested only. Looks like it conflicts now, please rebase
On Tue, May 07, 2024 at 03:28:46PM -0700, Jakub Kicinski wrote: > On Fri, 03 May 2024 21:31:25 +0100 Simon Horman wrote: > > This short patchset provides two minor cleanups for the gve driver. > > > > These were found by tooling as mentioned in each patch, > > and otherwise by inspection. > > > > No change in run time behaviour is intended. > > Each patch is compile tested only. > > Looks like it conflicts now, please rebase Thanks, I'll rebase and send a v2.
Hi, This short patchset provides two minor cleanups for the gve driver. These were found by tooling as mentioned in each patch, and otherwise by inspection. No change in run time behaviour is intended. Each patch is compile tested only. --- Simon Horman (2): gve: Avoid unnecessary use of comma operator gve: Use ethtool_sprintf/puts() to fill stats strings drivers/net/ethernet/google/gve/gve_adminq.c | 4 +-- drivers/net/ethernet/google/gve/gve_ethtool.c | 42 +++++++++++---------------- 2 files changed, 19 insertions(+), 27 deletions(-) base-commit: 5829614a7b3b2cc9820efb2d29a205c00d748fcf