From patchwork Mon Jun 3 23:33:30 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steven Rostedt X-Patchwork-Id: 13684478 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7D58A8BFD; Mon, 3 Jun 2024 23:35:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717457720; cv=none; b=tzEFvilbnMntgBDqfWCc8VcKywZ0tl5dR7o+IMmNJRUEioO/9EhNLhx+mK+0q0i/CgqWeHGPIkxCVatl8/iFBGtMhR1R3j0oAllwwSM0hAFA3MMOjsgTHUkXMqAhlXg4ihIUj/9s9XoQohncoaV4tVcKPjvUEBVfOZ5rxv8e8V0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717457720; c=relaxed/simple; bh=1dMFOe+xbS+TUyK3xZQGgujFUJjG1tCcfG92qGYpPpo=; h=Message-ID:Date:From:To:Cc:Subject; b=sEgRpk3VPRGiHCRoa1DUE5mlY5TP1nvPMPUFl+Vg6VrmJKYnmwDDApaFI2pbcYG+7MWnzmZpgaaF2tPC5+k6YB0dIBnkbdK+8zlba3fx8r0X+yx+CnFUBz4BWxXAx5uXGdJYcSF6gXzpzrhM7wdl1DJYjFo23ZfOiFgok93KFVc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 21208C2BD10; Mon, 3 Jun 2024 23:35:20 +0000 (UTC) Received: from rostedt by gandalf with local (Exim 4.97) (envelope-from ) id 1sEHE7-00000009cuy-1lvA; Mon, 03 Jun 2024 19:36:31 -0400 Message-ID: <20240603233330.801075898@goodmis.org> User-Agent: quilt/0.68 Date: Mon, 03 Jun 2024 19:33:30 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org Cc: Masami Hiramatsu , Mark Rutland , Mathieu Desnoyers , Andrew Morton , "Liam R. Howlett" , Vlastimil Babka , Lorenzo Stoakes , linux-mm@kvack.org, Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Peter Zijlstra , Kees Cook , Tony Luck , "Guilherme G. Piccoli" , linux-hardening@vger.kernel.org, Guenter Roeck , Ross Zwisler , wklin@google.com, Vineeth Remanan Pillai , Joel Fernandes , Suleiman Souhlal , Linus Torvalds , Catalin Marinas , Will Deacon Subject: [PATCH 0/2] mm/pstore: Reserve named unspecified memory across boots Precedence: bulk X-Mailing-List: linux-hardening@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Reserve unspecified location of physical memory from kernel command line Background: In ChromeOS, we have 1 MB of pstore ramoops reserved so that we can extract dmesg output and some other information when a crash happens in the field. (This is only done when the user selects "Allow Google to collect data for improving the system"). But there are cases when there's a bug that requires more data to be retrieved to figure out what is happening. We would like to increase the pstore size, either temporarily, or maybe even permanently. The pstore on these devices are at a fixed location in RAM (as the RAM is not cleared on soft reboots nor crashes). The location is chosen by the BIOS (coreboot) and passed to the kernel via ACPI tables on x86. There's a driver that queries for this to initialize the pstore for ChromeOS: See drivers/platform/chrome/chromeos_pstore.c Problem: The problem is that, even though there's a process to change the kernel on these systems, and is done regularly to install updates, the firmware is updated much less frequently. Choosing the place in RAM also takes special care, and may be in a different address for different boards. Updating the size via firmware is a large effort and not something that many are willing to do for a temporary pstore size change. Requirement: Need a way to reserve memory that will be at a consistent location for every boot, if the kernel and system are the same. Does not need to work if rebooting to a different kernel, or if the system can change the memory layout between boots. The reserved memory can not be an hard coded address, as the same kernel / command line needs to run on several different machines. The picked memory reservation just needs to be the same for a given machine, but may be different for different machines. Solution: The solution I have come up with is to introduce a new "reserve_mem=" kernel command line. This parameter takes the following format: reserve_mem=nn:align:label Where nn is the size of memory to reserve, the align is the alignment of that memory, and label is the way for other sub-systems to find that memory. This way the kernel command line could have: reserve_mem=12M:4096:oops ramoops.mem_name=oops At boot up, the kernel will search for 12 megabytes in usable memory regions with an alignment of 4096. It will start at the highest regions and work its way down (for those old devices that want access to lower address DMA). When it finds a region, it will save it off in a small table and mark it with the "oops" label. Then the pstore ramoops sub-system could ask for that memory and location, and it will map itself there. This prototype allows for 8 different mappings (which may be overkill, 4 is probably plenty) with 16 byte size to store the label. I have tested this and it works for us to solve the above problem. We can update the kernel and command line and increase the size of pstore without needing to update the firmware, or knowing every memory layout of each board. I only tested this locally, it has not been tested in the field. Changes since the POC: https://lore.kernel.org/all/20240409210254.660888920@goodmis.org/ - Used Mike Rapoport's suggesting to use the later call to memblock_phys_alloc() instead of messing with the e820 tables. - No longer uses the " memmap" kernel command line and instead uses "reserve_mem". This also removes the issue of booting a kernel without it crashing due to "memmap" defaulting to using only the specified memory when it doesn't know what the extra option is. - No longer keeping the table as __initdata so that pstore can use it via a module. - This is no longer a proof of concept patch series. Steven Rostedt (Google) (2): mm/memblock: Add "reserve_mem" to reserved named memory at boot up pstore/ramoops: Add ramoops.mem_name= command line option ---- fs/pstore/ram.c | 15 +++++++++ include/linux/mm.h | 2 ++ mm/memblock.c | 97 ++++++++++++++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 114 insertions(+)