mbox series

[0/3] UAPI: ethtool: Avoid flex-array in struct ethtool_link_settings

Message ID 20241115204115.work.686-kees@kernel.org (mailing list archive)
Headers show
Series UAPI: ethtool: Avoid flex-array in struct ethtool_link_settings | expand

Message

Kees Cook Nov. 15, 2024, 8:43 p.m. UTC
Hi,

This reverts the tagged struct group in struct ethtool_link_settings and
instead just removes the flexible array member from Linux's view as it
is entirely unused.

-Kees

Kees Cook (3):
  Revert "net: ethtool: Avoid thousands of
    -Wflex-array-member-not-at-end warnings"
  Revert "UAPI: ethtool: Use __struct_group() in struct
    ethtool_link_settings"
  UAPI: ethtool: Avoid flex-array in struct ethtool_link_settings

 .../net/ethernet/broadcom/bnxt/bnxt_ethtool.c |  6 +--
 .../ethernet/chelsio/cxgb4/cxgb4_ethtool.c    |  4 +-
 .../ethernet/chelsio/cxgb4vf/cxgb4vf_main.c   |  2 +-
 .../net/ethernet/cisco/enic/enic_ethtool.c    |  2 +-
 .../net/ethernet/qlogic/qede/qede_ethtool.c   |  4 +-
 include/linux/ethtool.h                       |  2 +-
 include/uapi/linux/ethtool.h                  | 40 ++++++++++---------
 net/ethtool/ioctl.c                           |  2 +-
 net/ethtool/linkinfo.c                        |  8 ++--
 net/ethtool/linkmodes.c                       | 18 ++++-----
 10 files changed, 44 insertions(+), 44 deletions(-)

Comments

patchwork-bot+netdevbpf@kernel.org Nov. 19, 2024, 4 a.m. UTC | #1
Hello:

This series was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Fri, 15 Nov 2024 12:43:02 -0800 you wrote:
> Hi,
> 
> This reverts the tagged struct group in struct ethtool_link_settings and
> instead just removes the flexible array member from Linux's view as it
> is entirely unused.
> 
> -Kees
> 
> [...]

Here is the summary with links:
  - [1/3] Revert "net: ethtool: Avoid thousands of -Wflex-array-member-not-at-end warnings"
    https://git.kernel.org/netdev/net-next/c/1cfb5e57886a
  - [2/3] Revert "UAPI: ethtool: Use __struct_group() in struct ethtool_link_settings"
    https://git.kernel.org/netdev/net-next/c/ebda123fe703
  - [3/3] UAPI: ethtool: Avoid flex-array in struct ethtool_link_settings
    https://git.kernel.org/netdev/net-next/c/96c677fca54a

You are awesome, thank you!