[v2,0/2] pwm-fan: Refactor and convert to recommended API

Message

Paul Barker Nov. 28, 2020, 5:49 p.m. UTC

This series includes the first patch from my previous series adding support
for multiple fan tachometers [1] which Guenter has already reviewed, plus a
second patch to convert the driver to use the hwmon_device_register_with_info
API as requested.

These patches have been tested on a SanCloud BeagleBone Enhanced using an
oscilloscope to check the PWM output and a signal generator to simulate
the fan tachometer signals. I've tested both with and without a fan
tachometer input defined in the device tree.

There shouldn't be any functional change to the driver after these patches,
it just puts us in a much better place for further development.

These changes can also be pulled from:

  https://gitlab.com/pbarker.dev/staging/linux.git
  tag: for-hwmon/pwm-fan-refactor-v2_2020-11-28

Changes from v1:

  * Addressed review comment from Guenter: Simplify pwm_fan_write, return
    -ENOTSUPP from pwm_fan_read if the wrong type is given, use devm_kcalloc
    instead of devm_kzalloc to ensure multiplication is safe.

Paul Barker (2):
  hwmon: pwm-fan: Refactor pwm_fan_probe
  hwmon: pwm-fan: Convert to hwmon_device_register_with_info API

 drivers/hwmon/pwm-fan.c | 164 +++++++++++++++++++++++++---------------
 1 file changed, 104 insertions(+), 60 deletions(-)


base-commit: e6e2c18f63c62df778ce484945fccad088594533