[RFC,0/3] hwmon: (dell-smm-hwmon) Use platform device

Message

Armin Wolf May 15, 2021, 6:34 p.m. UTC

From: Armin Wolf <[e-mail]>

Use a platform device in order to use devres functions.
Also a future rewrite of the driver requieres a device.

Are the patches for introducing the platform driver/device
ok for serving as the basis for the conversion to
hwmon_device_register_with_info()?

They work on my Dell Latitude C600 just fine, but i whould
appreciate someone testing the code on another model too.

Armin Wolf (3):
  hwmon: (dell-smm-hwmon) Use platform device
  hwmon: (dell-smm-hwmon) Use devm_add_action_or_reset()
  hwmon: (dell-smm-hwmon) Move variables into a driver private data
    structure

 drivers/hwmon/dell-smm-hwmon.c | 392 ++++++++++++++++++---------------
 1 file changed, 210 insertions(+), 182 deletions(-)

--
2.20.1

Comments

Guenter Roeck May 16, 2021, 2:08 p.m. UTC | #1

On 5/15/21 11:34 AM, [e-mail] wrote:
> From: Armin Wolf <[e-mail]>
> 
> Use a platform device in order to use devres functions.
> Also a future rewrite of the driver requieres a device.
> 
> Are the patches for introducing the platform driver/device
> ok for serving as the basis for the conversion to
> hwmon_device_register_with_info()?
> 

The final result looks good. I would suggest though to move
everything except the DMI information check and the SMM Dell
signature from the init function to the probe function in
patch 1/3, not in patch 3/3.

> They work on my Dell Latitude C600 just fine, but i whould
> appreciate someone testing the code on another model too.
> 

Yes, it would be great to get some additional testing.

Thanks,
Guenter

> Armin Wolf (3):
>    hwmon: (dell-smm-hwmon) Use platform device
>    hwmon: (dell-smm-hwmon) Use devm_add_action_or_reset()
>    hwmon: (dell-smm-hwmon) Move variables into a driver private data
>      structure
> 
>   drivers/hwmon/dell-smm-hwmon.c | 392 ++++++++++++++++++---------------
>   1 file changed, 210 insertions(+), 182 deletions(-)
> 
> --
> 2.20.1
>