| Message ID | 20210519132910.14453-1-W_Armin@gmx.de (mailing list archive) |
|---|---|
| Headers | show |
| Series | hwmon: (dell-smm-hwmon) Convert to new hwmon | expand |
On 5/19/21 6:29 AM, W_Armin@gmx.de wrote: > From: Armin Wolf <W_Armin@gmx.de> > > This patch series is converting the dell-smm-hwmon driver > to the new hwmon registration API. In order to do so, > it introduces a platform device in the first patch, and > applies some optimisations in the next three patches. > The switch to the new hwmon registration API is done in > the last patch. > > The caching of the fan/temp values was modified to better fit > the new hwmon API. > > The patches work fine for my Dell Latitude C600, but i whould > appreciate someone testing the code on another model too. > > Armin Wolf (5): > hwmon: (dell-smm-hwmon) Use platform device > hwmon: (dell-smm-hwmon) Mark functions as __init > hwmon: (dell-smm-hwmon) Use devm_add_action_or_reset() > hwmon: (dell-smm-hwmon) Move variables into a driver private data > structure > hwmon: (dell-smm-hwmon) Convert to > devm_hwmon_device_register_with_info() > > drivers/hwmon/dell-smm-hwmon.c | 860 ++++++++++++++++----------------- > 1 file changed, 425 insertions(+), 435 deletions(-) > Any chance to get a Reviewed-by/Tested-by: for the series from someone ? Thanks, Guenter
On Wednesday 26 May 2021 09:10:05 Guenter Roeck wrote: > On 5/19/21 6:29 AM, W_Armin@gmx.de wrote: > > From: Armin Wolf <W_Armin@gmx.de> > > > > This patch series is converting the dell-smm-hwmon driver > > to the new hwmon registration API. In order to do so, > > it introduces a platform device in the first patch, and > > applies some optimisations in the next three patches. > > The switch to the new hwmon registration API is done in > > the last patch. > > > > The caching of the fan/temp values was modified to better fit > > the new hwmon API. > > > > The patches work fine for my Dell Latitude C600, but i whould > > appreciate someone testing the code on another model too. > > > > Armin Wolf (5): > > hwmon: (dell-smm-hwmon) Use platform device > > hwmon: (dell-smm-hwmon) Mark functions as __init > > hwmon: (dell-smm-hwmon) Use devm_add_action_or_reset() > > hwmon: (dell-smm-hwmon) Move variables into a driver private data > > structure > > hwmon: (dell-smm-hwmon) Convert to > > devm_hwmon_device_register_with_info() > > > > drivers/hwmon/dell-smm-hwmon.c | 860 ++++++++++++++++----------------- > > 1 file changed, 425 insertions(+), 435 deletions(-) > > > > Any chance to get a Reviewed-by/Tested-by: for the series from someone ? Hello! I'm quite busy with other stuff. I will try to look and review this patch series later. > Thanks, > Guenter > >
From: Armin Wolf <W_Armin@gmx.de> This patch series is converting the dell-smm-hwmon driver to the new hwmon registration API. In order to do so, it introduces a platform device in the first patch, and applies some optimisations in the next three patches. The switch to the new hwmon registration API is done in the last patch. The caching of the fan/temp values was modified to better fit the new hwmon API. The patches work fine for my Dell Latitude C600, but i whould appreciate someone testing the code on another model too. Armin Wolf (5): hwmon: (dell-smm-hwmon) Use platform device hwmon: (dell-smm-hwmon) Mark functions as __init hwmon: (dell-smm-hwmon) Use devm_add_action_or_reset() hwmon: (dell-smm-hwmon) Move variables into a driver private data structure hwmon: (dell-smm-hwmon) Convert to devm_hwmon_device_register_with_info() drivers/hwmon/dell-smm-hwmon.c | 860 ++++++++++++++++----------------- 1 file changed, 425 insertions(+), 435 deletions(-) -- 2.20.1