mbox series

[v12,0/2] Update ASUS WMI supported boards

Message ID 20211116205744.381790-1-pauk.denis@gmail.com (mailing list archive)
Headers show
Series Update ASUS WMI supported boards | expand

Message

Denis Pauk Nov. 16, 2021, 8:57 p.m. UTC 
Add support by WMI interface provided by Asus for B550/X570 boards: 
* PRIME X570-PRO,
* ROG CROSSHAIR VIII HERO
* ROG CROSSHAIR VIII DARK HERO
* ROG CROSSHAIR VIII FORMULA
* ROG STRIX X570-E GAMING
* ROG STRIX B550-I GAMING
* ROG STRIX B550-E GAMING

Add support by WMI interface provided by Asus for X370/X470/
B450/X399 boards:
* ROG CROSSHAIR VI HERO,
* PRIME X399-A,
* PRIME X470-PRO,
* ROG CROSSHAIR VI EXTREME,
* ROG CROSSHAIR VI HERO (WI-FI AC),
* ROG CROSSHAIR VII HERO,
* ROG CROSSHAIR VII HERO (WI-FI),
* ROG STRIX B450-E GAMING,
* ROG STRIX B450-F GAMING,
* ROG STRIX B450-I GAMING,
* ROG STRIX X399-E GAMING,
* ROG STRIX X470-F GAMING,
* ROG STRIX X470-I GAMING,
* ROG ZENITH EXTREME,
* ROG ZENITH EXTREME ALPHA.

I have removed "ROG STRIX Z390-F GAMING" from list of supported boards in 
asus_wmi_sensors that I have added by mistake. I had misunderstood a 
comment in the [1] issue.

I have added separate records for each of modules in MAINTAINERS file. 
Before it was one shared recors for both of modules.

Could you please review?

Signed-off-by: Ed Brindley <kernel@maidavale.org>
Signed-off-by: Eugene Shalygin <eugene.shalygin@gmail.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Denis Pauk <pauk.denis@gmail.com>

[1]: https://github.com/electrified/asus-wmi-sensors/issues/78.

---
Changes in v12:
- asus_wmi_sensors: Remove "ROG STRIX Z390-F GAMING" added by mistake.
- Create separate record about asus_wmi_sensors.

Changes in v11:
- asus_wmi_sensors: Add "ROG STRIX Z390-F GAMING" to list of supported boards
  in asus_wmi_sensors.

Changes in v10:
- Use long for sensor values.
- Remove unrequired linux/hwmon-sysfs.h
- Add "ROG STRIX B550-I GAMING" board support in asus_wmi_ec_sensors.
- Change code style in error status return.
- Remove unuses wmi.buffer and fix type of source in asus_wmi_sensors.

Changes in v9:
- Fix memory leaks in asus_wmi_ec_block_read()
- Fix buffer and parameter lengths in decode and encode algorithms
- Simplify encoding in read query
- Reshuffle structures to make pointer arithmetics simpler or
  no-op in some cases
- Shuffle parameters in some functions to make it more logical
- Use temporary variable for EC info data structure
- Many indentation fixes to improve readability (breaks 80 characters rule)
- Fix memory leaks in asus_wmi_sensors:asus_wmi_*().

Changes in v8:
- Add seprate patch for ProArt X570-CREATOR WIFI support.
- Fix codestyle in defines and comments.
- Fix buffer length calculation.
- Use hex2bin/bin2hex for convert values in buffers.
- Remove unrequired acpi_os_free usage.
- Call mutex_lock inside of functions.

Changes in v7:
- Use  for directly get sensors list by board.
- Add depends on ACPI_WMI to Kconfig.
- Add response buffer size check in asus_wmi_ec_decode_reply_buffer.
- Clean up defines names.

Changes in v6:
- asus_wmi_ec_sensors: Generate query for all sensors on sensors setup
- asus_wmi_ec_sensors: Move binary to sensor value logic to separate 
  get_sensor_value (by Eugene Shalygin)
- asus_wmi_ec_sensors: Use acpi_os_free without NULL pointer check.
- Add asus_wmi_sensor to documentation index.
- Add asus_wmi_ec_sensor to documentation index.

Changes in v5:
- Fixes build issue reported by kernel test robot with disabled ACPI_WMI.
- asus_wmi_sensors: Remove sensor->name check as always evaluated to true.

Changes in v4:
 - Implement wmi driver instead platform driver.
 - Update documentation with known issues.

Changes in v3:
 - Use MODULE_DEVICE_TABLE for match devices.
 - asus_wmi_ec_sensors: Use get_unaligned_be32 instead incorrectly used 
   get_unaligned_le32.
 - Add documentaion for drivers.

Changes in v2:
 - asus_wmi_ec_sensors: Rename asus_wmi_sensors to asus_wmi_ec_sensors for 
   B550/X570 boards.
 - asus_wmi_ec_sensors: Use utf8s_to_utf16s/utf16s_to_utf8s instead handmade 
   fuctions.
 - asus_wmi_ec_sensors: Use post increment.
 - asus_wmi_ec_sensors: Use get_unaligned* for convert values.
 - asus_wmi_ec_sensors: Use PTR_ERR_OR_ZERO.
 - asus_wmi_ec_sensors: Specify per-board sensors in a declarative way 
   (by Eugene Shalygin).
 - asus_wmi_sensors: Add support for X370/X470/B450/X399 boards.

---

Denis Pauk (2):
  hwmon: (asus_wmi_ec_sensors) Support B550 Asus WMI.
  hwmon: (asus_wmi_sensors) Support X370 Asus WMI.

 Documentation/hwmon/asus_wmi_ec_sensors.rst |  38 ++
 Documentation/hwmon/asus_wmi_sensors.rst    |  76 +++
 Documentation/hwmon/index.rst               |   2 +
 MAINTAINERS                                 |  14 +
 drivers/hwmon/Kconfig                       |  24 +
 drivers/hwmon/Makefile                      |   2 +
 drivers/hwmon/asus_wmi_ec_sensors.c         | 621 ++++++++++++++++++
 drivers/hwmon/asus_wmi_sensors.c            | 664 ++++++++++++++++++++
 8 files changed, 1441 insertions(+)
 create mode 100644 Documentation/hwmon/asus_wmi_ec_sensors.rst
 create mode 100644 Documentation/hwmon/asus_wmi_sensors.rst
 create mode 100644 drivers/hwmon/asus_wmi_ec_sensors.c
 create mode 100644 drivers/hwmon/asus_wmi_sensors.c


base-commit: fa55b7dcdc43c1aa1ba12bca9d2dd4318c2a0dbf

Comments

Guenter Roeck Nov. 19, 2021, 11:36 a.m. UTC | #1 
On 11/16/21 12:57 PM, Denis Pauk wrote:
> Add support by WMI interface provided by Asus for B550/X570 boards:
> * PRIME X570-PRO,
> * ROG CROSSHAIR VIII HERO
> * ROG CROSSHAIR VIII DARK HERO
> * ROG CROSSHAIR VIII FORMULA
> * ROG STRIX X570-E GAMING
> * ROG STRIX B550-I GAMING
> * ROG STRIX B550-E GAMING
> 
> Add support by WMI interface provided by Asus for X370/X470/
> B450/X399 boards:
> * ROG CROSSHAIR VI HERO,
> * PRIME X399-A,
> * PRIME X470-PRO,
> * ROG CROSSHAIR VI EXTREME,
> * ROG CROSSHAIR VI HERO (WI-FI AC),
> * ROG CROSSHAIR VII HERO,
> * ROG CROSSHAIR VII HERO (WI-FI),
> * ROG STRIX B450-E GAMING,
> * ROG STRIX B450-F GAMING,
> * ROG STRIX B450-I GAMING,
> * ROG STRIX X399-E GAMING,
> * ROG STRIX X470-F GAMING,
> * ROG STRIX X470-I GAMING,
> * ROG ZENITH EXTREME,
> * ROG ZENITH EXTREME ALPHA.
> 
> I have removed "ROG STRIX Z390-F GAMING" from list of supported boards in
> asus_wmi_sensors that I have added by mistake. I had misunderstood a
> comment in the [1] issue.
> 
> I have added separate records for each of modules in MAINTAINERS file.
> Before it was one shared recors for both of modules.
> 
> Could you please review?
> 

Series applied to hwmon-next.

Thanks,
Guenter
Andy Shevchenko Nov. 23, 2021, 10:22 a.m. UTC | #2 
On Fri, Nov 19, 2021 at 1:36 PM Guenter Roeck <linux@roeck-us.net> wrote:
>
> On 11/16/21 12:57 PM, Denis Pauk wrote:
> > Add support by WMI interface provided by Asus for B550/X570 boards:
> > * PRIME X570-PRO,
> > * ROG CROSSHAIR VIII HERO
> > * ROG CROSSHAIR VIII DARK HERO
> > * ROG CROSSHAIR VIII FORMULA
> > * ROG STRIX X570-E GAMING
> > * ROG STRIX B550-I GAMING
> > * ROG STRIX B550-E GAMING
> >
> > Add support by WMI interface provided by Asus for X370/X470/
> > B450/X399 boards:
> > * ROG CROSSHAIR VI HERO,
> > * PRIME X399-A,
> > * PRIME X470-PRO,
> > * ROG CROSSHAIR VI EXTREME,
> > * ROG CROSSHAIR VI HERO (WI-FI AC),
> > * ROG CROSSHAIR VII HERO,
> > * ROG CROSSHAIR VII HERO (WI-FI),
> > * ROG STRIX B450-E GAMING,
> > * ROG STRIX B450-F GAMING,
> > * ROG STRIX B450-I GAMING,
> > * ROG STRIX X399-E GAMING,
> > * ROG STRIX X470-F GAMING,
> > * ROG STRIX X470-I GAMING,
> > * ROG ZENITH EXTREME,
> > * ROG ZENITH EXTREME ALPHA.
> >
> > I have removed "ROG STRIX Z390-F GAMING" from list of supported boards in
> > asus_wmi_sensors that I have added by mistake. I had misunderstood a
> > comment in the [1] issue.
> >
> > I have added separate records for each of modules in MAINTAINERS file.
> > Before it was one shared recors for both of modules.
> >
> > Could you please review?
> >
>
> Series applied to hwmon-next.

What is the repository it has been applied to? I don't see it in
neither Linux Next nor [1]. It might be that I am missing the
workflow.

[1]: https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git/log/?h=hwmon-next
Guenter Roeck Nov. 23, 2021, 3:50 p.m. UTC | #3 
On Tue, Nov 23, 2021 at 12:22:46PM +0200, Andy Shevchenko wrote:
> >
> > Series applied to hwmon-next.
> 
> What is the repository it has been applied to? I don't see it in
> neither Linux Next nor [1]. It might be that I am missing the
> workflow.
> 

I had not pushed the branch out. Done now.

Guenter
Andy Shevchenko Nov. 23, 2021, 4:20 p.m. UTC | #4 
On Tue, Nov 23, 2021 at 07:50:40AM -0800, Guenter Roeck wrote:
> On Tue, Nov 23, 2021 at 12:22:46PM +0200, Andy Shevchenko wrote:
> > >
> > > Series applied to hwmon-next.
> > 
> > What is the repository it has been applied to? I don't see it in
> > neither Linux Next nor [1]. It might be that I am missing the
> > workflow.
> 
> I had not pushed the branch out. Done now.

I can see it now, thanks!