| Message ID | 20220131211935.3656-1-W_Armin@gmx.de (mailing list archive) |
|---|---|
| Headers | show |
| Series | hwmon: (sch56xx) Automatically load on supported hardware | expand |
Hi, On 1/31/22 22:19, Armin Wolf wrote: > The hardware monitoring solutions supported by the sch5627 and > sch5636 drivers are Fujitsu-specific. > After some online searching, i found out that the solution used > with the SCH5627 is called "Antiope" by Fujitsu, just like the > "Theseus" solution inside the SCH5636. > I also found out that "Antiope" and "Theseus" are listed as > DMI onboard devices on supported Fujitsu devices, so the > sch56xx_common module can be loaded automatically an check > for the DMI devices. However some devices like the Esprimo C700 > have both devices, so after verifying that at least one onboard > device is present, sch56xx_common still has to detect which chip > is present. > This is safe however if at least one device is present. > > Tested on a Fujitsu Esprimo P720. Thanks, the new version of the entire series looks good to me: Reviewed-by: Hans de Goede <hdegoede@redhat.com> for the series. Regards, Hans > > --- > Changes in v3: > - fix usleep_range using the same value as msleep > > Changes in v2: > - fix unused variable issue reported by the kernel test robot > by assinging the platform device id list in sch5627/sch5636 > to platform_driver->id_table. > > Armin Wolf (4): > hwmon: (sch56xx) Autoload modules on platform device creation > hwmon: (sch56xx-common) Add automatic module loading on supported > devices > hwmon: (sch56xx-common) Replace msleep() with usleep_range() > hwmon: (sch56xx-common) Replace WDOG_ACTIVE with WDOG_HW_RUNNING > > drivers/hwmon/sch5627.c | 10 ++++++++ > drivers/hwmon/sch5636.c | 10 ++++++++ > drivers/hwmon/sch56xx-common.c | 44 ++++++++++++++++++++++++++++++---- > 3 files changed, 60 insertions(+), 4 deletions(-) > > -- > 2.30.2 >
On Tue, Feb 01, 2022 at 01:57:02PM +0100, Hans de Goede wrote: > Hi, > > On 1/31/22 22:19, Armin Wolf wrote: > > The hardware monitoring solutions supported by the sch5627 and > > sch5636 drivers are Fujitsu-specific. > > After some online searching, i found out that the solution used > > with the SCH5627 is called "Antiope" by Fujitsu, just like the > > "Theseus" solution inside the SCH5636. > > I also found out that "Antiope" and "Theseus" are listed as > > DMI onboard devices on supported Fujitsu devices, so the > > sch56xx_common module can be loaded automatically an check > > for the DMI devices. However some devices like the Esprimo C700 > > have both devices, so after verifying that at least one onboard > > device is present, sch56xx_common still has to detect which chip > > is present. > > This is safe however if at least one device is present. > > > > Tested on a Fujitsu Esprimo P720. > > Thanks, the new version of the entire series looks good to me: > > Reviewed-by: Hans de Goede <hdegoede@redhat.com> > Series applied. Thanks, Guenter
The hardware monitoring solutions supported by the sch5627 and sch5636 drivers are Fujitsu-specific. After some online searching, i found out that the solution used with the SCH5627 is called "Antiope" by Fujitsu, just like the "Theseus" solution inside the SCH5636. I also found out that "Antiope" and "Theseus" are listed as DMI onboard devices on supported Fujitsu devices, so the sch56xx_common module can be loaded automatically an check for the DMI devices. However some devices like the Esprimo C700 have both devices, so after verifying that at least one onboard device is present, sch56xx_common still has to detect which chip is present. This is safe however if at least one device is present. Tested on a Fujitsu Esprimo P720. --- Changes in v3: - fix usleep_range using the same value as msleep Changes in v2: - fix unused variable issue reported by the kernel test robot by assinging the platform device id list in sch5627/sch5636 to platform_driver->id_table. Armin Wolf (4): hwmon: (sch56xx) Autoload modules on platform device creation hwmon: (sch56xx-common) Add automatic module loading on supported devices hwmon: (sch56xx-common) Replace msleep() with usleep_range() hwmon: (sch56xx-common) Replace WDOG_ACTIVE with WDOG_HW_RUNNING drivers/hwmon/sch5627.c | 10 ++++++++ drivers/hwmon/sch5636.c | 10 ++++++++ drivers/hwmon/sch56xx-common.c | 44 ++++++++++++++++++++++++++++++---- 3 files changed, 60 insertions(+), 4 deletions(-) -- 2.30.2