mbox series

[v3,0/4] asus-ec-sensors: add support for board families

Message ID 20220427143001.1443605-1-eugene.shalygin@gmail.com (mailing list archive)
Headers show
Series asus-ec-sensors: add support for board families | expand

Message

Eugene Shalygin April 27, 2022, 2:29 p.m. UTC
Users provided information for boards from AMD-400 and sTRX40 families
and demonstrated that sensor addresses differ from those for the AMD-500
family. Also the AMD-400 family board uses the global ACPI lock instead
of a dedicated mutex to guard access to the hardware.

This patchset implements required changes to support other board
families:
 - per-family sensor definitions
 - options to choose hardware/state guard mutex: an AML mutex or the
   global ACPI lock.

These changes are used to add support for the PRIME X470-PRO board.


Changes in 
v3:
 - Added family_unknown member to the board_family enum to ensure the
	 default value of 0 is not a valid family value.
 - Added a note explaining why module_platform_driver_probe() is chosen
	 over module_platform_driver().

v2:
 - Removed the case without ACPI mutex where the state was guarded using
         the normal mutex. After receiving an update from user that case
         turned out to be non-existent.
 - Removed the __initconst attribute from the board data array.
 - Updated documentation to include the special string for the mutex
         path module parameters which make the driver use the global ACPI
         lock.

Eugene Shalygin (4):
  hwmon: (asus-ec-sensors) introduce ec_board_info struct for board data
  hwmon: (asus-ec-sensors) implement locking via the ACPI global lock
  hwmon: (asus-ec-sensors) add support for board families
  hwmon: (asus-ec-sensors) add PRIME X470-PRO board

 Documentation/hwmon/asus_ec_sensors.rst |   2 +
 drivers/hwmon/asus-ec-sensors.c         | 420 +++++++++++++++++-------
 2 files changed, 302 insertions(+), 120 deletions(-)

Comments

Guenter Roeck April 27, 2022, 2:39 p.m. UTC | #1
On 4/27/22 07:29, Eugene Shalygin wrote:
> Users provided information for boards from AMD-400 and sTRX40 families
> and demonstrated that sensor addresses differ from those for the AMD-500
> family. Also the AMD-400 family board uses the global ACPI lock instead
> of a dedicated mutex to guard access to the hardware.
> 
> This patchset implements required changes to support other board
> families:
>   - per-family sensor definitions
>   - options to choose hardware/state guard mutex: an AML mutex or the
>     global ACPI lock.
> 
> These changes are used to add support for the PRIME X470-PRO board.
> 
Series applied to hwmon-next.

Thanks,
Guenter

> 
> Changes in
> v3:
>   - Added family_unknown member to the board_family enum to ensure the
> 	 default value of 0 is not a valid family value.
>   - Added a note explaining why module_platform_driver_probe() is chosen
> 	 over module_platform_driver().
> 
> v2:
>   - Removed the case without ACPI mutex where the state was guarded using
>           the normal mutex. After receiving an update from user that case
>           turned out to be non-existent.
>   - Removed the __initconst attribute from the board data array.
>   - Updated documentation to include the special string for the mutex
>           path module parameters which make the driver use the global ACPI
>           lock.
> 
> Eugene Shalygin (4):
>    hwmon: (asus-ec-sensors) introduce ec_board_info struct for board data
>    hwmon: (asus-ec-sensors) implement locking via the ACPI global lock
>    hwmon: (asus-ec-sensors) add support for board families
>    hwmon: (asus-ec-sensors) add PRIME X470-PRO board
> 
>   Documentation/hwmon/asus_ec_sensors.rst |   2 +
>   drivers/hwmon/asus-ec-sensors.c         | 420 +++++++++++++++++-------
>   2 files changed, 302 insertions(+), 120 deletions(-)
>
Eugene Shalygin April 27, 2022, 2:40 p.m. UTC | #2
Thank you, Günter!

> Series applied to hwmon-next.