mbox series

[v2,0/2] it87: Add param to ignore ACPI resource conflicts

Message ID 20221002174259.14609-1-ahmad@khalifa.ws (mailing list archive)
Headers show
Series it87: Add param to ignore ACPI resource conflicts | expand

Message

Ahmad Khalifa Oct. 2, 2022, 5:42 p.m. UTC 
Add in the parameter to ignore ACPI resource conflicts so that modprobe
can use the force_id parameter when ACPI has the same address mapped.

This requires also checking the device id before assigning force_id to
avoid registering two devices. This may not be a visible issue as ACPI
conflict unregisters the whole driver, but with ignore_resource_conflict
added, both SIO addresses will register a device.

This is useful for those who don't compile their own modules from github
code and just want to configure modprobe with a /force_id/ value that
gives them coverage of the first 3-4 fans/temp/in values.

Code is inspired by the github it87 module floating out there, but didn't
merge in support for additional devices as there were objections to
that approach in past threads [1].

Tested with it8688 on Gigabyte board with id as it8628 and compared
against the out of tree module running the it8688 values (which in turn
is blindly based off of the it8686 values) and the results are the same
for the enabled sensors (i.e. not all 6 fans/temps/in are valid)


v2: updates with comments: [2]
* Add missing patch description, not just cover letter
* split change for the force_id check into separate commit

[1]: https://lore.kernel.org/linux-hwmon/6c8b5fbd514df708af84630544eca6ee12766bbd.camel@crawford.emu.id.au/
[2]: https://lore.kernel.org/linux-hwmon/20221002151148.GA2896730@roeck-us.net/T/#u

Ahmad Khalifa (2):
  it87: Add param to ignore ACPI resource conflicts
  it87: check device is valid before using force_id

 drivers/hwmon/it87.c | 18 +++++++++++++++---
 1 file changed, 15 insertions(+), 3 deletions(-)


base-commit: c3e0e1e23c70455916ff3472072437b3605c6cfe