[v2,0/2] Add support for LTC4282

Message

Nuno Sa via B4 Relay Nov. 24, 2023, 2:18 p.m. UTC

v1:
 * https://lore.kernel.org/linux-hwmon/[e-mail]/

v2:
- driver
  * Add Docs to index.rst;
  * Removed ltc4282_power_on() - Not very reasonable to enable/disable
    an hot swap from the driver;
  * Removed struct device *dev parameter from struct ltc4282_state;
  * Error out for rsense-nano-ohms < 100;
  * Return 0 on .is_visible() - not a negative error;
  * Moved to 80 column limit (Sorry about this one - it adds a lot of
    unnecessary diffs);
  * Replace ENOTSUPP with EOPNOTSUPP;
  * Return 0 on .is_visible() - not a negative error;
  * Remove Power Average (Should be done in userspace) - With it, no
    need for handling energy + tick overflows;
  * Return 0 instead of 'ret' in ltc4282_read_energy();
  * Add adi prefix to 'vin-mode-microvolt';
  * Changed 'adi,current-limit-microvolt' to
    'adi,current-limit-sense-microvolt' so it's clear the device expects
     volts to be configured;
  * Moved fault logs to debugfs while adding a new interface to clear all
    faults in one write;
  * Keep historic alarms in ltc4282_read_alarm()
  * Cache energy status so we don't have to read it from the device on
    every energy value read;
  * Use enable attributes to switch between VDD - VSOURCE;
  * Support reset_history;
  * Sync with bindings - use strings properties;
  * Move to clock provider to support the clockout settings;
  * Support gpio valid_mask;
  * Use field_prep() instead of a driver specific macro (to be coherent
    with other drivers);
  * Add comment on the big sleep pos reset;
  * Be consistent in hex letters;
  * Use BIT() in the power formulas;
  * Make use of in_range();
  * Use SENSOR_DEVICE_ATTR_[RO|WO];
  * No comma for the terminator line;
  * Update ltc4282.rst doc.

- bindings
  * Use string properties for gpio_modes and over/under voltage dividers;
  * Added #clock-cells;
  * Add adi prefix to 'vin-mode-microvolt;
  * Changed adi,current-limit-microvolt -> adi,current-limit-sense-microvolt;
  * Updated the dts example accordingly.

V2 ended up with huge changes. Specially the introduction of the enabled
stuff between VSOURCE and VDD since these are mutaally exclusive (share
the same registers and we need to mux between one of them). It feels
that I'm overdoing things a bit but OTOH, I'm fairly happy with the
result. Hopefully, it is acceptable.

I would also like to mention that there are still some questionable
custom sysfs interfaces as I was not sure if I should remove them and
got not reply in v1 (which is fine).

Lastly, as one can see, there are lots of changes since v1 so I'm sorry
if I missed some of the comments given in review. Not on purpose... And
it would be really nice if one of the GPIO maintainers could look at the
GPIO stuff. Please see my V1 cover where I speak about it. I'm not
really sure I'm properly handling the pins.

---
Nuno Sa (2):
      dt-bindings: hwmon: Add LTC4282 bindings
      hwmon: ltc4282: add support for the LTC4282 chip

 .../devicetree/bindings/hwmon/adi,ltc4282.yaml     |  206 +++
 Documentation/hwmon/index.rst                      |    1 +
 Documentation/hwmon/ltc4282.rst                    |  108 ++
 MAINTAINERS                                        |    8 +
 drivers/hwmon/Kconfig                              |   11 +
 drivers/hwmon/Makefile                             |    1 +
 drivers/hwmon/ltc4282.c                            | 1891 ++++++++++++++++++++
 7 files changed, 2226 insertions(+)

Thanks!
- Nuno Sá