mbox series

[v3,0/2] Add support for LTC4282

Message ID 20231205-ltc4282-support-v3-0-e0877b281bc2@analog.com (mailing list archive)
Headers show
Series Add support for LTC4282 | expand

Message

Nuno Sa via B4 Relay Dec. 5, 2023, 3:22 p.m. UTC 
v1:
 * https://lore.kernel.org/linux-hwmon/20231110151905.1659873-1-nuno.sa@analog.com/

v2:
 * https://lore.kernel.org/linux-hwmon/20231124-ltc4282-support-v2-0-952bf926f83c@analog.com 

Changes in V3:
- Bindings:
   * Remove 'default' from string types;
   * Update gpios descriptions and removed leftovers from when they were
     integer types.
   * Dropped gpio function. With that, adi,gpio3-mode and adi,gpio-alert were
     dropped.
- Driver:
   * Make all clock ops static;
   * Dropped macro to create debugfs attributes;
   * Dropped GPIO support;
   * Removed regulator consumer header (leftover from v1).

There are still some possible interfaces which are dubious from an hwmon
point view. Namely:

* fet_short_fault
* fet_bad_fault
* power1_good

power1_good and fet_short can be "monitored" with gpio1 and 2
respectively so maybe we could remove the. OTHO, some users might want
the pins free for GPIO usage. fet_bad_fault is a status bit (we also have it in
fault_logs) that might be meaningful to monitor (I think).

Also to note, I'm still seeing the following sparse issue:

"CHECK   drivers/hwmon/ltc4282.c
drivers/hwmon/ltc4282.c:805:34: warning: dubious: x & !y
drivers/hwmon/ltc4282.c:895:34: warning: dubious: x & !y" 

However, this does not look to be directly related with the driver. It's
on FIED_PREP() taking values like !val or !!val.

I'm also removing the GPIO maintainers/reviewers from Cc since there's no
gpiochip support anymore. If not adequate, I'll Cc them again...

---
Nuno Sa (2):
      dt-bindings: hwmon: Add LTC4282 bindings
      hwmon: ltc4282: add support for the LTC4282 chip

 .../devicetree/bindings/hwmon/adi,ltc4282.yaml     |  142 ++
 Documentation/hwmon/index.rst                      |    1 +
 Documentation/hwmon/ltc4282.rst                    |  108 ++
 MAINTAINERS                                        |    8 +
 drivers/hwmon/Kconfig                              |   11 +
 drivers/hwmon/Makefile                             |    1 +
 drivers/hwmon/ltc4282.c                            | 1705 ++++++++++++++++++++
 7 files changed, 1976 insertions(+)
---
base-commit: 44482310b7f8ac4cd8fa7be4cee8c1b260ea5ee9
change-id: 20231124-ltc4282-support-8c1675e31508
--

Thanks!
- Nuno Sá