mbox series

[v1,0/4] hwmon (it87): Correct handling for configuration mode

Message ID 20240401025620.205068-1-frank@crawford.emu.id.au (mailing list archive)
Headers show
Series hwmon (it87): Correct handling for configuration mode | expand

Message

Frank Crawford April 1, 2024, 2:56 a.m. UTC
On various Gigabyte boards, incorrectly entering configuration mode
causes the second Super-IO chip generate LPC buss access errors.
This was preivously fixed by ensuring that the second chip receives the
code to enter configuration mode before the first chip.

On discussion with people who have access to the specification documents
it was noted that this is wrong, and you should not enter or leave
configuration mode for the second chip, as it is enable by the BIOS and
should not be changed.

In particular, this was found to be the case on the Gigabyte X670E Aorus
Master board, where it was reporting a totally wrong chip ID (0x8883)
using the previous method.  This was corrected by not entering
configuration mode, and this has been found to still work with older boards.

---
Frank Crawford (4):
  Rename NOEXIT to BIOSOPEN as more descriptive of requirement
  Do not enter configuration mode for some chip types
  Test for chipset before entering configuration mode
  Remove tests no longer required

 drivers/hwmon/it87.c | 127 +++++++++++++++++++++----------------------
 1 file changed, 61 insertions(+), 66 deletions(-)