From patchwork Wed Jul 31 21:24:23 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiko Stuebner X-Patchwork-Id: 13749220 Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E04C716CD06; Wed, 31 Jul 2024 21:24:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.11.138.130 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722461098; cv=none; b=S5bUSmgFb38zN5zkYiWCyP7wFJY1cNUOZkQNsDsjgLw2LHR81EAeS77GtIX+fkJiDQuLXvBbNlemcftTdcKZ23qrLx+v05ebe6P4LhoMmQEQpspc25//4qL45//PUAyoLK1NTbNKXjt3KoXr5sAbRWZDBgBAb7z+RKLmfQIzONE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722461098; c=relaxed/simple; bh=xB2SONp4XwaJ1YzVBBAmZ8b3kGBVnBVR/zV7uFVrM4I=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=SdSHDJskZnYR4bZKghokHW4WryqkNPXrtrVdjnJBGIRCcoXw1GST5uL3DUJGyEGR5rttfxJlOvVlFr6pa8wxfxAgfvnTlBhnmIf4l5Wjw1yKbeN7NTfh7Rz4a2+mHpmuB4oBb2ix6auGS8xxax1gr8lEmrcyO8NOr83617/9z4M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sntech.de; spf=pass smtp.mailfrom=sntech.de; arc=none smtp.client-ip=185.11.138.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sntech.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sntech.de Received: from i53875ac5.versanet.de ([83.135.90.197] helo=phil.lan) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sZGoL-0007jg-Kg; Wed, 31 Jul 2024 23:24:41 +0200 From: Heiko Stuebner To: lee@kernel.org, jdelvare@suse.com, linux@roeck-us.net, dmitry.torokhov@gmail.com, pavel@ucw.cz Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, heiko@sntech.de, ukleinek@debian.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-hwmon@vger.kernel.org, linux-input@vger.kernel.org, linux-leds@vger.kernel.org Subject: [PATCH v3 0/7] Drivers to support the MCU on QNAP NAS devices Date: Wed, 31 Jul 2024 23:24:23 +0200 Message-Id: <20240731212430.2677900-1-heiko@sntech.de> X-Mailer: git-send-email 2.39.2 Precedence: bulk X-Mailing-List: linux-hwmon@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This implements a set of drivers for the MCU used on QNAP NAS devices. Of course no documentation for the serial protocol is available, so thankfully QNAP has a tool on their rescue-inird to talk to the MCU and I found interceptty [0] to listen to what goes over the serial connection. In general it looks like there are two different generations in general, an "EC" device and now this "MCU" - referenced in the strings of the userspace handlers for those devices. For the MCU "SPEC3" and "SPEC4" are listed which is configured in the model.conf of the device. When setting the value from SPEC4 to SPEC3 on my TS433, the supported commands change, but the command interface stays the same and especially the version command is the same. The binding also does not expose any interals of the device that might change, so hopefully there shouldn't be big roadblocks to support different devices, apart from possibly adapting the commands. changes in v3: mfd - use correct power-off priority: default - constify the cmd-data array in command functions (Dmitry) leds: - don't point to temporary buffers for cdev->name (Florian Eckert) hwmon: - use clamp_val(), don't try to reimplement (Guenter) - add Guenter's Ack input: address Dmitry's comments - constify some cmd arrays - add input-close callback to cancel beep worker - drop initial input event report changes in v2: binding: - rename to qnap,ts433-mcu.yaml (Krzysztof) - drop "preserve formatting" indicator (Krzysztof) - add Krzysztof's Review tag mfd: - fix checkpatch --strict CHECKs - add a MAINTAINERS entry for all qnap-mcu-parts hwmon: address Guenter's review comments: - fix checkpatch strict warnings I've kept the devm_thermal_of_cooling_device_register alignment, because that line is so long that aligning to the "(" would make things way too long and unreadable - add hwmon documentation - spelling corrections - report actual pwm value, not last-set one - make some cmd arrays static - drop pwm_enable as the pwm-mode is not controllable - actually handle error returns from mcu commands - fix calculation of fan-rpm (I read my notes wrong) - fix temperature calculation to return millicelsius as expected - only bail at obviously wrong pwm values, but clamp to min,max - only register cooling-device if cooling-levels are available [0] https://github.com/geoffmeyers/interceptty Heiko Stuebner (7): dt-bindings: mfd: add binding for qnap,ts433-mcu devices mfd: add base driver for qnap-mcu devices leds: add driver for LEDs from qnap-mcu devices Input: add driver for the input part of qnap-mcu devices hwmon: add driver for the hwmon parts of qnap-mcu devices arm64: dts: rockchip: hook up the MCU on the QNAP TS433 arm64: dts: rockchip: set hdd led labels on qnap-ts433 .../bindings/mfd/qnap,ts433-mcu.yaml | 43 ++ Documentation/hwmon/index.rst | 1 + Documentation/hwmon/qnap-mcu-hwmon.rst | 27 ++ MAINTAINERS | 9 + .../boot/dts/rockchip/rk3568-qnap-ts433.dts | 58 +++ drivers/hwmon/Kconfig | 12 + drivers/hwmon/Makefile | 1 + drivers/hwmon/qnap-mcu-hwmon.c | 372 ++++++++++++++++++ drivers/input/misc/Kconfig | 12 + drivers/input/misc/Makefile | 1 + drivers/input/misc/qnap-mcu-input.c | 161 ++++++++ drivers/leds/Kconfig | 11 + drivers/leds/Makefile | 1 + drivers/leds/leds-qnap-mcu.c | 247 ++++++++++++ drivers/mfd/Kconfig | 10 + drivers/mfd/Makefile | 2 + drivers/mfd/qnap-mcu.c | 358 +++++++++++++++++ include/linux/mfd/qnap-mcu.h | 28 ++ 18 files changed, 1354 insertions(+) create mode 100644 Documentation/devicetree/bindings/mfd/qnap,ts433-mcu.yaml create mode 100644 Documentation/hwmon/qnap-mcu-hwmon.rst create mode 100644 drivers/hwmon/qnap-mcu-hwmon.c create mode 100644 drivers/input/misc/qnap-mcu-input.c create mode 100644 drivers/leds/leds-qnap-mcu.c create mode 100644 drivers/mfd/qnap-mcu.c create mode 100644 include/linux/mfd/qnap-mcu.h