| Message ID | 20241026080535.444903-1-akinobu.mita@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | hwmon: (pwm-fan) add option to leave fan on shutdown | expand |
On 10/26/24 01:05, Akinobu Mita wrote: > I sent these patches a long time ago, but I didn't cc them to the DT list, > so the DT bindings changes weren't reviewed. > > There have been a lot of changes to pwm-fan since then, and I've updated > the patch, so please review again. > What changed ? Where is the change log ? Guenter > Akinobu Mita (2): > hwmon: (pwm-fan) add option to leave fan on shutdown > dt-bindings: hwmon: pwm-fan: add retain-state-shutdown property > > Documentation/devicetree/bindings/hwmon/pwm-fan.yaml | 4 ++++ > drivers/hwmon/pwm-fan.c | 6 +++++- > 2 files changed, 9 insertions(+), 1 deletion(-) >
2024年10月27日(日) 1:19 Guenter Roeck <linux@roeck-us.net>: > > On 10/26/24 01:05, Akinobu Mita wrote: > > I sent these patches a long time ago, but I didn't cc them to the DT list, > > so the DT bindings changes weren't reviewed. > > > > There have been a lot of changes to pwm-fan since then, and I've updated > > the patch, so please review again. > > > > What changed ? Where is the change log ? Sorry, I forgot to write the changelog. Changes in v2 Patch 1: - use device_property_read_bool() instead of of_property_read_bool() - skip calling pwn_fan_cleanup() when newly introduced property is set (Since pwm_fan_disable() call in the shutdown() method has been changed to pwm_fan_cleanup() call since commit b99152d4f04b ("hwmon: (pwm-fan) Switch regulator dynamically"), pwm_fan_disable() no longer exists.) Patch 2: - document the new property according to yaml format conversion