| Message ID | 20160720103809.2643157-1-arnd@arndb.de (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
On 07/20/2016 03:37 AM, Arnd Bergmann wrote: > The newly added fts "Teutates" hwmon chip contains a watchdog but fails > to link when the watchdog subsystem is disabled: > > drivers/hwmon/built-in.o: In function `fts_remove': > :(.text+0x161d8): undefined reference to `watchdog_unregister_device' > drivers/hwmon/built-in.o: In function `fts_probe': > :(.text+0x16cb4): undefined reference to `watchdog_register_device' > > This adds a Kconfig dependency in the same way that the other > similar drivers have. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > Fixes: ec9268ba1a96 ("hwmon: Add driver for FTS BMC chip "Teutates"") Thanks - folded into original patch. Guenter > --- > drivers/hwmon/Kconfig | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig > index 15479eb15fa2..eaf2f916d48c 100644 > --- a/drivers/hwmon/Kconfig > +++ b/drivers/hwmon/Kconfig > @@ -488,7 +488,8 @@ config SENSORS_FSCHMD > > config SENSORS_FTSTEUTATES > tristate "Fujitsu Technology Solutions sensor chip Teutates" > - depends on I2C > + depends on I2C && WATCHDOG > + select WATCHDOG_CORE > help > If you say yes here you get support for the Fujitsu Technology > Solutions (FTS) sensor chip "Teutates" including support for > -- To unsubscribe from this list: send the line "unsubscribe linux-hwmon" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig index 15479eb15fa2..eaf2f916d48c 100644 --- a/drivers/hwmon/Kconfig +++ b/drivers/hwmon/Kconfig @@ -488,7 +488,8 @@ config SENSORS_FSCHMD config SENSORS_FTSTEUTATES tristate "Fujitsu Technology Solutions sensor chip Teutates" - depends on I2C + depends on I2C && WATCHDOG + select WATCHDOG_CORE help If you say yes here you get support for the Fujitsu Technology Solutions (FTS) sensor chip "Teutates" including support for
The newly added fts "Teutates" hwmon chip contains a watchdog but fails to link when the watchdog subsystem is disabled: drivers/hwmon/built-in.o: In function `fts_remove': :(.text+0x161d8): undefined reference to `watchdog_unregister_device' drivers/hwmon/built-in.o: In function `fts_probe': :(.text+0x16cb4): undefined reference to `watchdog_register_device' This adds a Kconfig dependency in the same way that the other similar drivers have. Signed-off-by: Arnd Bergmann <arnd@arndb.de> Fixes: ec9268ba1a96 ("hwmon: Add driver for FTS BMC chip "Teutates"") --- drivers/hwmon/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)