From patchwork Thu May 4 09:35:06 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jean Delvare X-Patchwork-Id: 9711289 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 3D29C60235 for ; Thu, 4 May 2017 09:35:31 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3F58128663 for ; Thu, 4 May 2017 09:35:31 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3397D28667; Thu, 4 May 2017 09:35:31 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8B5A928665 for ; Thu, 4 May 2017 09:35:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932131AbdEDJf1 (ORCPT ); Thu, 4 May 2017 05:35:27 -0400 Received: from mx2.suse.de ([195.135.220.15]:35423 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752300AbdEDJfJ (ORCPT ); Thu, 4 May 2017 05:35:09 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 1E643ABD0; Thu, 4 May 2017 09:35:08 +0000 (UTC) Date: Thu, 4 May 2017 11:35:06 +0200 From: Jean Delvare To: linux-hwmon@vger.kernel.org Cc: Russell King , Guenter Roeck Subject: [PATCH] hwmon: (it87) Remove useless test during device detection Message-ID: <20170504113506.1665ecd7@endymion> Organization: SUSE Linux X-Mailer: Claws Mail 3.12.0 (GTK+ 2.24.31; x86_64-suse-linux-gnu) MIME-Version: 1.0 Sender: linux-hwmon-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-hwmon@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP There is no reason to treat the IT8705F differently during device detection. If a single IT8705F chip indeed answers to both Super-IO addresses, we have code in place to detect the duplicate device address and skip the second one. Signed-off-by: Jean Delvare Cc: Russell King Cc: Guenter Roeck --- drivers/hwmon/it87.c | 7 ------- 1 file changed, 7 deletions(-) --- linux-4.11.orig/drivers/hwmon/it87.c 2017-05-01 04:47:48.000000000 +0200 +++ linux-4.11/drivers/hwmon/it87.c 2017-05-04 11:17:49.868328706 +0200 @@ -3224,13 +3224,6 @@ static int __init sm_it87_init(void) goto exit_dev_unregister; found = true; - - /* - * IT8705F may respond on both SIO addresses. - * Stop probing after finding one. - */ - if (sio_data.type == it87) - break; } if (!found) {