From patchwork Sat Dec 23 13:05:27 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joel Stanley X-Patchwork-Id: 10131599 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 58F606019C for ; Sat, 23 Dec 2017 13:06:42 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 516652957C for ; Sat, 23 Dec 2017 13:06:42 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 46407298B3; Sat, 23 Dec 2017 13:06:42 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C89DE2957C for ; Sat, 23 Dec 2017 13:06:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754314AbdLWNGA (ORCPT ); Sat, 23 Dec 2017 08:06:00 -0500 Received: from mail-pg0-f68.google.com ([74.125.83.68]:35382 "EHLO mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753240AbdLWNFz (ORCPT ); Sat, 23 Dec 2017 08:05:55 -0500 Received: by mail-pg0-f68.google.com with SMTP id q20so15505964pgv.2; Sat, 23 Dec 2017 05:05:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=Oc/XGl3ncgTqpFkMvWNIZ7mGgadmtD55+zt/97JNjzk=; b=o3PfiTUqz63so0qt+0BCdN9TnZtBtCq7bl9hREoYLtVSyo9szN0oW9jL7Bb2igyQvw SsyvdpG5oMin6KP0DvC3ltrDlJP0JRa1tYhlU3uAtcNRwNt9SLFWITqQoCFrTSlf8TyP L/74349dg0iO4sn7ZvkRXmlYhI0IuMW+EHg3CC9M1oYj6ZsntQUXXVjxoPXivzD5ioAz LtbIGffD1e1dyIl8Z6f08xP1DvNGJw8pgfwiVJn2v9dKqwCmehYmkvWbjVyh7weDn/4p zdzmFYn5j+elkCGcPH3dWUeEM6d0VUHoFLW8CEHjdW4TYXbqZ5UGiuQ5b9C50q1bw21r MJ1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=Oc/XGl3ncgTqpFkMvWNIZ7mGgadmtD55+zt/97JNjzk=; b=Erdaktz866mykjNJjWPNbjXWvXEG0UVi3dmKyNFtrQ/0IyX6R19HPa+Ie9aKogHKKR 3fLLcFfD31zQfSzkaEYwJg9K6RCFf965o85hJbx4PTto+dxdd11aRGY7GzV04ZZJqyxv FHYSrHh+tAf6lNDvcj7kmhVShR08ATtWgRrMqQl171j1VcWxpkKHeVN3V2sv5UvPqLI/ sL7UjP76EQHjfsJrrDOepNLrY9DEmO+RDXtOkmzsvrqhE4AQn1LAn5HkDaKy35HIcHvo QS58cROdArPuNG6rWZIAwNfKG1Jw+ODZmyq7DjBVoZuzauuTs7aUld3TaRzhFxCaj86b XTew== X-Gm-Message-State: AKGB3mLEdkCOVqLqnYvlnHkJuHgXWTBA/+hGYJCxxWxLCn4kt/aXfh/T i9rq83XwMN/fFuCC5KZpvmM= X-Google-Smtp-Source: ACJfBouTxcmOglyc2AcVofYQw4ZJIVreOfdBbtC6pY+3qMxmAqOtts0CGQSNUHNfR0tTiSiJKWPHcw== X-Received: by 10.98.63.221 with SMTP id z90mr17619149pfj.101.1514034354986; Sat, 23 Dec 2017 05:05:54 -0800 (PST) Received: from aurora.jms.id.au ([45.124.203.15]) by smtp.gmail.com with ESMTPSA id e187sm50410320pfg.23.2017.12.23.05.05.48 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 23 Dec 2017 05:05:53 -0800 (PST) Received: by aurora.jms.id.au (sSMTP sendmail emulation); Sat, 23 Dec 2017 23:35:42 +1030 From: Joel Stanley To: Guenter Roeck , Rob Herring Cc: Philipp Zabel , Mykola Kostenok , Jaghathiswari Rankappagounder Natarajan , Patrick Venture , Andrew Jeffery , devicetree@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 1/2] dt-bindings: hwmon: aspeed-pwm-tacho: Add reset node Date: Sat, 23 Dec 2017 23:35:27 +1030 Message-Id: <20171223130528.5346-2-joel@jms.id.au> X-Mailer: git-send-email 2.15.1 In-Reply-To: <20171223130528.5346-1-joel@jms.id.au> References: <20171223130528.5346-1-joel@jms.id.au> Sender: linux-hwmon-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-hwmon@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The device tree bindings are updated to document the resets phandle, and the example is updated to match what is expected for both the reset and clock phandle. Note that the bindings should have always had the reset controller, as the hardware is unusable without it. Acked-by: Rob Herring Signed-off-by: Joel Stanley --- .../devicetree/bindings/hwmon/aspeed-pwm-tacho.txt | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/Documentation/devicetree/bindings/hwmon/aspeed-pwm-tacho.txt b/Documentation/devicetree/bindings/hwmon/aspeed-pwm-tacho.txt index 367c8203213b..3ac02988a1a5 100644 --- a/Documentation/devicetree/bindings/hwmon/aspeed-pwm-tacho.txt +++ b/Documentation/devicetree/bindings/hwmon/aspeed-pwm-tacho.txt @@ -22,8 +22,9 @@ Required properties for pwm-tacho node: - compatible : should be "aspeed,ast2400-pwm-tacho" for AST2400 and "aspeed,ast2500-pwm-tacho" for AST2500. -- clocks : a fixed clock providing input clock frequency(PWM - and Fan Tach clock) +- clocks : phandle to clock provider with the clock number in the second cell + +- resets : phandle to reset controller with the reset number in the second cell fan subnode format: =================== @@ -48,19 +49,14 @@ Required properties for each child node: Examples: -pwm_tacho_fixed_clk: fixedclk { - compatible = "fixed-clock"; - #clock-cells = <0>; - clock-frequency = <24000000>; -}; - pwm_tacho: pwmtachocontroller@1e786000 { #address-cells = <1>; #size-cells = <1>; #cooling-cells = <2>; reg = <0x1E786000 0x1000>; compatible = "aspeed,ast2500-pwm-tacho"; - clocks = <&pwm_tacho_fixed_clk>; + clocks = <&syscon ASPEED_CLK_APB>; + resets = <&syscon ASPEED_RESET_PWM>; pinctrl-names = "default"; pinctrl-0 = <&pinctrl_pwm0_default &pinctrl_pwm1_default>;