| Message ID | 20190110162429.GA15908@embeddedor (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | hwmon: (adt7462) Mark expected switch fall-throughs | expand |
On Thu, Jan 10, 2019 at 10:24:29AM -0600, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Warning level 3 was used: -Wimplicit-fallthrough=3 > > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> Applied to hwmon-next. Thanks, Guenter > --- > drivers/hwmon/adt7462.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/hwmon/adt7462.c b/drivers/hwmon/adt7462.c > index b0211f731251..030f5d49c061 100644 > --- a/drivers/hwmon/adt7462.c > +++ b/drivers/hwmon/adt7462.c > @@ -448,6 +448,7 @@ static const char *voltage_label(struct adt7462_data *data, int which) > case 3: > return "+1.5V"; > } > + /* fall through */ > case 2: > if (!(data->pin_cfg[1] & ADT7462_PIN22_INPUT)) > return "+12V3"; > @@ -505,6 +506,7 @@ static const char *voltage_label(struct adt7462_data *data, int which) > case 3: > return "+1.5"; > } > + /* fall through */ > case 11: > if (data->pin_cfg[3] >> ADT7462_PIN28_SHIFT == > ADT7462_PIN28_VOLT && > @@ -542,6 +544,7 @@ static int voltage_multiplier(struct adt7462_data *data, int which) > case 3: > return 7800; > } > + /* fall through */ > case 2: > if (!(data->pin_cfg[1] & ADT7462_PIN22_INPUT)) > return 62500; > @@ -599,6 +602,7 @@ static int voltage_multiplier(struct adt7462_data *data, int which) > case 3: > return 7800; > } > + /* fall through */ > case 11: > case 12: > if (data->pin_cfg[3] >> ADT7462_PIN28_SHIFT ==
On 1/10/19 12:31 PM, Guenter Roeck wrote: > On Thu, Jan 10, 2019 at 10:24:29AM -0600, Gustavo A. R. Silva wrote: >> In preparation to enabling -Wimplicit-fallthrough, mark switch cases >> where we are expecting to fall through. >> >> Warning level 3 was used: -Wimplicit-fallthrough=3 >> >> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> > > Applied to hwmon-next. Thank you, Guenter. -- Gustavo
diff --git a/drivers/hwmon/adt7462.c b/drivers/hwmon/adt7462.c index b0211f731251..030f5d49c061 100644 --- a/drivers/hwmon/adt7462.c +++ b/drivers/hwmon/adt7462.c @@ -448,6 +448,7 @@ static const char *voltage_label(struct adt7462_data *data, int which) case 3: return "+1.5V"; } + /* fall through */ case 2: if (!(data->pin_cfg[1] & ADT7462_PIN22_INPUT)) return "+12V3"; @@ -505,6 +506,7 @@ static const char *voltage_label(struct adt7462_data *data, int which) case 3: return "+1.5"; } + /* fall through */ case 11: if (data->pin_cfg[3] >> ADT7462_PIN28_SHIFT == ADT7462_PIN28_VOLT && @@ -542,6 +544,7 @@ static int voltage_multiplier(struct adt7462_data *data, int which) case 3: return 7800; } + /* fall through */ case 2: if (!(data->pin_cfg[1] & ADT7462_PIN22_INPUT)) return 62500; @@ -599,6 +602,7 @@ static int voltage_multiplier(struct adt7462_data *data, int which) case 3: return 7800; } + /* fall through */ case 11: case 12: if (data->pin_cfg[3] >> ADT7462_PIN28_SHIFT ==
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Warning level 3 was used: -Wimplicit-fallthrough=3 Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> --- drivers/hwmon/adt7462.c | 4 ++++ 1 file changed, 4 insertions(+)