diff mbox series

hwmon: corsair-cpro: fix ccp_probe, add delay

Message ID 20200817065428.5974-1-mail@mariuszachmann.de (mailing list archive)
State Not Applicable
Headers show
Series hwmon: corsair-cpro: fix ccp_probe, add delay | expand

Commit Message

Marius Zachmann Aug. 17, 2020, 6:54 a.m. UTC 
Possibly because of the changes in usbhid/hid-core.c the first
raw input report is not received during ccp_probe function and it will timeout.
I am not sure, whether this behaviour is expected after hid_device_io_start or if I
am missing something.
As a solution this adds msleep(50) to ccp_probe so that all initial input reports can
be received.

Signed-off-by: Marius Zachmann <mail@mariuszachmann.de>
---
 drivers/hwmon/corsair-cpro.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

--
2.28.0
diff mbox series

Patch

diff --git a/drivers/hwmon/corsair-cpro.c b/drivers/hwmon/corsair-cpro.c
index 591929ec217a..6359409e6c71 100644
--- a/drivers/hwmon/corsair-cpro.c
+++ b/drivers/hwmon/corsair-cpro.c
@@ -10,6 +10,7 @@ 

 #include <linux/bitops.h>
 #include <linux/completion.h>
+#include <linux/delay.h>
 #include <linux/hid.h>
 #include <linux/hwmon.h>
 #include <linux/kernel.h>
@@ -513,8 +514,8 @@  static int ccp_probe(struct hid_device *hdev, const struct hid_device_id *id)
 	init_completion(&ccp->wait_input_report);

 	hid_device_io_start(hdev);
+	msleep(50); /* make sure, events can be received */

-	/* temp and fan connection status only updates when device is powered on */
 	ret = get_temp_cnct(ccp);
 	if (ret)
 		goto out_hw_close;