| Message ID | 20210915143801.43419-1-kilobyte@angband.pl (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | [v2] hwmon: (dell-smm) Don't build the proc interface if there's no /proc | expand |
On Wed, Sep 15, 2021 at 04:38:01PM +0200, Adam Borowski wrote: There should be some description here. > Signed-off-by: Adam Borowski <kilobyte@angband.pl> Otherwise, for the content: Acked-by: Guenter Roeck <linux@roeck-us.net> > --- > Guenter wrote: > > > -#if IS_ENABLED(CONFIG_I8K) > > > +#if IS_ENABLED(CONFIG_I8K) && IS_ENABLED(CONFIG_PROCFS) > > > This should be expressed as Kconfig dependency: I8K should depend on PROCFS. > > Otherwise the configuration flag is misleading. > > Right, I did not notice I8K does nothing otherwise. > > arch/x86/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig > index 4e001bbbb425..a7365695ff72 100644 > --- a/arch/x86/Kconfig > +++ b/arch/x86/Kconfig > @@ -1253,6 +1253,7 @@ config I8K > tristate "Dell i8k legacy laptop support" > select HWMON > select SENSORS_DELL_SMM > + depends on PROC_FS > help > This option enables legacy /proc/i8k userspace interface in hwmon > dell-smm-hwmon driver. Character file /proc/i8k reports bios version, > -- > 2.33.0 >
On Wednesday 15 September 2021 08:16:13 Guenter Roeck wrote: > On Wed, Sep 15, 2021 at 04:38:01PM +0200, Adam Borowski wrote: > > There should be some description here. > > > Signed-off-by: Adam Borowski <kilobyte@angband.pl> > > Otherwise, for the content: > > Acked-by: Guenter Roeck <linux@roeck-us.net> > > > --- > > Guenter wrote: > > > > -#if IS_ENABLED(CONFIG_I8K) > > > > +#if IS_ENABLED(CONFIG_I8K) && IS_ENABLED(CONFIG_PROCFS) > > > > > This should be expressed as Kconfig dependency: I8K should depend on PROCFS. > > > Otherwise the configuration flag is misleading. > > > > Right, I did not notice I8K does nothing otherwise. > > > > arch/x86/Kconfig | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig > > index 4e001bbbb425..a7365695ff72 100644 > > --- a/arch/x86/Kconfig > > +++ b/arch/x86/Kconfig > > @@ -1253,6 +1253,7 @@ config I8K > > tristate "Dell i8k legacy laptop support" > > select HWMON > > select SENSORS_DELL_SMM > > + depends on PROC_FS Seems like this patch is duplicate of another pending patch: https://lore.kernel.org/linux-hwmon/20210910071921.16777-1-rdunlap@infradead.org/ > > help > > This option enables legacy /proc/i8k userspace interface in hwmon > > dell-smm-hwmon driver. Character file /proc/i8k reports bios version, > > -- > > 2.33.0 > >
diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig index 4e001bbbb425..a7365695ff72 100644 --- a/arch/x86/Kconfig +++ b/arch/x86/Kconfig @@ -1253,6 +1253,7 @@ config I8K tristate "Dell i8k legacy laptop support" select HWMON select SENSORS_DELL_SMM + depends on PROC_FS help This option enables legacy /proc/i8k userspace interface in hwmon dell-smm-hwmon driver. Character file /proc/i8k reports bios version,