diff mbox series

[v3,2/2] dt-bindings: add Delta AHE-50DC fan control module

Message ID 20211207071521.543-3-zev@bewilderbeest.net (mailing list archive)
State Changes Requested
Headers show
Series hwmon: (pmbus) Add Delta AHE-50DC fan control module driver | expand

Commit Message

Zev Weiss Dec. 7, 2021, 7:15 a.m. UTC
This is the integrated fan control module of the Delta AHE-50DC Open19
power shelf.

Signed-off-by: Zev Weiss <zev@bewilderbeest.net>
---
 Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
 1 file changed, 2 insertions(+)

Comments

Krzysztof Kozlowski Dec. 7, 2021, 7:58 a.m. UTC | #1
On 07/12/2021 08:15, Zev Weiss wrote:
> This is the integrated fan control module of the Delta AHE-50DC Open19
> power shelf.
> 
> Signed-off-by: Zev Weiss <zev@bewilderbeest.net>
> ---
>  Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
>  1 file changed, 2 insertions(+)

This is a third version sent within one night, without changelog and any
indication why sending the same three times. Please do not send multiple
versions the same day and give people some time to respond. When
creating a new version, add a changelog under ---.

> 
> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
> index 791079021f1b..1c43cc91f804 100644
> --- a/Documentation/devicetree/bindings/trivial-devices.yaml
> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
> @@ -73,6 +73,8 @@ properties:
>            - dallas,ds4510
>              # Digital Thermometer and Thermostat
>            - dallas,ds75
> +            # Delta AHE-50DC Open19 power shelf fan control module
> +          - delta,ahe50dc-fan
>              # Delta Electronics DPS-650-AB power supply
>            - delta,dps650ab
>            # Delta Electronics DPS920AB 920W 54V Power Supply
> 


Best regards,
Krzysztof
Zev Weiss Dec. 7, 2021, 8:48 a.m. UTC | #2
On Mon, Dec 06, 2021 at 11:58:14PM PST, Krzysztof Kozlowski wrote:
>On 07/12/2021 08:15, Zev Weiss wrote:
>> This is the integrated fan control module of the Delta AHE-50DC Open19
>> power shelf.
>>
>> Signed-off-by: Zev Weiss <zev@bewilderbeest.net>
>> ---
>>  Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
>>  1 file changed, 2 insertions(+)
>
>This is a third version sent within one night, without changelog and any
>indication why sending the same three times. Please do not send multiple
>versions the same day and give people some time to respond. When
>creating a new version, add a changelog under ---.
>

Sorry for the noise -- I wrote changelogs in the cover letter 
(https://lore.kernel.org/linux-hwmon/20211207071521.543-1-zev@bewilderbeest.net/), 
but forgot to include all the recipients of the component patches in the 
CC list of the cover (which I presume would have been preferred), I just 
used git send-email's --cc-cmd flag with get_maintainer.pl.


Zev
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
index 791079021f1b..1c43cc91f804 100644
--- a/Documentation/devicetree/bindings/trivial-devices.yaml
+++ b/Documentation/devicetree/bindings/trivial-devices.yaml
@@ -73,6 +73,8 @@  properties:
           - dallas,ds4510
             # Digital Thermometer and Thermostat
           - dallas,ds75
+            # Delta AHE-50DC Open19 power shelf fan control module
+          - delta,ahe50dc-fan
             # Delta Electronics DPS-650-AB power supply
           - delta,dps650ab
           # Delta Electronics DPS920AB 920W 54V Power Supply