diff mbox series

[v2,1/8] hwmon: (adt7410) Pass name to core driver

Message ID 20211221210438.2637430-2-demonsingur@gmail.com (mailing list archive)
State Superseded
Headers show
Series Refactor ADT7X10 | expand

Commit Message

Cosmin Tanislav Dec. 21, 2021, 9:04 p.m. UTC 
From: Cosmin Tanislav <cosmin.tanislav@analog.com>

It will later be used to register hwmon device using
hwmon_device_register_with_info.

Signed-off-by: Cosmin Tanislav <cosmin.tanislav@analog.com>
---
 drivers/hwmon/adt7410.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Guenter Roeck Dec. 21, 2021, 9:47 p.m. UTC | #1 
On 12/21/21 1:04 PM, Cosmin Tanislav wrote:
> From: Cosmin Tanislav <cosmin.tanislav@analog.com>
> 
> It will later be used to register hwmon device using
> hwmon_device_register_with_info.
> 
> Signed-off-by: Cosmin Tanislav <cosmin.tanislav@analog.com>
> ---
>   drivers/hwmon/adt7410.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hwmon/adt7410.c b/drivers/hwmon/adt7410.c
> index 973db057427b..ef4b5af865e9 100644
> --- a/drivers/hwmon/adt7410.c
> +++ b/drivers/hwmon/adt7410.c
> @@ -45,7 +45,7 @@ static int adt7410_i2c_probe(struct i2c_client *client)
>   			I2C_FUNC_SMBUS_BYTE_DATA | I2C_FUNC_SMBUS_WORD_DATA))
>   		return -ENODEV;
>   
> -	return adt7x10_probe(&client->dev, NULL, client->irq, &adt7410_i2c_ops);
> +	return adt7x10_probe(&client->dev, client->name, client->irq, &adt7410_i2c_ops);
>   }
>   
>   static int adt7410_i2c_remove(struct i2c_client *client)
> 

Did you test this patch on its own ? It should result in a duplicate
attribute error from sysfs if an i2c device tries to register.

Again, that is unacceptable. The patches have to apply on their own
and must not cause any problems.

On a side note, it seems that your e-mails do not have a To: address.

To:     unlisted-recipients:; (no To-header on input)

This results in an error when trying to reply to all.

Guenter
diff mbox series

Patch

diff --git a/drivers/hwmon/adt7410.c b/drivers/hwmon/adt7410.c
index 973db057427b..ef4b5af865e9 100644
--- a/drivers/hwmon/adt7410.c
+++ b/drivers/hwmon/adt7410.c
@@ -45,7 +45,7 @@  static int adt7410_i2c_probe(struct i2c_client *client)
 			I2C_FUNC_SMBUS_BYTE_DATA | I2C_FUNC_SMBUS_WORD_DATA))
 		return -ENODEV;
 
-	return adt7x10_probe(&client->dev, NULL, client->irq, &adt7410_i2c_ops);
+	return adt7x10_probe(&client->dev, client->name, client->irq, &adt7410_i2c_ops);
 }
 
 static int adt7410_i2c_remove(struct i2c_client *client)