| Message ID | 20220205005804.123245-1-linus.walleij@linaro.org (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | hwmon: (ntc_thermistor) Underscore Samsung thermistor | expand |
On Sat, Feb 05, 2022 at 01:58:04AM +0100, Linus Walleij wrote: > The sysfs does not like that we name the thermistor something > that contains a dash: > > ntc-thermistor thermistor: hwmon: 'ssg1404-001221' is not a valid > name attribute, please fix > > Fix it up by switching to an underscore. > > Fixes: e13e979b2b3d ("hwmon: (ntc_thermistor) Add Samsung 1404-001221 NTC") > Signed-off-by: Linus Walleij <linus.walleij@linaro.org> Applied. Thanks, Guenter > --- > drivers/hwmon/ntc_thermistor.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/hwmon/ntc_thermistor.c b/drivers/hwmon/ntc_thermistor.c > index 414204f5704c..9c9e9f4ccb9e 100644 > --- a/drivers/hwmon/ntc_thermistor.c > +++ b/drivers/hwmon/ntc_thermistor.c > @@ -59,7 +59,7 @@ static const struct platform_device_id ntc_thermistor_id[] = { > [NTC_NCP15XH103] = { "ncp15xh103", TYPE_NCPXXXH103 }, > [NTC_NCP18WB473] = { "ncp18wb473", TYPE_NCPXXWB473 }, > [NTC_NCP21WB473] = { "ncp21wb473", TYPE_NCPXXWB473 }, > - [NTC_SSG1404001221] = { "ssg1404-001221", TYPE_NCPXXWB473 }, > + [NTC_SSG1404001221] = { "ssg1404_001221", TYPE_NCPXXWB473 }, > [NTC_LAST] = { }, > }; >
diff --git a/drivers/hwmon/ntc_thermistor.c b/drivers/hwmon/ntc_thermistor.c index 414204f5704c..9c9e9f4ccb9e 100644 --- a/drivers/hwmon/ntc_thermistor.c +++ b/drivers/hwmon/ntc_thermistor.c @@ -59,7 +59,7 @@ static const struct platform_device_id ntc_thermistor_id[] = { [NTC_NCP15XH103] = { "ncp15xh103", TYPE_NCPXXXH103 }, [NTC_NCP18WB473] = { "ncp18wb473", TYPE_NCPXXWB473 }, [NTC_NCP21WB473] = { "ncp21wb473", TYPE_NCPXXWB473 }, - [NTC_SSG1404001221] = { "ssg1404-001221", TYPE_NCPXXWB473 }, + [NTC_SSG1404001221] = { "ssg1404_001221", TYPE_NCPXXWB473 }, [NTC_LAST] = { }, };
The sysfs does not like that we name the thermistor something that contains a dash: ntc-thermistor thermistor: hwmon: 'ssg1404-001221' is not a valid name attribute, please fix Fix it up by switching to an underscore. Fixes: e13e979b2b3d ("hwmon: (ntc_thermistor) Add Samsung 1404-001221 NTC") Signed-off-by: Linus Walleij <linus.walleij@linaro.org> --- drivers/hwmon/ntc_thermistor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)