| Message ID | 20220215191113.16640-8-W_Armin@gmx.de (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | hwmon: (dell-smm) Miscellaneous improvements | expand |
On Tuesday 15 February 2022 20:11:13 Armin Wolf wrote: > When enabling said module parameter, the driver ignores > all feature blacklists on relevant models, which has the > potential for strange side effects. Also there seems to > be a slight chance for unsupported devices to behave > badly when probed for features. > In such cases, the kernel should be tainted to inform > people that these issues might have been caused by > the dell_smm_hwmon driver with "force" enabled. > Also reword the parameter description to remind users > that enabling "force" also enables blacklisted features. > > Tested on a Dell Inspiron 3505. > > Signed-off-by: Armin Wolf <W_Armin@gmx.de> Reviewed-by: Pali Rohár <pali@kernel.org> > --- > drivers/hwmon/dell-smm-hwmon.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c > index 04a41d59da60..67d63932b48a 100644 > --- a/drivers/hwmon/dell-smm-hwmon.c > +++ b/drivers/hwmon/dell-smm-hwmon.c > @@ -87,8 +87,8 @@ MODULE_LICENSE("GPL"); > MODULE_ALIAS("i8k"); > > static bool force; > -module_param(force, bool, 0); > -MODULE_PARM_DESC(force, "Force loading without checking for supported models"); > +module_param_unsafe(force, bool, 0); > +MODULE_PARM_DESC(force, "Force loading without checking for supported models and features"); > > static bool ignore_dmi; > module_param(ignore_dmi, bool, 0); > -- > 2.30.2 >
On Tue, Feb 15, 2022 at 08:11:13PM +0100, Armin Wolf wrote: > When enabling said module parameter, the driver ignores > all feature blacklists on relevant models, which has the > potential for strange side effects. Also there seems to > be a slight chance for unsupported devices to behave > badly when probed for features. > In such cases, the kernel should be tainted to inform > people that these issues might have been caused by > the dell_smm_hwmon driver with "force" enabled. > Also reword the parameter description to remind users > that enabling "force" also enables blacklisted features. > > Tested on a Dell Inspiron 3505. > > Signed-off-by: Armin Wolf <W_Armin@gmx.de> > Reviewed-by: Pali Rohár <pali@kernel.org> Applied to hwmon-next. Thanks, Guenter > --- > drivers/hwmon/dell-smm-hwmon.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > -- > 2.30.2 > > diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c > index 04a41d59da60..67d63932b48a 100644 > --- a/drivers/hwmon/dell-smm-hwmon.c > +++ b/drivers/hwmon/dell-smm-hwmon.c > @@ -87,8 +87,8 @@ MODULE_LICENSE("GPL"); > MODULE_ALIAS("i8k"); > > static bool force; > -module_param(force, bool, 0); > -MODULE_PARM_DESC(force, "Force loading without checking for supported models"); > +module_param_unsafe(force, bool, 0); > +MODULE_PARM_DESC(force, "Force loading without checking for supported models and features"); > > static bool ignore_dmi; > module_param(ignore_dmi, bool, 0);
diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c index 04a41d59da60..67d63932b48a 100644 --- a/drivers/hwmon/dell-smm-hwmon.c +++ b/drivers/hwmon/dell-smm-hwmon.c @@ -87,8 +87,8 @@ MODULE_LICENSE("GPL"); MODULE_ALIAS("i8k"); static bool force; -module_param(force, bool, 0); -MODULE_PARM_DESC(force, "Force loading without checking for supported models"); +module_param_unsafe(force, bool, 0); +MODULE_PARM_DESC(force, "Force loading without checking for supported models and features"); static bool ignore_dmi; module_param(ignore_dmi, bool, 0);
When enabling said module parameter, the driver ignores all feature blacklists on relevant models, which has the potential for strange side effects. Also there seems to be a slight chance for unsupported devices to behave badly when probed for features. In such cases, the kernel should be tainted to inform people that these issues might have been caused by the dell_smm_hwmon driver with "force" enabled. Also reword the parameter description to remind users that enabling "force" also enables blacklisted features. Tested on a Dell Inspiron 3505. Signed-off-by: Armin Wolf <W_Armin@gmx.de> --- drivers/hwmon/dell-smm-hwmon.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.30.2