diff mbox series

hwmon: (asus-ec-sensors) add missing comma in board name list.

Message ID 20220615104520.35687-1-eugene.shalygin@gmail.com (mailing list archive)
State Superseded
Headers show
Series hwmon: (asus-ec-sensors) add missing comma in board name list. | expand

Commit Message

Eugene Shalygin June 15, 2022, 10:45 a.m. UTC 
From: Michael Carns <mike@carns.com>

This fixes a regression introduced by commit 5b4285c57b6f
("hwmon: (asus-ec-sensors) fix Formula VIII definition")
where coma lead to concatenating board names and broke module
loading for C8H.

Signed-off-by: Michael Carns <mike@carns.com>
Signed-off-by: Eugene Shalygin <eugene.shalygin@gmail.com>
---
 drivers/hwmon/asus-ec-sensors.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Eugene Shalygin June 15, 2022, 10:46 a.m. UTC | #1 
The error already made it into 5.19-rc1, unfortunately...
Guenter Roeck June 15, 2022, 11:57 a.m. UTC | #2 
On 6/15/22 03:45, Eugene Shalygin wrote:
> From: Michael Carns <mike@carns.com>
> 
> This fixes a regression introduced by commit 5b4285c57b6f
> ("hwmon: (asus-ec-sensors) fix Formula VIII definition")
> where coma lead to concatenating board names and broke module
> loading for C8H.
> 
> Signed-off-by: Michael Carns <mike@carns.com>
> Signed-off-by: Eugene Shalygin <eugene.shalygin@gmail.com>

We have a Fixes: tag for such purposes. Please use it.

Thanks,
Guenter

> ---
>   drivers/hwmon/asus-ec-sensors.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hwmon/asus-ec-sensors.c b/drivers/hwmon/asus-ec-sensors.c
> index 886a71b4c64e..19d3ca71b360 100644
> --- a/drivers/hwmon/asus-ec-sensors.c
> +++ b/drivers/hwmon/asus-ec-sensors.c
> @@ -268,7 +268,7 @@ static const struct ec_board_info board_info[] = {
>   	},
>   	{
>   		.board_names = {
> -			"ROG CROSSHAIR VIII FORMULA"
> +			"ROG CROSSHAIR VIII FORMULA",
>   			"ROG CROSSHAIR VIII HERO",
>   			"ROG CROSSHAIR VIII HERO (WI-FI)",
>   		},
Eugene Shalygin June 15, 2022, 12:27 p.m. UTC | #3 
> We have a Fixes: tag for such purposes. Please use it.
Thanks, done in v2.

Eugene
diff mbox series

Patch

diff --git a/drivers/hwmon/asus-ec-sensors.c b/drivers/hwmon/asus-ec-sensors.c
index 886a71b4c64e..19d3ca71b360 100644
--- a/drivers/hwmon/asus-ec-sensors.c
+++ b/drivers/hwmon/asus-ec-sensors.c
@@ -268,7 +268,7 @@  static const struct ec_board_info board_info[] = {
 	},
 	{
 		.board_names = {
-			"ROG CROSSHAIR VIII FORMULA"
+			"ROG CROSSHAIR VIII FORMULA",
 			"ROG CROSSHAIR VIII HERO",
 			"ROG CROSSHAIR VIII HERO (WI-FI)",
 		},