diff mbox series

hwmon: remove unused superio_outb function

Message ID 20230323211535.2637939-1-trix@redhat.com (mailing list archive)
State Accepted
Headers show
Series hwmon: remove unused superio_outb function | expand

Commit Message

Tom Rix March 23, 2023, 9:15 p.m. UTC 
clang with W=1 reports
drivers/hwmon/vt1211.c:198:20: error: unused function
  'superio_outb' [-Werror,-Wunused-function]
static inline void superio_outb(int sio_cip, int reg, int val)
                   ^
This function is not used so remove it.

Signed-off-by: Tom Rix <trix@redhat.com>
---
 drivers/hwmon/vt1211.c | 6 ------
 1 file changed, 6 deletions(-)

Comments

Juerg Haefliger March 24, 2023, 6:39 a.m. UTC | #1 
------- Original Message -------
On Thursday, March 23rd, 2023 at 22:15, Tom Rix <trix@redhat.com> wrote:


> 
> 
> clang with W=1 reports
> drivers/hwmon/vt1211.c:198:20: error: unused function
> 'superio_outb' [-Werror,-Wunused-function]
> static inline void superio_outb(int sio_cip, int reg, int val)
> ^
> This function is not used so remove it.
> 
> Signed-off-by: Tom Rix trix@redhat.com

Looks good.

Acked-by: Juerg Haefliger <juergh@proton.me>

...Juerg

 
> ---
> drivers/hwmon/vt1211.c | 6 ------
> 1 file changed, 6 deletions(-)
> 
> diff --git a/drivers/hwmon/vt1211.c b/drivers/hwmon/vt1211.c
> index 4a5e911d26eb..fcd4be7a5a85 100644
> --- a/drivers/hwmon/vt1211.c
> +++ b/drivers/hwmon/vt1211.c
> @@ -195,12 +195,6 @@ struct vt1211_data {
> /* VT1211 logical device numbers /
> #define SIO_VT1211_LDN_HWMON 0x0b / HW monitor */
> 
> -static inline void superio_outb(int sio_cip, int reg, int val)
> -{
> - outb(reg, sio_cip);
> - outb(val, sio_cip + 1);
> -}
> -
> static inline int superio_inb(int sio_cip, int reg)
> {
> outb(reg, sio_cip);
> --
> 2.27.0
Guenter Roeck March 25, 2023, 1:51 p.m. UTC | #2 
On Thu, Mar 23, 2023 at 05:15:35PM -0400, Tom Rix wrote:
> clang with W=1 reports
> drivers/hwmon/vt1211.c:198:20: error: unused function
>   'superio_outb' [-Werror,-Wunused-function]
> static inline void superio_outb(int sio_cip, int reg, int val)
>                    ^
> This function is not used so remove it.
> 
> Signed-off-by: Tom Rix <trix@redhat.com>
> Acked-by: Juerg Haefliger <juergh@proton.me>

Applied.

Thanks,
Guenter
diff mbox series

Patch

diff --git a/drivers/hwmon/vt1211.c b/drivers/hwmon/vt1211.c
index 4a5e911d26eb..fcd4be7a5a85 100644
--- a/drivers/hwmon/vt1211.c
+++ b/drivers/hwmon/vt1211.c
@@ -195,12 +195,6 @@  struct vt1211_data {
 /* VT1211 logical device numbers */
 #define SIO_VT1211_LDN_HWMON	0x0b	/* HW monitor */
 
-static inline void superio_outb(int sio_cip, int reg, int val)
-{
-	outb(reg, sio_cip);
-	outb(val, sio_cip + 1);
-}
-
 static inline int superio_inb(int sio_cip, int reg)
 {
 	outb(reg, sio_cip);