| Message ID | 20230830103620.3611761-1-Naresh.Solanki@9elements.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v4,1/3] dt-bindings: hwmon: Add Infineon TDA38640 | expand |
Hi On Wed, 30 Aug 2023 at 21:02, Conor Dooley <conor@kernel.org> wrote: > > Hey, > > On Wed, Aug 30, 2023 at 12:36:16PM +0200, Naresh Solanki wrote: > > From: Patrick Rudolph <patrick.rudolph@9elements.com> > > > > Add the DT property 'infineon,en-pin-fixed-level' to > > indicated that the chip ENABLE pin is at fixed level > > or left unconnected(has internal pull-down). > > > > Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com> > > Signed-off-by: Naresh Solanki <Naresh.Solanki@9elements.com> > > ---- > > Changes in V4: > > - Update property name & description. > > - Update commit message. > > --- > > .../hwmon/pmbus/infineon,tda38640.yaml | 50 +++++++++++++++++++ > > .../devicetree/bindings/trivial-devices.yaml | 2 - > > 2 files changed, 50 insertions(+), 2 deletions(-) > > create mode 100644 Documentation/devicetree/bindings/hwmon/pmbus/infineon,tda38640.yaml > > > > diff --git a/Documentation/devicetree/bindings/hwmon/pmbus/infineon,tda38640.yaml b/Documentation/devicetree/bindings/hwmon/pmbus/infineon,tda38640.yaml > > new file mode 100644 > > index 000000000000..1df40ee7454a > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/hwmon/pmbus/infineon,tda38640.yaml > > @@ -0,0 +1,50 @@ > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > + > > +$id: http://devicetree.org/schemas/hwmon/pmbus/infineon,tda38640.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Infineon TDA38640 Synchronous Buck Regulator with SVID and I2C > > + > > +maintainers: > > + - Naresh Solanki <naresh.solanki@9elements.com> > > + > > +description: | > > + The Infineon TDA38640 is a 40A Single-voltage Synchronous Buck > > + Regulator with SVID and I2C designed for Industrial use. > > + > > + Datasheet: https://www.infineon.com/dgdl/Infineon-TDA38640-0000-DataSheet-v02_04-EN.pdf?fileId=8ac78c8c80027ecd018042f2337f00c9 > > + > > +properties: > > + compatible: > > + enum: > > + - infineon,tda38640 > > + > > + reg: > > + maxItems: 1 > > + > > + infineon,en-pin-fixed-level: > > + description: | > > The | isn't needed when there is no formatting requiring preservation. Sure will remove. > > > + Indicates that the chip ENABLE pin is at fixed level or left > > + unconnected(has internal pull-down). > > Maybe you've already been over this, but if the pin is called "enable" > why not use the same wording in the property? EN & ENABLE is used interchangeably in the datasheet. Just to keep property name short I use EN. > > > + type: boolean > > + > > +required: > > + - compatible > > + - reg > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + i2c { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + tda38640@40 { > > Use a generic node name please. > > Thanks, > Conor. > > > + compatible = "infineon,tda38640"; > > + reg = <0x40>; > > + }; > > + }; > > + > > diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml > > index 40bc475ee7e1..86c7d34f63bf 100644 > > --- a/Documentation/devicetree/bindings/trivial-devices.yaml > > +++ b/Documentation/devicetree/bindings/trivial-devices.yaml > > @@ -151,8 +151,6 @@ properties: > > - infineon,slb9645tt > > # Infineon SLB9673 I2C TPM 2.0 > > - infineon,slb9673 > > - # Infineon TDA38640 Voltage Regulator > > - - infineon,tda38640 > > # Infineon TLV493D-A1B6 I2C 3D Magnetic Sensor > > - infineon,tlv493d-a1b6 > > # Infineon Multi-phase Digital VR Controller xdpe11280 > > > > base-commit: 919a83d020a8dfa1411c1dc1cff23a833f0f5268 > > -- > > 2.41.0 > >
On Thu, Aug 31, 2023 at 12:49:32AM +0530, Naresh Solanki wrote: > Hi > > On Wed, 30 Aug 2023 at 21:02, Conor Dooley <conor@kernel.org> wrote: > > On Wed, Aug 30, 2023 at 12:36:16PM +0200, Naresh Solanki wrote: > > > + Indicates that the chip ENABLE pin is at fixed level or left > > > + unconnected(has internal pull-down). > > > > Maybe you've already been over this, but if the pin is called "enable" > > why not use the same wording in the property? > EN & ENABLE is used interchangeably in the datasheet. Maybe we can go 1 for 2 in terms of consistency then, rather than 0 for 2. > Just to keep property name short I use EN. Consistency & readability trump brevity. Please pick one term, or point out that this is called two things in the datasheet.
Hi On Thu, 31 Aug 2023 at 21:24, Conor Dooley <conor@kernel.org> wrote: > > On Thu, Aug 31, 2023 at 12:49:32AM +0530, Naresh Solanki wrote: > > Hi > > > > On Wed, 30 Aug 2023 at 21:02, Conor Dooley <conor@kernel.org> wrote: > > > On Wed, Aug 30, 2023 at 12:36:16PM +0200, Naresh Solanki wrote: > > > > > + Indicates that the chip ENABLE pin is at fixed level or left > > > > + unconnected(has internal pull-down). > > > > > > Maybe you've already been over this, but if the pin is called "enable" > > > why not use the same wording in the property? > > EN & ENABLE is used interchangeably in the datasheet. > > Maybe we can go 1 for 2 in terms of consistency then, rather than 0 for > 2. Ack. Will go for EN as that's what is mentioned as pin name in datasheet. > > > Just to keep property name short I use EN. > > Consistency & readability trump brevity. Please pick one term, or point > out that this is called two things in the datasheet. Sure will pick one. i.e., EN. EN is pin name & description as mentioned in datasheet is 'Enable pin to turn on and off the IC' Regards, Naresh >
diff --git a/Documentation/devicetree/bindings/hwmon/pmbus/infineon,tda38640.yaml b/Documentation/devicetree/bindings/hwmon/pmbus/infineon,tda38640.yaml new file mode 100644 index 000000000000..1df40ee7454a --- /dev/null +++ b/Documentation/devicetree/bindings/hwmon/pmbus/infineon,tda38640.yaml @@ -0,0 +1,50 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- + +$id: http://devicetree.org/schemas/hwmon/pmbus/infineon,tda38640.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Infineon TDA38640 Synchronous Buck Regulator with SVID and I2C + +maintainers: + - Naresh Solanki <naresh.solanki@9elements.com> + +description: | + The Infineon TDA38640 is a 40A Single-voltage Synchronous Buck + Regulator with SVID and I2C designed for Industrial use. + + Datasheet: https://www.infineon.com/dgdl/Infineon-TDA38640-0000-DataSheet-v02_04-EN.pdf?fileId=8ac78c8c80027ecd018042f2337f00c9 + +properties: + compatible: + enum: + - infineon,tda38640 + + reg: + maxItems: 1 + + infineon,en-pin-fixed-level: + description: | + Indicates that the chip ENABLE pin is at fixed level or left + unconnected(has internal pull-down). + type: boolean + +required: + - compatible + - reg + +additionalProperties: false + +examples: + - | + i2c { + #address-cells = <1>; + #size-cells = <0>; + + tda38640@40 { + compatible = "infineon,tda38640"; + reg = <0x40>; + }; + }; + diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml index 40bc475ee7e1..86c7d34f63bf 100644 --- a/Documentation/devicetree/bindings/trivial-devices.yaml +++ b/Documentation/devicetree/bindings/trivial-devices.yaml @@ -151,8 +151,6 @@ properties: - infineon,slb9645tt # Infineon SLB9673 I2C TPM 2.0 - infineon,slb9673 - # Infineon TDA38640 Voltage Regulator - - infineon,tda38640 # Infineon TLV493D-A1B6 I2C 3D Magnetic Sensor - infineon,tlv493d-a1b6 # Infineon Multi-phase Digital VR Controller xdpe11280