diff mbox series

hwmon: (pmbus_core) Allow to hook PMBUS_SMBALERT_MASK

Message ID 20240130152903.3651341-1-naresh.solanki@9elements.com (mailing list archive)
State Accepted
Headers show
Series hwmon: (pmbus_core) Allow to hook PMBUS_SMBALERT_MASK | expand

Commit Message

Naresh Solanki Jan. 30, 2024, 3:29 p.m. UTC 
From: Patrick Rudolph <patrick.rudolph@9elements.com>

Use _pmbus_write_word_data to allow intercepting writes to
PMBUS_SMBALERT_MASK in the custom chip specific code.

This is required for MP2971/MP2973 which doesn't follow the
PMBUS specification for PMBUS_SMBALERT_MASK.

Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
Signed-off-by: Naresh Solanki <naresh.solanki@9elements.com>
---
 drivers/hwmon/pmbus/pmbus_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


base-commit: 861c0981648f5b64c86fd028ee622096eb7af05a

Comments

Guenter Roeck Jan. 30, 2024, 4:31 p.m. UTC | #1 
On Tue, Jan 30, 2024 at 08:59:03PM +0530, Naresh Solanki wrote:
> From: Patrick Rudolph <patrick.rudolph@9elements.com>
> 
> Use _pmbus_write_word_data to allow intercepting writes to
> PMBUS_SMBALERT_MASK in the custom chip specific code.
> 
> This is required for MP2971/MP2973 which doesn't follow the
> PMBUS specification for PMBUS_SMBALERT_MASK.

Applied, but is there going to be a follow-up patch for those chips ?

Thanks,
Guenter
Naresh Solanki Jan. 30, 2024, 5:01 p.m. UTC | #2 
Hi Guenter,

On Tue, 30 Jan 2024 at 22:01, Guenter Roeck <linux@roeck-us.net> wrote:
>
> On Tue, Jan 30, 2024 at 08:59:03PM +0530, Naresh Solanki wrote:
> > From: Patrick Rudolph <patrick.rudolph@9elements.com>
> >
> > Use _pmbus_write_word_data to allow intercepting writes to
> > PMBUS_SMBALERT_MASK in the custom chip specific code.
> >
> > This is required for MP2971/MP2973 which doesn't follow the
> > PMBUS specification for PMBUS_SMBALERT_MASK.
>
> Applied, but is there going to be a follow-up patch for those chips ?
Yes.

Regards,
Naresh
>
> Thanks,
> Guenter
diff mbox series

Patch

diff --git a/drivers/hwmon/pmbus/pmbus_core.c b/drivers/hwmon/pmbus/pmbus_core.c
index 1363d9f89181..cb4c65a7f288 100644
--- a/drivers/hwmon/pmbus/pmbus_core.c
+++ b/drivers/hwmon/pmbus/pmbus_core.c
@@ -3188,7 +3188,7 @@  static int pmbus_regulator_notify(struct pmbus_data *data, int page, int event)
 
 static int pmbus_write_smbalert_mask(struct i2c_client *client, u8 page, u8 reg, u8 val)
 {
-	return pmbus_write_word_data(client, page, PMBUS_SMBALERT_MASK, reg | (val << 8));
+	return _pmbus_write_word_data(client, page, PMBUS_SMBALERT_MASK, reg | (val << 8));
 }
 
 static irqreturn_t pmbus_fault_handler(int irq, void *pdata)