| Message ID | 20240131005856.10180-3-ivor@iwanders.net (mailing list archive) |
|---|---|
| State | Handled Elsewhere |
| Headers | show |
| Series | Surface fan monitoring driver | expand |
On Tue, Jan 30, 2024 at 07:58:56PM -0500, Ivor Wanders wrote: > Add an entry for the fan speed function. > Add this new entry to the Surface Pro 9 group. > > Signed-off-by: Ivor Wanders <ivor@iwanders.net> > Link: https://github.com/linux-surface/kernel/pull/144 > Reviewed-by: Maximilian Luz <luzmaximilian@gmail.com> I wasn't sure if the Reviewed-by: tag means that I should apply the patch through the hwmon subsystem. If so, please let me know. For now I'll assume that it will be applied through a platform tree. Thanks, Guenter
Am 1/31/2024 um 2:24 PM schrieb Guenter Roeck: > On Tue, Jan 30, 2024 at 07:58:56PM -0500, Ivor Wanders wrote: >> Add an entry for the fan speed function. >> Add this new entry to the Surface Pro 9 group. >> >> Signed-off-by: Ivor Wanders <ivor@iwanders.net> >> Link: https://github.com/linux-surface/kernel/pull/144 >> Reviewed-by: Maximilian Luz <luzmaximilian@gmail.com> > > I wasn't sure if the Reviewed-by: tag means that I should apply the patch > through the hwmon subsystem. If so, please let me know. For now I'll > assume that it will be applied through a platform tree. I think it would make more sense for it to go through pdx86 (as usual for platform/surface). That would avoid any potential merge conflicts if we get more changes to the surface_aggregator_registry later on. Hans, Ilpo, could you please take this? Also I just noticed that Ilpo wasn't CCd, I assume because of an older MAINTAINERS list. Ivor, please add him for any next submissions to platform/surface. Best regards, Max
> I assume because of an older MAINTAINERS list. Ivor, please add him for > any next submissions to platform/surface. Yes, mea culpa. Guenter also ran into trouble applying the v4 version of the patch yesterday. I'm sorry I didn't base this off the correct branch everyone, will be sure to do so in the future! ~Ivor
On Wed, 31 Jan 2024, Maximilian Luz wrote: > Am 1/31/2024 um 2:24 PM schrieb Guenter Roeck: > > On Tue, Jan 30, 2024 at 07:58:56PM -0500, Ivor Wanders wrote: > > > Add an entry for the fan speed function. > > > Add this new entry to the Surface Pro 9 group. > > > > > > Signed-off-by: Ivor Wanders <ivor@iwanders.net> > > > Link: https://github.com/linux-surface/kernel/pull/144 > > > Reviewed-by: Maximilian Luz <luzmaximilian@gmail.com> > > > > I wasn't sure if the Reviewed-by: tag means that I should apply the patch > > through the hwmon subsystem. If so, please let me know. For now I'll > > assume that it will be applied through a platform tree. > > I think it would make more sense for it to go through pdx86 (as usual > for platform/surface). That would avoid any potential merge conflicts > if we get more changes to the surface_aggregator_registry later on. > > Hans, Ilpo, could you please take this? > > Also I just noticed that Ilpo wasn't CCd, I assume because of an older > MAINTAINERS list. Ivor, please add him for any next submissions to > platform/surface. Okay, thanks for letting me know (I assumed the opposite). I'll take it through pdx86.
On Thu, 1 Feb 2024, Ilpo Järvinen wrote: > On Wed, 31 Jan 2024, Maximilian Luz wrote: > > > Am 1/31/2024 um 2:24 PM schrieb Guenter Roeck: > > > On Tue, Jan 30, 2024 at 07:58:56PM -0500, Ivor Wanders wrote: > > > > Add an entry for the fan speed function. > > > > Add this new entry to the Surface Pro 9 group. > > > > > > > > Signed-off-by: Ivor Wanders <ivor@iwanders.net> > > > > Link: https://github.com/linux-surface/kernel/pull/144 > > > > Reviewed-by: Maximilian Luz <luzmaximilian@gmail.com> > > > > > > I wasn't sure if the Reviewed-by: tag means that I should apply the patch > > > through the hwmon subsystem. If so, please let me know. For now I'll > > > assume that it will be applied through a platform tree. > > > > I think it would make more sense for it to go through pdx86 (as usual > > for platform/surface). That would avoid any potential merge conflicts > > if we get more changes to the surface_aggregator_registry later on. > > > > Hans, Ilpo, could you please take this? > > > > Also I just noticed that Ilpo wasn't CCd, I assume because of an older > > MAINTAINERS list. Ivor, please add him for any next submissions to > > platform/surface. > > Okay, thanks for letting me know (I assumed the opposite). I'll take it > through pdx86. Patch 2/2 applied to review-ilpo.
diff --git a/drivers/platform/surface/surface_aggregator_registry.c b/drivers/platform/surface/surface_aggregator_registry.c index aeb3feae4..035d6b410 100644 --- a/drivers/platform/surface/surface_aggregator_registry.c +++ b/drivers/platform/surface/surface_aggregator_registry.c @@ -74,6 +74,12 @@ static const struct software_node ssam_node_tmp_pprof = { .parent = &ssam_node_root, }; +/* Fan speed function. */ +static const struct software_node ssam_node_fan_speed = { + .name = "ssam:01:05:01:01:01", + .parent = &ssam_node_root, +}; + /* Tablet-mode switch via KIP subsystem. */ static const struct software_node ssam_node_kip_tablet_switch = { .name = "ssam:01:0e:01:00:01", @@ -305,6 +311,7 @@ static const struct software_node *ssam_node_group_sp9[] = { &ssam_node_bat_ac, &ssam_node_bat_main, &ssam_node_tmp_pprof, + &ssam_node_fan_speed, &ssam_node_pos_tablet_switch, &ssam_node_hid_kip_keyboard, &ssam_node_hid_kip_penstash,